abra recipe upgrade calculates tag based on ghost tags in a repo #195

New Issue

2021-10-11T14:50:43Z

knoflook commented

2021-10-11 14:50:43 +00:00

Describe the current behavior

when running abra recipe upgrade --major/minor/patch a weird thing happens. Namely, abra uses the last tag ever created to calculate a new version even if this tag was deleted before running the command

Steps to reproduce

suppose you have the following tags in your repo:

1.4.0+whatever
1.5.0+whatever

remove the last tag from an app
git tag -d 1.5.0+whatever
then run
abra recipe release --minor <app name>
abra will tag the new release as 1.6.0+whatever

Describe the expected behavior

abra should use the latest available tag and tag the new release as 1.5.0+whatever

Additional information

version: dev-59bff9c (any recent version does this afaik)

I tried checking some things in the plumbing.Tag object we're getting from the repo: https://pkg.go.dev/github.com/go-git/go-git/v5@v5.4.2/plumbing/object#Tag
unfortunately, neither checking for empty Target nor empty Hash does the trick
I also tried running git gc --aggressive before letting abra do its thing and it didn't help either. I'm a bit stuck with that and need help from some git magician 🧙

## Describe the current behavior when running `abra recipe upgrade --major/minor/patch` a weird thing happens. Namely, abra uses the last tag ever created to calculate a new version **even if this tag was deleted before running the command** ## Steps to reproduce suppose you have the following tags in your repo: ``` 1.4.0+whatever 1.5.0+whatever ``` remove the last tag from an app `git tag -d 1.5.0+whatever` then run `abra recipe release --minor <app name>` abra will tag the new release as `1.6.0+whatever` ## Describe the expected behavior abra should use the latest available tag and tag the new release as `1.5.0+whatever` ## Additional information - version: dev-59bff9c (any recent version does this afaik) I tried checking some things in the `plumbing.Tag` object we're getting from the repo: https://pkg.go.dev/github.com/go-git/go-git/v5@v5.4.2/plumbing/object#Tag unfortunately, neither checking for empty `Target` nor empty `Hash` does the trick I also tried running `git gc --aggressive` before letting abra do its thing and it didn't help either. I'm a bit stuck with that and need help from some git magician 🧙

knoflook added this to the (deleted) milestone 2021-10-11 14:50:43 +00:00

knoflook added the bug abra labels 2021-10-11 14:50:43 +00:00

decentral1se referenced this issue from a commit

2021-10-11 22:57:22 +00:00

fix: dont loop over dead tags

decentral1se closed this issue

2021-10-11 22:57:23 +00:00

decentral1se commented

2021-10-11 22:57:38 +00:00

No idea what I'm doing.

https://github.com/src-d/go-git/issues/983

No idea what I'm doing. https://github.com/src-d/go-git/issues/983