abra recipe upgrade calculates tag based on ghost tags in a repo #195
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#195
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the current behavior
when running
abra recipe upgrade --major/minor/patch
a weird thing happens. Namely, abra uses the last tag ever created to calculate a new version even if this tag was deleted before running the commandSteps to reproduce
suppose you have the following tags in your repo:
remove the last tag from an app
git tag -d 1.5.0+whatever
then run
abra recipe release --minor <app name>
abra will tag the new release as
1.6.0+whatever
Describe the expected behavior
abra should use the latest available tag and tag the new release as
1.5.0+whatever
Additional information
I tried checking some things in the
plumbing.Tag
object we're getting from the repo: https://pkg.go.dev/github.com/go-git/go-git/v5@v5.4.2/plumbing/object#Tagunfortunately, neither checking for empty
Target
nor emptyHash
does the trickI also tried running
git gc --aggressive
before letting abra do its thing and it didn't help either. I'm a bit stuck with that and need help from some git magician 🧙No idea what I'm doing.
https://github.com/src-d/go-git/issues/983