run ... app bash explodes when the containers aren't there #198

New Issue

decentral1se · 2021-10-12T09:58:07Z

decentral1se commented

2021-10-12 09:58:07 +00:00

Describe the current behavior

When a container isn't there, it blows up.

Steps to reproduce

➜  coop-cloud-apps (main) ✗ abra app run traefik.autonomic.zone web sh 
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
coopcloud.tech/abra/cli/app.glob..func21(0xc00051e900)
	/home/decentral1se/work/coop-cloud/abra/cli/app/run.go:96 +0x788
github.com/urfave/cli/v2.(*Command).Run(0x14f4860, 0xc00051e780)
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:163 +0x64a
github.com/urfave/cli/v2.(*App).RunAsSubcommand(0xc000485380, 0xc00051e580)
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434 +0x9a6
github.com/urfave/cli/v2.(*Command).startApp(0x14f5700, 0xc00051e580)
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278 +0x713
github.com/urfave/cli/v2.(*Command).Run(0xc00051e2c0, 0x7fff157e6843)
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94 +0x7bc
github.com/urfave/cli/v2.(*App).RunContext(0xc0004851e0, {0xef9138, 0xc00013a000}, {0xc00010e180, 0x6, 0x6})
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313 +0x81e
github.com/urfave/cli/v2.(*App).Run(...)
	/home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224
coopcloud.tech/abra/cli.RunApp({0xd9cf87, 0x0}, {0xeee7c0, 0x28})
	/home/decentral1se/work/coop-cloud/abra/cli/cli.go:110 +0x433
main.main()
	/home/decentral1se/work/coop-cloud/abra/cmd/abra/main.go:23 +0xbb

Describe the expected behavior

Gives a decent error message.

Additional information

version: dev-4235e06

## Describe the current behavior When a container isn't there, it blows up. ## Steps to reproduce ``` ➜ coop-cloud-apps (main) ✗ abra app run traefik.autonomic.zone web sh panic: runtime error: index out of range [0] with length 0 goroutine 1 [running]: coopcloud.tech/abra/cli/app.glob..func21(0xc00051e900) /home/decentral1se/work/coop-cloud/abra/cli/app/run.go:96 +0x788 github.com/urfave/cli/v2.(*Command).Run(0x14f4860, 0xc00051e780) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:163 +0x64a github.com/urfave/cli/v2.(*App).RunAsSubcommand(0xc000485380, 0xc00051e580) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434 +0x9a6 github.com/urfave/cli/v2.(*Command).startApp(0x14f5700, 0xc00051e580) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278 +0x713 github.com/urfave/cli/v2.(*Command).Run(0xc00051e2c0, 0x7fff157e6843) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94 +0x7bc github.com/urfave/cli/v2.(*App).RunContext(0xc0004851e0, {0xef9138, 0xc00013a000}, {0xc00010e180, 0x6, 0x6}) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313 +0x81e github.com/urfave/cli/v2.(*App).Run(...) /home/decentral1se/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224 coopcloud.tech/abra/cli.RunApp({0xd9cf87, 0x0}, {0xeee7c0, 0x28}) /home/decentral1se/work/coop-cloud/abra/cli/cli.go:110 +0x433 main.main() /home/decentral1se/work/coop-cloud/abra/cmd/abra/main.go:23 +0xbb ``` ## Describe the expected behavior Gives a decent error message. ## Additional information  - version: `dev-4235e06`

decentral1se added the

bug

abra

labels 2021-10-12 09:58:07 +00:00

decentral1se added this to the Beta release (software) project 2021-10-17 20:19:04 +00:00

decentral1se referenced this issue from a commit

2021-10-19 20:51:05 +00:00

fix: handle missing containers

decentral1se closed this issue

2021-10-19 20:51:06 +00:00

Sign in to join this conversation.