move to go 1.16? #201

New Issue

knoflook · 2021-10-13T11:53:25Z

knoflook commented

2021-10-13 11:53:25 +00:00

As @3wordchant pointed out, debian testing and fedora 34 use go 1.16. It's not deprecated yet, and will be supported till feburary 2022 if i understand go versions right. We're not using any 1.17 functionality yet and i succesfully compiled abra with no code changes using go 1.16.

2021-10-13-134811_1055x203_scrot.png

32 KiB

❤️ 1

knoflook added the

abra

label 2021-10-13 11:53:51 +00:00

decentral1se commented

2021-10-13 13:53:57 +00:00

Installing manually is really easy?

https://golang.org/doc/install

1.17 has a significant reduction in binary sizes built-in, so it is worth it imho.

Installing manually is really easy? > https://golang.org/doc/install 1.17 has a significant reduction in binary sizes built-in, so it is worth it imho.

3wordchant commented

2021-10-13 13:58:48 +00:00

@decentral1se can we continue having the release binaries built using 1.17, while only requiring minimum 1.16 to build locally?

Requiring a newer version of the language than what's commonly available seems like an infra smell that I'd like to avoid if we can.

@decentral1se can we continue having the release binaries built using 1.17, while only requiring minimum 1.16 to build locally? Requiring a newer version of the language than what's commonly available seems like an infra smell that I'd like to avoid if we can.

knoflook commented

2021-10-13 14:05:06 +00:00

also we're only saving about 1MB using 1.17

18898944 Oct 13 16:01 ../abra-1.16.9
17956864 Oct 13 16:03 ../abra-1.17.2

also we're only saving about 1MB using 1.17 ``` 18898944 Oct 13 16:01 ../abra-1.16.9 17956864 Oct 13 16:03 ../abra-1.17.2 ```

decentral1se commented

2021-10-13 14:46:38 +00:00

Oh yeah right, we could set the Golang version to really low, like 1.13 or something? To avoid this issue happening and letting people do their thing and then make the build CI to 1.17! Just tried setting it to 1.13 and I could compile locally. Think 1.13 was when modules went into the langugae (which we use). Maybe we can go further back?

Oh yeah right, we could set the Golang version to really low, like `1.13` or something? To avoid this issue happening and letting people do their thing and then make the build CI to 1.17! Just tried setting it to `1.13` and I could compile locally. Think `1.13` was when modules went into the langugae (which we use). Maybe we can go further back?

knoflook commented

2021-10-13 14:48:54 +00:00

that's strange because I couldn't compile it with 1.15 🤔 it was complaining about io/fs missing and indeed this library was introduced with go 1.16

decentral1se commented

2021-10-13 14:50:10 +00:00

hmmmmm.... 1.16 it is then 🤷‍♀️

hmmmmm.... `1.16` it is then 🤷‍♀️

knoflook commented

2021-10-13 14:53:49 +00:00

ahh i see why that is. Setting go version in go.mod doesn't affect how the program is compiled, it's just setting a requirement. So you'd have to actually download go 1.13, install it and then compile

decentral1se referenced this issue from a commit

2021-10-13 14:56:54 +00:00

chore: set 1.16 as requirement now

decentral1se closed this issue

2021-10-13 14:56:54 +00:00

Sign in to join this conversation.