Abra doesn't report deployment status #209

New Issue

2021-10-20T15:40:33Z

decentral1se commented

2021-10-20 15:40:33 +00:00

Describe the current behavior

abra app deploy ... doesn't really tell you if something went well or not.

Steps to reproduce

Deploy anything 🙏

Describe the expected behavior

If things fail, they are picked up. Rollbacks, broken entrypoints, failure after some X seconds, etc.

Additional information

version: anything so far

## Describe the current behavior `abra app deploy ...` doesn't really tell you if something went well or not. ## Steps to reproduce Deploy anything 🙏 ## Describe the expected behavior If things fail, they are picked up. Rollbacks, broken entrypoints, failure after some X seconds, etc. ## Additional information  - version: anything so far

decentral1se added the bug abra labels 2021-10-20 15:40:34 +00:00

decentral1se added this to the Beta release (software) project 2021-10-20 15:40:34 +00:00

decentral1se self-assigned this 2021-11-09 10:29:08 +00:00

decentral1se commented

2021-11-10 07:32:21 +00:00

Refs:

Refs: - https://github.com/docker/cli/issues/373 - https://github.com/docker/cli/blob/c3e5445659bab623af24958b74cb0ba2b0b3828f/cli/command/service/progress/progress.go - https://github.com/docker/cli/blob/c3e5445659bab623af24958b74cb0ba2b0b3828f/cli/command/service/helpers.go#L18 - https://github.com/docker/cli/blob/c3e5445659bab623af24958b74cb0ba2b0b3828f/cli/command/service/update.go

decentral1se referenced this issue from a commit

2021-11-10 08:07:23 +00:00

feat: rudimentary deploy status checking

decentral1se commented

2021-11-10 08:37:52 +00:00

With b67ad02f87 we now have a hook into the service convergence checking logic in the upstream client code 🥳 This is officially Better Than Nothing ™️ (what we had before and what the docker client itself has), let's see how it goes! Will be testing, maybe we can improve on it, will leave this ticket open.

With https://git.coopcloud.tech/coop-cloud/abra/commit/b67ad02f87d9aefffbbf192a4d69235c8920f9f6 we now have a hook into the service convergence checking logic in the upstream client code 🥳 This is officially Better Than Nothing ™️ (what we had before and what the docker client itself has), let's see how it goes! Will be testing, maybe we can improve on it, will leave this ticket open.

decentral1se removed their assignment 2021-11-10 08:38:01 +00:00

decentral1se referenced this issue

2021-11-13 22:50:25 +00:00

Missing timeout for converge logic #246

decentral1se commented

2021-11-13 22:50:47 +00:00