Add app names and domains consistently to various abra commands #252

New Issue

kawaiipunk · 2021-11-20T14:29:33Z

kawaiipunk commented

2021-11-20 14:29:33 +00:00

Describe the problem to be solved

It's hard to remember all the "app names" and domain for a large number of apps. Sometimes app names are the same as the domain name. Sometimes they're different.

Describe the solution you would like

The output for abra app ps and abra app ls should show a column with the app name. abra app ps should also show a column with the domain of the app.

We'll need to change the name of the "NAMES" column on the current output of abra app ps if we do this.

This will help the user remember app names.

## Describe the problem to be solved It's hard to remember all the "app names" and domain for a large number of apps. Sometimes app names are the same as the domain name. Sometimes they're different. ## Describe the solution you would like The output for `abra app ps` and `abra app ls` should show a column with the app name. `abra app ps` should also show a column with the domain of the app. We'll need to change the name of the "NAMES" column on the current output of `abra app ps` if we do this. This will help the user remember app names.

kawaiipunk added the

enhancement

abra

labels 2021-11-20 14:29:33 +00:00

decentral1se commented

2021-11-21 13:04:06 +00:00

Lovely.

I've attached images of the new ls/ps output and commits ref this issue for changes. The screen real estate required for a full abra app ls --status is quite a lot now though, I do worry. Is this an issue? For ps, instead of replacing "NAMES" I changed it to "SERVICES" alongside "APP NAME".

I am wondering also, in relation to #253 ("App version output could be better"), could abra app ps and abra app version be merged? Is ps even a good name, I wonder? What is important to have shown? My guestimates are: app name, service names (app, db, etc.), when created, container uptime, upstream image/tag, recipe version.

/cc @knoflook @3wordchant

Lovely. I've attached images of the new `ls`/`ps` output and commits ref this issue for changes. The screen real estate required for a full `abra app ls --status` is quite a lot now though, I do worry. Is this an issue? For `ps`, instead of replacing "NAMES" I changed it to "SERVICES" alongside "APP NAME". I am wondering also, in relation to https://git.coopcloud.tech/coop-cloud/organising/issues/253 ("App version output could be better"), could `abra app ps` and `abra app version` be merged? Is `ps` even a good name, I wonder? What is important to have shown? My guestimates are: app name, service names (`app`, `db`, etc.), when created, container uptime, upstream image/tag, recipe version. /cc @knoflook @3wordchant

lsnew.png

111 KiB

psoutput.png

103 KiB

decentral1se referenced this issue

2021-11-21 13:04:50 +00:00

App version output could be better #253

decentral1se added the

awaiting-feedback

label 2021-11-21 13:06:27 +00:00

decentral1se referenced this issue from a commit

2021-11-21 13:07:34 +00:00

fix: add app name to list output

decentral1se referenced this issue from a commit

2021-11-21 13:07:34 +00:00

fix: add app name to ps output + docs

decentral1se added the

design

label 2021-11-21 13:07:57 +00:00

3wordchant commented

2021-11-21 14:11:44 +00:00

The screen real estate required for a full abra app ls --status is quite a lot now though, I do worry.

How painful would it be to make the server into a row instead of a column?

Unless someone's using --type/-t, they're likely to have several results per server, and that blank space in the left-most column looks like a delicious bit of space

could abra app ps and abra app version be merged?
What is important to have shown?

abra app info? Agree with your list o' stuff. Wondering about seeing the handy error message that's sometimes in docker ps also.

> The screen real estate required for a full `abra app ls --status` is quite a lot now though, I do worry. How painful would it be to make the server into a row instead of a column? Unless someone's using `--type/-t`, they're likely to have several results per server, and that blank space in the left-most column looks like a delicious bit of space ![image](/attachments/0c67a3b3-9847-4e1f-af47-b19085eda88c) > could `abra app ps` and `abra app version` be merged? > What is important to have shown? `abra app info`? Agree with your list o' stuff. Wondering about seeing the handy error message that's sometimes in `docker ps` also.

image.png

322 KiB

decentral1se commented

2021-11-21 14:34:57 +00:00

How painful would it be to make the server into a row instead of a column?

Oh sheyat yeah that could work but not sure I have the same idea: could you sketch out a quick layout of this new table with the existing columns in the new places? It would be a re-write of the table layout code but I don't think it would be too drastic (if I am following correctly...).

> How painful would it be to make the server into a row instead of a column? Oh sheyat yeah that could work but not sure I have the same idea: could you sketch out a quick layout of this new table with the existing columns in the new places? It would be a re-write of the table layout code but I don't think it would be too drastic (if I am following correctly...).

decentral1se added this to the Beta release (software) project 2021-11-21 14:36:38 +00:00

decentral1se added this to the UI / UX testing milestone 2021-11-21 14:36:42 +00:00

3wordchant commented

2021-11-21 14:37:54 +00:00

Before:

+-----------------------+---------------------+-------------------------------+-------------------------------+
|        SERVER         |        TYPE         |           APP NAME            |            DOMAIN             |
+-----------------------+---------------------+-------------------------------+-------------------------------+
| mellor.coopcloud.tech | custom-html         | custom_html_servers_coop      | servers.coop                  |
|                       | drone               | drone_build_coopcloud_tech    | build.coopcloud.tech          |
|                       | drone-docker-runner | build-runner_coopcloud_tech   | build-runner.coopcloud.tech   |
|                       | gitea               | git_coopcloud_tech            | git.coopcloud.tech            |
|                       | keycloak            | login_servers_coop            | login.servers.coop            |
|                       | mediawiki           | wiki_servers_coop             | wiki.servers.coop             |
|                       | traefik             | traefik_mellor_coopcloud_tech | traefik.mellor.coopcloud.tech |
+-----------------------+---------------------+-------------------------------+-------------------------------+

After:

+---------------------+-------------------------------+-------------------------------+
|        TYPE         |           APP NAME            |            DOMAIN             |
+---------------------+-------------------------------+-------------------------------+
| SERVER: mellor.coopcloud.tech                                                       |
+---------------------+-------------------------------+-------------------------------+
| custom-html         | custom_html_servers_coop      | servers.coop                  |
| drone               | drone_build_coopcloud_tech    | build.coopcloud.tech          |
| drone-docker-runner | build-runner_coopcloud_tech   | build-runner.coopcloud.tech   |
| gitea               | git_coopcloud_tech            | git.coopcloud.tech            |
| keycloak            | login_servers_coop            | login.servers.coop            |
| mediawiki           | wiki_servers_coop             | wiki.servers.coop             |
| traefik             | traefik_mellor_coopcloud_tech | traefik.mellor.coopcloud.tech |
+---------------------+-------------------------------+-------------------------------+

👍 1

knoflook commented

2021-11-22 13:41:57 +00:00

I wouldn't merge ps and version into one command. They give completely different outputs and are used for different purposes (keeping stuff up to date vs checking health of apps). I like what @3wordchant proposes re: abra app ls

I wouldn't merge ps and version into one command. They give completely different outputs and are used for different purposes (keeping stuff up to date vs checking health of apps). I like what @3wordchant proposes re: `abra app ls`

decentral1se commented

2021-11-22 16:53:31 +00:00

Ok, fair point on avoiding the merge. I tried to do this row/column transformation but I don't see any handy way to do it. I am not sure what to try next.

knoflook commented

2021-11-24 10:34:52 +00:00

what about using fmt.Println to print the server name and then printing the table?

server: mellor.coopcloud.tech
+---------------------+-------------------------------+-------------------------------+
|        TYPE         |           APP NAME            |            DOMAIN             |
+---------------------+-------------------------------+-------------------------------+
| custom-html         | custom_html_servers_coop      | servers.coop                  |
| drone               | drone_build_coopcloud_tech    | build.coopcloud.tech          |
| drone-docker-runner | build-runner_coopcloud_tech   | build-runner.coopcloud.tech   |
| gitea               | git_coopcloud_tech            | git.coopcloud.tech            |
| keycloak            | login_servers_coop            | login.servers.coop            |
| mediawiki           | wiki_servers_coop             | wiki.servers.coop             |
| traefik             | traefik_mellor_coopcloud_tech | traefik.mellor.coopcloud.tech |
+---------------------+-------------------------------+-------------------------------+

decentral1se referenced this issue from a commit

2021-12-12 16:52:15 +00:00

fix: improve ls output

decentral1se closed this issue

2021-12-12 16:52:15 +00:00

Sign in to join this conversation.