Ensure compose.**.yml files are validated #254
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#254
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the current behavior
Upstream validation isn't great. Broken compose files get deployed. Some things get handled, some things not. E.g. no
image: ...
doesn't get caught but a missingversion: ...
does?This also has a confusing error message (I simply removed
version: ...
from the gitea recipe compose config...). That could be improved also.Steps to reproduce
#243 (comment)
Describe the expected behavior
abra
bails out if anything is broken in the compose config.Any idea how this might be fixed?
Idk because we're just running
9bc104eff0/cli/compose/schema/schema.go (L63-L83)
and that loads https://github.com/docker/cli/blob/master/cli/compose/schema/data/config_schema_v3.8.json which then is perhaps wrong or they had a good reason to avoid setting required properties likeimage: ...
? It looks right tho?We could override
fdf4fc6737/pkg/upstream/stack/loader.go (L29-L36)
and give a better error message anyway.We could just re-use the logic from
abra recipe lint
to do our own validation 🤔Love it. Maybe we'd want to have
recipe lint
know the difference between a critical error like missingimage:
and a warning like use oflatest
tag?a84a5bc320
8735a8f0ea