toolshed/organising
7
1
Fork 0
Code Issues 100 Pull Requests Releases Activity

abra catalogue generate silently drops uncommitted git changes #255

New Issue
Closed
opened 2021-11-22 11:48:53 +00:00 by 3wordchant · 1 comment
3wordchant commented 2021-11-22 11:48:53 +00:00
Owner
Copy Link

Steps to reproduce

  1. Make some changes in a recipe repo, don't commit them
  2. Run abra catalogue generate <recipe>

Describe the expected behavior

Abra either bails out, or uses the uncommitted changes.

Describe the current behavior

Uncommitted git changes are dropped, effectively a git checkout / git reset --hard

Any idea how this might be fixed?

Similar approach to fixing it for app deploy?

Additional information

fdf4fc6

## Steps to reproduce 1. Make some changes in a recipe repo, don't commit them 2. Run `abra catalogue generate <recipe>` ## Describe the expected behavior Abra either bails out, or uses the uncommitted changes. ## Describe the current behavior Uncommitted git changes are dropped, effectively a `git checkout` / `git reset --hard` ## Any idea how this might be fixed? Similar approach to fixing it for `app deploy`? ## Additional information <!-- run "abra -v" on the command-line --> `fdf4fc6`
3wordchant added the
bug
abra
 labels 2021-11-22 11:48:53 +00:00
decentral1se commented 2021-11-22 16:51:49 +00:00
Owner
Copy Link

Hopefully covered now! See bonus bug fix in dbf84b7640 and the actual fix in a18729bf98.

Hopefully covered now! See bonus bug fix in https://git.coopcloud.tech/coop-cloud/abra/commit/dbf84b7640b5b823e3ea5462b98837f760e18fcc and the actual fix in https://git.coopcloud.tech/coop-cloud/abra/commit/a18729bf98a8a9b610cfa16c9360c73d4d7dd934.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#255
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?