toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

abra catalogue generate chokes on non-DockerHub-hosted images #258

New Issue
Closed
opened 2021-11-23 12:54:19 +00:00 by 3wordchant · 3 comments
3wordchant commented 2021-11-23 12:54:19 +00:00
Owner
Copy Link

Steps to reproduce

abra catalogue generate hedgedoc

(Where Hedgedoc's image is quay.io/hedgedoc/hedgedoc)

Describe the expected behavior

Looks up image tag info from quay.io

Describe the current behavior

Tries to look up the info from https://index.docker.io/v2/hedgedoc/hedgedoc/manifests/1.8.2, duly fails:

FATA[0012] unexpected end of JSON input                  caller="/home/user/Projects/Autonomic/CoopCloud/abra/cli/catalogue/generate.go:176 glob..func1" stack="/home/user/Projects/Autonomic/CoopCloud/abra/cli/catalogue/generate.go:176 glob..func1\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:163      (*Command).Run\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434          (*App).RunAsSubcommand\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278      (*Command).startApp\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94       (*Command).Run\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313          (*App).RunContext\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224          RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cli/cli.go:107                RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cmd/abra/main.go:23           main\n/usr/lib/golang/src/runtime/proc.go:225                                 main\n/usr/lib/golang/src/runtime/asm_amd64.s:1371                            goexit"

Any idea how this might be fixed?

A huge bag of hacks in abra/pkg/client/registry.go?

Additional information

dd0f328

## Steps to reproduce `abra catalogue generate hedgedoc` (Where Hedgedoc's image is `quay.io/hedgedoc/hedgedoc`) ## Describe the expected behavior Looks up image tag info from `quay.io` ## Describe the current behavior Tries to look up the info from `https://index.docker.io/v2/hedgedoc/hedgedoc/manifests/1.8.2`, duly fails: ``` FATA[0012] unexpected end of JSON input caller="/home/user/Projects/Autonomic/CoopCloud/abra/cli/catalogue/generate.go:176 glob..func1" stack="/home/user/Projects/Autonomic/CoopCloud/abra/cli/catalogue/generate.go:176 glob..func1\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:163 (*Command).Run\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434 (*App).RunAsSubcommand\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278 (*Command).startApp\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94 (*Command).Run\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313 (*App).RunContext\n/home/user/.go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224 RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cli/cli.go:107 RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cmd/abra/main.go:23 main\n/usr/lib/golang/src/runtime/proc.go:225 main\n/usr/lib/golang/src/runtime/asm_amd64.s:1371 goexit" ``` ## Any idea how this might be fixed? A huge bag of hacks in `abra/pkg/client/registry.go`? ## Additional information <!-- run "abra -v" on the command-line --> `dd0f328`
3wordchant added the
bug
abra
 labels 2021-11-23 12:54:19 +00:00
decentral1se commented 2021-11-23 13:51:55 +00:00
Owner
Copy Link

Hmmm right. Happy to see that skopeo does provide quay support (which is where I based my docker hub support logic from) so I think it just requires some digging in https://github.com/containers/skopeo for the right URLs to do the token dance. We might need to do some inspection to figure out which registry we need to ask? Not sure but this will need some investigation.

Hmmm right. Happy to see that skopeo does provide quay support (which is where I based my docker hub support logic from) so I think it just requires some digging in https://github.com/containers/skopeo for the right URLs to do the token dance. We might need to do some inspection to figure out which registry we need to ask? Not sure but this will need some investigation.
decentral1se commented 2022-02-08 11:35:42 +00:00
Owner
Copy Link

Additional report in coop-cloud/organising#296. We might want to figure out how to handle this sometime soon. These recipes can still be loaded into the catalogue by hand but that is not ideal.

Additional report in https://git.coopcloud.tech/coop-cloud/organising/issues/296. We might want to figure out how to handle this sometime soon. These recipes can still be loaded into the catalogue by hand but that is not ideal.
decentral1se added this to the Beta release (software) project 2022-02-20 17:08:54 +00:00
decentral1se commented 2022-02-21 08:50:40 +00:00
Owner
Copy Link

Happy to say I think this issue is squashed with coop-cloud/abra#159 on latest HEAD. I've been doing some testing, hopefully it will stand up to other user cases. Lemme know ✌️

Happy to say I think this issue is squashed with https://git.coopcloud.tech/coop-cloud/abra/pulls/159 on latest HEAD. I've been doing some testing, hopefully it will stand up to other user cases. Lemme know :v:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Beta release (software)
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#258
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?