abra autocomplete fish downloads zsh files instead #261

New Issue

cas · 2021-11-23T22:39:23Z

cas commented

2021-11-23 22:39:23 +00:00

Describe the current behavior

abra autocomplete fish gets zsh configuration files

Steps to reproduce

abra autocomplete fish

Describe the expected behavior

If fish is claimed to be supported, it should install fish configurations; if fish is not intended to be supported it should not list it as a possibility.

Any idea how this might be fixed?

Additional information

abra version 0.3.1-alpha-rc2-a7ebcd8

## Describe the current behavior `abra autocomplete fish` gets zsh configuration files ## Steps to reproduce `abra autocomplete fish` ## Describe the expected behavior If fish is claimed to be supported, it should install fish configurations; if fish is not intended to be supported it should not list it as a possibility. ## Any idea how this might be fixed? ## Additional information  `abra version 0.3.1-alpha-rc2-a7ebcd8`

cas added the

bug

abra

labels 2021-11-23 22:39:23 +00:00

knoflook added the

wontfix

label 2021-11-24 10:20:11 +00:00

knoflook commented

2021-11-24 10:20:21 +00:00

fish autocompletion is not supported (and probably won't be unfortunately), because the library that abra is built around doesn't support it, as can be seen here: https://github.com/urfave/cli/blob/master/docs/v2/manual.md#bash-completion
The docs (https://docs.coopcloud.tech/abra/) mention fizsh, which is a front-end to zsh: https://github.com/zsh-users/fizsh. If there's a mention of fish completion somewhere else please let me know and I'll remove it! Sorry for confusion :)

fish autocompletion is not supported (and probably won't be unfortunately), because the library that abra is built around doesn't support it, as can be seen here: https://github.com/urfave/cli/blob/master/docs/v2/manual.md#bash-completion The docs (https://docs.coopcloud.tech/abra/) mention fizsh, which is a front-end to zsh: https://github.com/zsh-users/fizsh. If there's a mention of fish completion somewhere else please let me know and I'll remove it! Sorry for confusion :)

3wordchant commented

2021-11-24 10:58:23 +00:00

If there's a mention of fish completion somewhere else please let me know and I'll remove it!

➜ abra autocomplete
NAME:
   abra autocomplete - Help set up shell autocompletion

   ...
   Supported shells are as follows:
   
       fish
       zsh
       bash

> If there's a mention of fish completion somewhere else please let me know and I'll remove it! ``` ➜ abra autocomplete NAME: abra autocomplete - Help set up shell autocompletion ... Supported shells are as follows: fish zsh bash ```

👍 1

knoflook referenced this issue from coop-cloud/abra

2021-11-24 11:12:28 +00:00

fix: remove fish from autocomplete #138

knoflook closed this issue

2021-11-24 11:13:00 +00:00

Sign in to join this conversation.