ParseSecrets incorrectly matching secrets on deploy ("secret not found") #297

New Issue

decentral1se · 2022-02-09T17:35:24Z

decentral1se commented

2022-02-09 17:35:24 +00:00

Describe the current behavior

➜  abra (main) ✗ ./abra app deploy -f -C -n <outline-instance>
...
FATA[0001] service app: secret not found: my_outline_instance_secret_key_v1  # length=32

I realised that it is length=64 in the .env.sample of the outline recipe and that there is a bug in ParseSecrets that is doing matching on secret # foo instead of secret.

Steps to reproduce

Set length=555555 (anything that doesn't match the .env.sample).

./abra app deploy -f -C -n <outline-instance>

Describe the expected behavior

We parse stuff correctly.

Any idea how this might be fixed?

It's kind of unclear, I think I need to abstrat the secret parsing logic out of pkg/secret/... so it can be shared in upstream/.... It's a bit scary because I'm not sure what this will break.

## Describe the current behavior ``` ➜ abra (main) ✗ ./abra app deploy -f -C -n <outline-instance> ... FATA[0001] service app: secret not found: my_outline_instance_secret_key_v1 # length=32 ``` I realised that it is `length=64` in the `.env.sample` of the outline recipe and that there is a bug in `ParseSecrets` that is doing matching on `secret # foo` instead of `secret`. ## Steps to reproduce Set `length=555555` (anything that doesn't match the `.env.sample`). ``` ./abra app deploy -f -C -n <outline-instance> ``` ## Describe the expected behavior We parse stuff correctly. ## Any idea how this might be fixed? It's kind of unclear, I think I need to abstrat the secret parsing logic out of `pkg/secret/...` so it can be shared in `upstream/...`. It's a bit scary because I'm not sure what this will break.

decentral1se added the

bug

abra

labels 2022-02-09 17:35:24 +00:00

decentral1se added this to the Beta release (software) project 2022-02-09 17:35:25 +00:00

decentral1se commented

2022-02-09 17:43:37 +00:00

Work around is just set your length=... to what is set in the recipe .env.sample OR simply delete the length specifier. This has helped me re-deploy existing recipes. I haven't tested from scratch in a while but I will.

Work around is just set your `length=...` to what is set in the recipe `.env.sample` OR simply delete the length specifier. This has helped me re-deploy existing recipes. I haven't tested from scratch in a while but I will.

decentral1se removed this from the Beta release (software) project 2022-02-14 17:10:58 +00:00

decentral1se added this to the Beta release (software) project 2022-03-11 09:12:23 +00:00

decentral1se referenced this issue from a commit

2022-03-11 15:40:53 +00:00

fix: strip length modifiers

decentral1se closed this issue

2022-03-12 08:43:18 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/organising#297