app ps, app volume rm and possibly other commands match too many apps #305

New Issue

knoflook · 2022-03-25T16:07:54Z

knoflook commented

2022-03-25 16:07:54 +00:00

traefik -> traefik.test.domain.com
capsul -> test.domain.com

abra app ps test.domain.com returns containers from traefik and capsul, same with abra app volume rm test.domain.com

traefik -> traefik.test.domain.com capsul -> test.domain.com `abra app ps test.domain.com` returns containers from traefik and capsul, same with `abra app volume rm test.domain.com`

knoflook added the

bug

abra

labels 2022-03-25 16:07:54 +00:00

decentral1se commented

2022-03-25 20:11:45 +00:00

Thanks for raising, I forgot to creat this ticket myself after fixing #300 and then forgot. I believe we need to re-work how the filtering is done, it doesn't exclude the sub-string cases. Need to look into all these uses:

➜  abra (main) ✔ grep -iR "filters.Add"       
pkg/upstream/stack/stack.go:	filters.Add("label", label)
pkg/upstream/stack/stack.go:	filters.Add("name", fmt.Sprintf("%s_%s", stackName, serviceName))
cli/app/secret.go:		filters.Add("name", app.StackName())
cli/app/secret.go:		filters.Add("name", app.StackName())
cli/app/logs.go:	filters.Add("name", stackName)
cli/app/logs.go:	filters.Add("name", fmt.Sprintf("%s_%s", app.StackName(), serviceName))
cli/app/run.go:		filters.Add("name", stackAndServiceName)
cli/app/ps.go:	filters.Add("name", app.StackName())
cli/app/errors.go:		filters.Add("name", service.Name)
cli/app/cp.go:	filters.Add("name", fmt.Sprintf("%s_%s", app.StackName(), service))

Adding a ^ or some sort of end stop for the matching might work. Or we might need to load in the service names explicitly of the recipe and then do filters.Add with the exact match. That might be safer.

Thanks for raising, I forgot to creat this ticket myself after fixing https://git.coopcloud.tech/coop-cloud/organising/issues/300 and then forgot. I believe we need to re-work how the filtering is done, it doesn't exclude the sub-string cases. Need to look into all these uses: ``` ➜ abra (main) ✔ grep -iR "filters.Add" pkg/upstream/stack/stack.go: filters.Add("label", label) pkg/upstream/stack/stack.go: filters.Add("name", fmt.Sprintf("%s_%s", stackName, serviceName)) cli/app/secret.go: filters.Add("name", app.StackName()) cli/app/secret.go: filters.Add("name", app.StackName()) cli/app/logs.go: filters.Add("name", stackName) cli/app/logs.go: filters.Add("name", fmt.Sprintf("%s_%s", app.StackName(), serviceName)) cli/app/run.go: filters.Add("name", stackAndServiceName) cli/app/ps.go: filters.Add("name", app.StackName()) cli/app/errors.go: filters.Add("name", service.Name) cli/app/cp.go: filters.Add("name", fmt.Sprintf("%s_%s", app.StackName(), service)) ``` Adding a `^` or some sort of end stop for the matching might work. Or we might need to load in the service names explicitly of the recipe and then do `filters.Add` with the exact match. That might be safer.

decentral1se added this to the Beta release (software) project 2022-03-26 14:24:07 +00:00

decentral1se referenced this issue from a commit

2022-03-27 10:40:32 +00:00

fix: more precise filtering

decentral1se closed this issue

2022-03-27 10:40:32 +00:00

decentral1se referenced this issue from coop-cloud/abra

2022-03-27 10:40:56 +00:00

fix: more precise filtering #169

decentral1se commented

2022-03-27 10:41:39 +00:00

Idk why this was closed 🤔