abra app upgrade: show a diff of new .env.sample and the servers .env #337
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#337
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When adding new env variables there's atm no way to ensure they get into operators
servers/.env
except of release notes.Maybe a simple way could be showing a diff of the to be upgraded
.env.sample
andservers/.env
?Or even more sophisticated parse the .envs and add new stuff automagically and just inform about it?
@yksflip
Oh nice, do you mean in the
abra app upgrade ...
flow? So, like, diffing the current tag and last tag of the recipe.env.sample
? That does assume those are maintained by the recipe maintainer which is til now something implicit. We could try to formalise that.abra app check ...
does try to do this afair. Maybe we could add a message to the upgrade flow to say "do run that to be sure"? Idk about adding an automatic check which might fail the upgrade flow? What if the recipe maintainer just made a mistake and then the operator is blocked?Another idea is to add this check to deploy with a
--no-env-checks
? That would be makingdeploy
more strict... but would follow the logic of domain and git changes checking... unsure...Hmmmm I think I'd be uncomfortable with auto-appending values into operators
.env
configs. I could image we'd be breaking peoples shit if they were moving fast and didn't read the message telling them we auto-updated their stuff?Let's converge on #446