Don't reset branches when creating new apps #408

New Issue

codegod100 · 2023-02-12T15:27:02Z

codegod100 commented

2023-02-12 15:27:02 +00:00

Currently when working on test code, abra will automagically switch branches to master which is less than ideal for testing scenarios.

codegod100 added the

enhancement

label 2023-02-12 15:27:02 +00:00

decentral1se commented

2023-02-12 15:33:50 +00:00

@codegod100 do you mean when you run deploy on your testing recipe or? Or you mean, your code is on a test branch and you run --chaos and it switches to master anyway? app new just makes the new ~/.abra/servers/$server/$app directory but doesn't related to how abra deals with Git after. So yeh, more info on the workflow would be great, thanks!

@codegod100 do you mean when you run `deploy` on your testing recipe or? Or you mean, your code is on a test branch and you run `--chaos` and it switches to master anyway? `app new` just makes the new `~/.abra/servers/$server/$app` directory but doesn't related to how `abra` deals with Git after. So yeh, more info on the workflow would be great, thanks!

codegod100 commented

2023-02-12 15:35:35 +00:00

![image](/attachments/c04d2307-a3d0-4aea-bf0b-e0c9f345730f)

image.png

57 KiB

codegod100 commented

2023-02-12 15:36:13 +00:00

This implies that abra binary does in fact affect my git branch

decentral1se commented

2023-02-12 15:44:49 +00:00

Ah yes, I see. Thanks!

abra does to some internal "gitops" style stuff to try and help produce stable deployments, e.g. switching to git tags, checking there are no unstaged changes, etc. We don't really use several branches for hacking on recipes ourselves, so never really ran into this.

So, I guess abra app new --chaos flag is the way forward then!

Ah yes, I see. Thanks! `abra` does to some internal "gitops" style stuff to try and help produce stable deployments, e.g. switching to git tags, checking there are no unstaged changes, etc. We don't really use several branches for hacking on recipes ourselves, so never really ran into this. So, I guess `abra app new --chaos` flag is the way forward then!

decentral1se commented

2023-02-12 16:00:05 +00:00

Alternatively, maybe we shouldn't even touch the recipe code when instantiating a new app? At this point, it doesn't make sense since we only create a directory and copy over the latest env sample? It's only later when we deal with deployments that we should attempt to ensure stable gitops 🤔

codegod100 commented

2023-02-12 16:05:03 +00:00

This would actually be my preference. I only suggested the flag because someone in the matrix said that might be useful to request, but yeah, please leave my git alone 😇

👍 1

decentral1se changed title from ~~--chaos flag needed for `abra app new`~~ to Don't reset branches when creating new apps

2023-02-14 06:56:56 +00:00

decentral1se added the

abra

label 2023-02-14 07:22:53 +00:00

decentral1se referenced this issue from a commit

2023-02-14 23:50:52 +00:00

fix: no gitops on recipe for "app new"

decentral1se closed this issue

2023-02-14 23:50:53 +00:00

Sign in to join this conversation.