Consider dropping logrus in favour of slog #422

New Issue

decentral1se · 2023-02-22T14:39:05Z

decentral1se commented

2023-02-22 14:39:05 +00:00

Reading logs from abra is a huge part of figuring out what it does and having some of the better defaults of charmbracelet/log (colours, timestamps) might be a big usability win.

Right now, the logging just calls logrus everywhere but we could centralise that to a package and then switching out loggers would be easier. This would be advisable going forward anyway.

https://github.com/charmbracelet/log

Reading logs from `abra` is a huge part of figuring out what it does and having some of the better defaults of `charmbracelet/log` (colours, timestamps) might be a big usability win. Right now, the logging just calls `logrus` everywhere but we could centralise that to a package and then switching out loggers would be easier. This would be advisable going forward anyway. > https://github.com/charmbracelet/log

👍 1

decentral1se added the

enhancement

label 2023-02-22 14:39:05 +00:00

decentral1se commented

2023-04-10 21:28:44 +00:00

They're finally adding log levels to the stdlib so maybe this could also be a thing to migrate to? See https://github.com/golang/go/issues/56345 for more. Some colour wrapping around that might do the trick. It'd be nice to be able to drop a dependency for this.

👀 1

decentral1se commented

2023-09-20 11:45:23 +00:00

We can drop a dependency now if we move to stdlib slog!

https://go.dev/blog/slog

Would be nice.

We can drop a dependency now if we move to stdlib `slog`! https://go.dev/blog/slog Would be nice.

decentral1se changed title from ~~Consider improved logging with charmbracelet/log~~ to Consider dropping logrus in favour of slog

2023-09-20 12:22:03 +00:00

decentral1se added the

abra

label 2023-09-20 12:22:09 +00:00