Consider dropping logrus in favour of slog #422

Open
opened 2023-02-22 14:39:05 +00:00 by decentral1se · 2 comments
Owner

Reading logs from abra is a huge part of figuring out what it does and having some of the better defaults of charmbracelet/log (colours, timestamps) might be a big usability win.

Right now, the logging just calls logrus everywhere but we could centralise that to a package and then switching out loggers would be easier. This would be advisable going forward anyway.

https://github.com/charmbracelet/log

Reading logs from `abra` is a huge part of figuring out what it does and having some of the better defaults of `charmbracelet/log` (colours, timestamps) might be a big usability win. Right now, the logging just calls `logrus` everywhere but we could centralise that to a package and then switching out loggers would be easier. This would be advisable going forward anyway. > https://github.com/charmbracelet/log
decentral1se added the
enhancement
label 2023-02-22 14:39:05 +00:00
Author
Owner

They're finally adding log levels to the stdlib so maybe this could also be a thing to migrate to? See https://github.com/golang/go/issues/56345 for more. Some colour wrapping around that might do the trick. It'd be nice to be able to drop a dependency for this.

They're finally adding log levels to the stdlib so maybe this could also be a thing to migrate to? See https://github.com/golang/go/issues/56345 for more. Some colour wrapping around that might do the trick. It'd be nice to be able to drop a dependency for this.
Author
Owner

We can drop a dependency now if we move to stdlib slog!

https://go.dev/blog/slog

Would be nice.

We can drop a dependency now if we move to stdlib `slog`! https://go.dev/blog/slog Would be nice.
decentral1se changed title from Consider improved logging with charmbracelet/log to Consider dropping logrus in favour of slog 2023-09-20 12:22:03 +00:00
decentral1se added the
abra
label 2023-09-20 12:22:09 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/organising#422
No description provided.