Recipe release with "--publish" doesn't pull latest changes first #426

New Issue

decentral1se · 2023-02-27T18:35:21Z

decentral1se commented

2023-02-27 18:35:21 +00:00

Thought this was fixed 🤔

WARN[0000] discovered 3.2.0+v1.77.0 as currently synced recipe label
WARN[0000] previous git tags detected, assuming this is a new semver release
? current: 3.1.0+v1.76.0, new: 3.2.0+v1.77.0, correct? Yes
FATA[0004] failed to publish new release: non-fast-forward update: refs/heads/main

Thought this was fixed 🤔 ``` WARN[0000] discovered 3.2.0+v1.77.0 as currently synced recipe label WARN[0000] previous git tags detected, assuming this is a new semver release ? current: 3.1.0+v1.76.0, new: 3.2.0+v1.77.0, correct? Yes FATA[0004] failed to publish new release: non-fast-forward update: refs/heads/main ```

decentral1se added the

bug

label 2023-02-27 18:35:22 +00:00

decentral1se added this to the Critical fixes project 2023-05-08 09:44:47 +00:00

decentral1se added the

abra

label 2023-06-08 09:19:23 +00:00

decentral1se commented

2023-07-26 07:29:14 +00:00

I think this may be fixed with coop-cloud/abra#330 and the new offline support. Don't have time to test now but if anyone picks this up, the first step would be to try reproduce it. The issue was that the code was mistakenly bailing out early on network access but the code is there to pull in latest before doing anything.

I think this may be fixed with https://git.coopcloud.tech/coop-cloud/abra/pulls/330 and the new offline support. Don't have time to test now but if anyone picks this up, the first step would be to try reproduce it. The issue was that the code was mistakenly bailing out early on network access but the code is there to pull in latest before doing anything.

decentral1se self-assigned this 2023-09-20 11:47:51 +00:00

decentral1se commented

2023-09-20 12:03:52 +00:00

d5593b69e0/tests/integration/recipe_release.bats (L8-L25)

https://git.coopcloud.tech/coop-cloud/abra/src/commit/d5593b69e0bc6e9304dd4b4a9a7f2dae8ea68f8d/tests/integration/recipe_release.bats#L8-L25

decentral1se closed this issue

2023-09-20 12:03:58 +00:00

decentral1se commented

2023-09-21 08:40:21 +00:00

FTR this was an incorrect fix. My understanding is that the abra recipe upgrade should be responsible for making sure that the local recipe is up to date, all tags are synced and we're using the latest commit before making local changes to the recipe. If abra recipe release tries to do this, it will wipe changes. I've got tests to match this assumption now... hopefully avoid more regression circus:

bats -Tp tests/integration/recipe_* will run them. Not everything is tested but the basics are covered, I hope.

FTR this was an incorrect fix. My understanding is that the `abra recipe upgrade` should be responsible for making sure that the local recipe is up to date, all tags are synced and we're using the latest commit before making local changes to the recipe. If `abra recipe release` tries to do this, it will wipe changes. I've got tests to match this assumption now... hopefully avoid more regression circus: - https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/tests/integration/recipe_upgrade.bats - https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/tests/integration/recipe_sync.bats - https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/tests/integration/recipe_release.bats `bats -Tp tests/integration/recipe_*` will run them. Not everything is tested but the basics are covered, I hope.

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/organising#426