"abra app restore" reports sucess when no 'backupbot.restore: "true"' present #430

New Issue

decentral1se · 2023-03-05T10:03:05Z

decentral1se commented

2023-03-05 10:03:05 +00:00

Also, if there are no pre/post-hooks defined then the database usually isn't being re-imported! So, we should probably warn for that case on restore. Otherwise it's all just a bit confusing. It says it worked but it did nothing 😆

decentral1se added the

bug

label 2023-03-05 10:03:05 +00:00

decentral1se added this to the Critical fixes project 2023-05-08 09:45:55 +00:00

decentral1se added the

abra

label 2023-06-08 09:19:23 +00:00

decentral1se commented

2023-09-20 11:34:09 +00:00

@3wordchant looked into this, actually, if you run say:

touch /tmp/foo.txt
tar -cvf foo.tar.gz /tmp/foo.txt
abra app restore foo.com app foo.tar.gz

And there is no backup.restore=true, then abra will restore foo.txt to /tmp/ on the container. It will not run any defined pre-hook/post-hook defined labels (cus that code checks for backup.restore=true first).

This is confusing right now but I guess more convenient? You can arbitrarily restore *.tar.gz files to a container without first defining backup.restore=true on the recipe configuration.

Do we want to lock that down and error out if backup.restore=true is not found?

@3wordchant looked into this, actually, if you run say: ``` touch /tmp/foo.txt tar -cvf foo.tar.gz /tmp/foo.txt abra app restore foo.com app foo.tar.gz ``` And there is no `backup.restore=true`, then `abra` will restore `foo.txt` to `/tmp/` on the container. It will *not* run any defined `pre-hook/post-hook` defined labels (cus that code checks for `backup.restore=true` first). This is confusing right now but I guess more convenient? You can arbitrarily restore `*.tar.gz` files to a container without first defining `backup.restore=true` on the recipe configuration. Do we want to lock that down and error out if `backup.restore=true` is not found?

decentral1se self-assigned this 2023-09-20 11:47:34 +00:00

decentral1se removed this from the Critical fixes project 2023-09-23 22:27:55 +00:00

decentral1se removed their assignment 2023-09-23 22:28:05 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/organising#430