abra seems to ignore --no-domain-checks on abra app deploy
#495
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#495
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Sorry for the messy traceback. If nobody gets to it I'll take a look at this bug at some point and try to recreate. I've run into this a bunch.
@cas seems tested
906bf65d47/tests/integration/app_deploy.bats (L275-L298)
🤔 It is--no-domain-checks
, not--no-domain
? Altho I can confirm the CLI errors out if the wrong flag is passed, so I guess that wasn't it? Are you running latest release? The traceback points to a line in the file which has moved on since, so can't quite check that.Can confirm we were using
--no-domain-checks
. I'm on5ae73f7
, will try to reproduce with latest. The problem only seems to occur when there's an NXDOMAIN reply for the domain, if it resolves differently to the server then--no-domain-checks
works fineOh, this is maybe an issue (from the traceback)?
@cas @3wordchant
The
drone-docker-runner.dronehive.autonomic.zone.env
is misconfigured? Can you confirm?I think
abra
is doing a ipv4 compare ofdrone-docker-runner.example.com
anddronehive.autonomic.zone
and failing then becausedrone-docker-runner.example.com
does not exist?I could try add a linting rule to check that the root of
DOMAIN=...
matches the root of the server domain? I hope Go stdlib has something for parsing domain names...That's coming from the
.env.sample
no?DOMAIN
seems like it was correctly picked up, from the confirmation prompt box thing.My impression of
--no-domain-checks
was that it shouldn't be checking addresses of anything, though!Ah right, yep!
Sorry, yeh, I'm confusing the situation. As I (thought) found a related issue (coop-cloud/abra#360) and threw it in the mix here 😅
So, I'm snsure why the flag would be ignored then 🤔 If any other ideas pop up, lemme know 🤓
abra seems to ignore --no-domain on `abra app deploy`to abra seems to ignore --no-domain-checks on `abra app deploy`I guess the "can reproduce" window for this has gone Very Far Away... please re-open if you run into it again! Unsure how to proceed otherwise...