abra recipe fetch can only fetch a single recipe #530

New Issue

wykwit · 2023-11-05T19:53:54Z

wykwit commented

2023-11-05 19:53:54 +00:00

description

The behaviour of recipe fetch command has changed in commit 0be532692d (with coop-cloud/abra#353) without changing the description to fit. The command can only fetch a single recipe, it doesn't retrieve all recipes anymore.

Current help message:

$ ./abra recipe help fetch
NAME:
   abra recipe fetch - Fetch recipe(s)

USAGE:
   abra recipe fetch [command options] [<recipe>]

DESCRIPTION:
   Retrieves all recipes if no <recipe> argument is passed

OPTIONS:
   --debug, -d     Show DEBUG messages
   --no-input, -n  Toggle non-interactive mode

steps to reproduce

execute abra recipe fetch without specifying a recipe

expected result

Per help message the expected result is to fetch all recipes similar to behaviour of abra catalogue generate. However, since the catalogue subcommand seems to cover that use-case well enough already, I would expect this subcommand to require specifying a recipe and displaying help message whenever it is not specified.

actual result

$ abra recipe fetch
FATA[0000] unable to open /home/user/.abra/recipes: repository does not exist

comments

The recipe subcommand should stay simple and deal with single recipes only.

The catalogue still seems to evolve and as more changes are made in the code around it, it would be beneficial to keep catalogue and recipe subcommands untangled. I would suggest to leave dealing with (multiple) repositories within the catalogue subcommand's duties and perhaps split off more subsubcommands from there later. This command then would require specifying recipes, and so the description would have to be updated accordingly.

## description The behaviour of `recipe fetch` command has changed in commit 0be532692d (with coop-cloud/abra#353) without changing the description to fit. The command can only fetch a single recipe, it doesn't retrieve all recipes anymore. Current help message: ``` $ ./abra recipe help fetch NAME: abra recipe fetch - Fetch recipe(s) USAGE: abra recipe fetch [command options] [<recipe>] DESCRIPTION: Retrieves all recipes if no <recipe> argument is passed OPTIONS: --debug, -d Show DEBUG messages --no-input, -n Toggle non-interactive mode ``` ## steps to reproduce - execute `abra recipe fetch` without specifying a recipe ### expected result Per help message the expected result is to fetch all recipes similar to behaviour of `abra catalogue generate`. However, since the `catalogue` subcommand seems to cover that use-case well enough already, I would expect this subcommand to require specifying a recipe and displaying help message whenever it is not specified. ### actual result ``` $ abra recipe fetch FATA[0000] unable to open /home/user/.abra/recipes: repository does not exist ``` ## comments The `recipe` subcommand should stay simple and deal with single recipes only. The catalogue still seems to evolve and as more changes are made in the code around it, it would be beneficial to keep `catalogue` and `recipe` subcommands untangled. I would suggest to leave dealing with (multiple) repositories within the `catalogue` subcommand's duties and perhaps split off more subsubcommands from there later. This command then would require specifying recipes, and so the description would have to be updated accordingly.

wykwit added the

bug

label 2023-11-05 19:53:54 +00:00

p4u1 referenced this issue from coop-cloud/abra

2024-01-08 14:11:17 +00:00

feat: fetch all recipes when no recipe is specified #401

p4u1 referenced this issue

2024-01-08 14:18:43 +00:00

Track Progress of Resolution 014: Budget 008: Critical Fixes - 2023-12-06 #547

decentral1se commented

2024-01-08 14:48:22 +00:00

My boiling hot take!

Let's get the functionality back, I think it was a bug from me in the arg handling...

A test wasn't written 🙃 one would be good...

My boiling hot take! ![image](/attachments/f80b2bd8-ba6f-44e7-85d1-ef9018b1dac6) Let's get the functionality back, I think it was a bug from me in the arg handling... A test wasn't written 🙃 one would be good...

image.png

33 KiB

p4u1 referenced this issue from a commit

2024-01-24 15:01:34 +00:00

feat: fetch all recipes when no recipe is specified (!401)

p4u1 closed this issue

2024-01-24 15:01:34 +00:00

p4u1 referenced this issue from a commit

2024-02-15 16:09:22 +00:00

feat: fetch all recipes when no recipe is specified (!401)

Sign in to join this conversation.