Replace "wait for deploy" logic with upstream --detach=false #607

New Issue

decentral1se · 2024-04-09T08:23:33Z

decentral1se commented

2024-04-09 08:23:33 +00:00

When you run docker stack deploy ... with the latest Docker CLI, you see:

Since --detach=false was not specified, tasks will be created in the background.
In a future release, --detach=false will become the default.

And we can see they've implememented this detach=... finally:

-d, --detach Exit immediately instead of waiting for the stack services to converge (default true)

So, we can finally remove my totally scotch-taped implementation with something that actually works 🎉

When you run `docker stack deploy ...` with the latest Docker CLI, you see: > Since --detach=false was not specified, tasks will be created in the background. > In a future release, --detach=false will become the default. And we can see they've implememented this `detach=...` finally: > -d, --detach Exit immediately instead of waiting for the stack services to converge (default true) So, we can finally remove my totally scotch-taped implementation with something that actually works 🎉

decentral1se added the

enhancement

abra

labels 2024-04-09 08:23:33 +00:00

decentral1se referenced this issue from a commit

2024-07-02 10:55:33 +00:00

refactor: use adapted upstream detach=false logic [ci skip]

decentral1se commented

2024-07-02 10:58:19 +00:00

Testing a spike on this in e88968a3b7 for the integration tests. The new integration test server is sold af but it revealed that the quick deploy/undeploy runs lead into endless "network not found errors" because the cleanup logic was not there. Now that upstream finally has this, I've incorporated it in. Tests ongoing... looking more solid tho!

Testing a spike on this in https://git.coopcloud.tech/coop-cloud/abra/commit/e88968a3b720306ceafca48c9e3dd20cee929558 for the integration tests. The new integration test server is sold af but it revealed that the quick deploy/undeploy runs lead into endless "network not found errors" because the cleanup logic was not there. Now that upstream finally has this, I've incorporated it in. Tests ongoing... looking more solid tho!

decentral1se referenced this issue from a commit

2024-07-02 12:57:07 +00:00

refactor: use adapted upstream detach=false logic [ci skip]

decentral1se referenced this issue from toolshed/abra

2024-07-02 13:37:34 +00:00

test: automated integration test suite #424

decentral1se commented

2024-07-02 15:23:41 +00:00

This has had a huge impact on stabilising abra app undeploy (i.e. waiting for network deletion) 🎉 For abra app deploy I'm seeing some improvement altho I'm unsure it has had as big an impact as undeploy.

This has had a huge impact on stabilising `abra app undeploy` (i.e. waiting for network deletion) 🎉 For `abra app deploy` I'm seeing some improvement altho I'm unsure it has had as big an impact as `undeploy`.

decentral1se closed this issue

2024-07-02 15:23:41 +00:00

decentral1se referenced this issue

2024-07-02 15:26:22 +00:00

`abra app upgrade` reports success even if app is still running old version of one service #615

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/organising#607