coop-cloud/parasol-static-site
2
2
Fork 0
Code Issues 6 Pull Requests 1 Packages Projects Releases Wiki Activity

custom deploy [ci skip] #7

Merged
stevensting merged 3 commits from custom-deploy into main 2025-02-07 17:29:19 +00:00
Conversation 2 Commits 3 Files Changed 3
+11
decentral1se commented 2024-04-02 20:57:38 +00:00
Owner
Copy Link
Copy Source

See #6

See https://git.coopcloud.tech/coop-cloud/parasol-static-site/issues/6
decentral1se added 1 commit 2024-04-02 20:57:39 +00:00
wip: custom deploy [ci skip] 6dfff1c535 
See #6
stevensting commented 2024-08-23 14:50:59 +00:00
Owner
Copy Link
Copy Source

highly appreciated if this would be merged. :)

highly appreciated if this would be merged. :)
stevensting commented 2024-09-06 14:50:28 +00:00
Owner
Copy Link
Copy Source

We just tested this branch in our environment. It does not 100% fulfill our needs, as we need the script being executed additionally and not as alternative. (We want to install npm modules) Therefore we removed the "exit 0". Maybe this is something which could be considered in this PR, otherwise we will create another PR for this use case.

Furthermore it is not clear to us what the expected behaviour should be in case the script is not found or returns with an error. We observed that the deploy.sh.tmpl loops when the custom script exits with non-zero value.

We just tested this branch in our environment. It does not 100% fulfill our needs, as we need the script being executed additionally and not as alternative. (We want to install npm modules) Therefore we removed the "exit 0". Maybe this is something which could be considered in this PR, otherwise we will create another PR for this use case. Furthermore it is not clear to us what the expected behaviour should be in case the script is not found or returns with an error. We observed that the deploy.sh.tmpl loops when the custom script exits with non-zero value.
👍 1
stevensting added 1 commit 2025-02-07 17:24:16 +00:00
remove exit 0 0a0db3ac63
stevensting added 1 commit 2025-02-07 17:26:33 +00:00
Merge remote-tracking branch 'origin/main' into custom-deploy 482ef7b2bf
stevensting marked the pull request as ready for review 2025-02-07 17:29:04 +00:00
stevensting merged commit 54624241bd into main 2025-02-07 17:29:19 +00:00
stevensting deleted branch custom-deploy 2025-02-07 17:29:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/parasol-static-site#7