Re-work entrypoint when/if we get bash (or make compatible with sh) #2

New Issue

decentral1se · 2021-05-06T11:38:54Z

decentral1se commented

2021-05-06 11:38:54 +00:00

a723573bf3/entrypoint.sh.tmpl is bash only but we only have sh on the container. So, we could raise an issue for that on peertube itself. Otherwise, we could make this file_env function sh compatible. For now, I'm just gonna make it really not smart and do it manually.

https://git.autonomic.zone/coop-cloud/peertube/src/commit/a723573bf39b93d7c9d9c3a0e2ffba78aaf8a648/entrypoint.sh.tmpl is `bash` only but we only have `sh` on the container. So, we could raise an issue for that on `peertube` itself. Otherwise, we could make this `file_env` function `sh` compatible. For now, I'm just gonna make it really not smart and do it manually.

decentral1se commented

2021-05-06 11:41:28 +00:00


In entrypoint.sh line 6:
   local var="$1"
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In entrypoint.sh line 7:
   local fileVar="${var}_FILE"
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In entrypoint.sh line 8:
   local def="${2:-}"
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In entrypoint.sh line 10:
   if [ "${!var:-}" ] && [ "${!fileVar:-}" ]; then
         ^-- SC2039: In POSIX sh, indirect expansion is undefined.
                            ^-- SC2039: In POSIX sh, indirect expansion is undefined.


In entrypoint.sh line 15:
   local val="$def"
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In entrypoint.sh line 17:
   if [ "${!var:-}" ]; then
         ^-- SC2039: In POSIX sh, indirect expansion is undefined.


In entrypoint.sh line 18:
      val="${!var}"
           ^-- SC2039: In POSIX sh, indirect expansion is undefined.


In entrypoint.sh line 19:
   elif [ "${!fileVar:-}" ]; then
           ^-- SC2039: In POSIX sh, indirect expansion is undefined.


In entrypoint.sh line 20:
      val="$(< "${!fileVar}")"
           ^-- SC2039: In POSIX sh, $(<file) to read files is undefined.
                ^-- SC2039: In POSIX sh, indirect expansion is undefined.

``` In entrypoint.sh line 6: local var="$1" ^-- SC2039: In POSIX sh, 'local' is undefined. In entrypoint.sh line 7: local fileVar="${var}_FILE" ^-- SC2039: In POSIX sh, 'local' is undefined. In entrypoint.sh line 8: local def="${2:-}" ^-- SC2039: In POSIX sh, 'local' is undefined. In entrypoint.sh line 10: if [ "${!var:-}" ] && [ "${!fileVar:-}" ]; then ^-- SC2039: In POSIX sh, indirect expansion is undefined. ^-- SC2039: In POSIX sh, indirect expansion is undefined. In entrypoint.sh line 15: local val="$def" ^-- SC2039: In POSIX sh, 'local' is undefined. In entrypoint.sh line 17: if [ "${!var:-}" ]; then ^-- SC2039: In POSIX sh, indirect expansion is undefined. In entrypoint.sh line 18: val="${!var}" ^-- SC2039: In POSIX sh, indirect expansion is undefined. In entrypoint.sh line 19: elif [ "${!fileVar:-}" ]; then ^-- SC2039: In POSIX sh, indirect expansion is undefined. In entrypoint.sh line 20: val="$(< "${!fileVar}")" ^-- SC2039: In POSIX sh, $(<file) to read files is undefined. ^-- SC2039: In POSIX sh, indirect expansion is undefined. ```

decentral1se referenced this issue from a commit

2021-05-06 11:47:05 +00:00

Use manual approach on entrypoint for now

decentral1se commented

2021-05-06 11:49:30 +00:00