Should the assets folder be a named volume? #8

New Issue

decentral1se · 2021-06-24T16:50:37Z

decentral1se commented

2021-06-24 16:50:37 +00:00

When an upgrade is ran, they are not updated but they should be?

https://github.com/Chocobozzz/PeerTube/issues/3546

I had to manually remove the existing volume and redeploy for the ruangrupa instance.

When an upgrade is ran, they are not updated but they should be? > https://github.com/Chocobozzz/PeerTube/issues/3546 I had to manually remove the existing volume and redeploy for the ruangrupa instance.

mirsal commented

2021-07-15 15:06:09 +00:00

Those files are served directly by nginx so they need to be in a named volume in order to be reachable.

What we could do instead as a workaround is use the nginx proxy-cache and forward the misses to the nodejs container... It would be much better to have the peertube container copy them over during startup though. Maybe the way to go is to do that ourselves in the entrypoint script (which we are already overriding)

Those files are served directly by nginx so they need to be in a named volume in order to be reachable. What we could do instead as a workaround is use the nginx proxy-cache and forward the misses to the nodejs container... It would be much better to have the peertube container copy them over during startup though. Maybe the way to go is to do that ourselves in the entrypoint script (which we are already overriding)

decentral1se commented

2021-07-15 19:08:25 +00:00

Nice! Thanks for explaining that. Yes, the entrypoint hook to copy stuff would be great.

mirsal referenced this issue from a commit

2021-07-16 21:07:47 +00:00

fix: Copy the client assets over to a named volume at runtime

mirsal referenced a pull request that will close this issue

2021-07-16 21:11:16 +00:00

Copy the client assets over to a named volume at runtime #10

mirsal referenced this issue from a commit

2021-07-16 21:19:13 +00:00

fix: Copy the client assets over to a named volume at runtime