Review pls #1

New Issue

fauno · 2024-10-11T18:55:52Z

fauno commented

2024-10-11 18:55:52 +00:00

:³

3wordchant was assigned by fauno

2024-10-11 18:55:53 +00:00

3wordchant commented

2024-10-25 03:41:03 +00:00

Looks fantastic, thanks so much! 👏

Some comments:

The version number in the label should follow how other recipes are versioned. If you delete that line and run abra recipe sync rest-server it should prompt for whether to start with 0.1.0 or 1.0.0 for the recipe version, and then show the label to add. Or you can edit the 1 to either of those, then before committing run abra recipe release rest-server.
For Synapse we called it matrix-synapse to be more recognisable, do you think restic-rest-server would help people at all?

I can make either or both of these changes if you agree but you don't have time / interest.

Looks fantastic, thanks so much! 👏 Some comments: 1. The [version number in the label](https://git.coopcloud.tech/coop-cloud/rest-server/src/branch/main/compose.yml#L29) should follow [how other recipes are versioned](https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned). If you delete that line and run `abra recipe sync rest-server` it should prompt for whether to start with `0.1.0` or `1.0.0` for the recipe version, and then show the label to add. Or you can edit the `1` to either of those, then before committing run `abra recipe release rest-server`. 2. For Synapse we called it `matrix-synapse` to be more recognisable, do you think `restic-rest-server` would help people at all? I can make either or both of these changes if you agree but you don't have time / interest.

❤️ 1

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/restic-rest-server#1