plain text admin_token is considered insecure #5
Closed
opened 2025-03-28 19:38:24 +00:00 by fauno
·
5 comments
No Branch/Tag Specified
main
renovate/mariadb-13.x
fix_smtp
2.2.0
sso
v1.35
smtp-not-enabled-by-default
issue-6
2.5.0+1.37.4
2.4.0+1.37.3
2.3.3+1.37.2
2.3.2+1.37.2
2.3.1+1.37.1
2.3.0+1.37.0
2.2.0+1.36.0
2.1.3+1.35.4
2.1.2+1.35.3
2.1.1+1.34.3
2.1.0+1.34.1
2.0.0+1.33.2
1.1.0+1.33.2
1.0.4+1.32.7
1.0.3+1.32.5
1.0.2+1.32.5
1.0.1+1.32.5
1.0.0+1.32.3
0.9.1+1.32.3
0.9.0+1.32.0
0.8.0+1.31.0
0.7.2+1.30.3
0.7.1+1.30.1
0.7.0+1.30.0
0.6.0+1.29.2
0.5.1+1.29.1
0.5.0+1.29.0
0.4.0+1.28.1
0.3.0+1.26.0
0.2.0+1.26.0
0.1.1+1.26.0
0.1.0+1.25.0
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
Apfelwurm
appletalk
arjan
basebuilder
BornDeleuze (Born Deleuze)
Brooke
carla
cas (Cassowary)
codegod100
coopcloud
cyrnel
dannygroenewegen (Danny Groenewegen)
decentral1se (d1)
dede
devydave
fauno (fauno)
flancian
Frando
hex (Josh Dukes)
iexos
jade (Jade Ambrose)
javielico (Javielico)
jjsfunhouse
jmakdah2 (Jackie Makdah)
joe-irving (Joe Irving)
kawaiipunk (KawaiiPunk)
knoflook
kolaente
lambdabundesverband
linnealovespie (April)
marlon (marlon)
mayel
mirsal
moosemower
moritz
nicksellen (Nick Sellen)
notplants
oxaliq (sorrel)
p4u1 (p4u1)
pau
pharaohgraphy (Andrew 🐦🔥❤️🔥✴️)
PhiNatalie
renovate-bot (Comrade Renovate Bot)
ripclap
rix
rscmbbng
sef (sef)
simon
sixsmith (Sixsmith)
stevensting (stevensting)
tobias
trav (Trav Fryer)
val (val (he/him))
vaznasty
virtualboys
wolcen (Chris Thompson)
wykwit
xynosis
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/vaultwarden#5
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
https://github.com/dani-garcia/vaultwarden/wiki/Enabling-admin-page#secure-the-admin_token
I didn't have time to check but I assume the migration step is to:
hashcommand (?)We could add this as documentation in the
README.md.you can also do it from the admin web ui, that's what i did finally. the secret should be hashed anyway, so the issue is with autogenerated secrets (unless abra can be told to hash secrets! a wild feature request appears!)
The logic is there but I'm not sure adding the dependency just for this specific use case is really worth it? Are there other apps that require it? If you fee like we should go for it, feel free to open an issue for
abra.I guess just docs in the
README.mdto close this one then here.@fauno the readme already points out this as a step
maybe we can close the issue for now until abra supports doing that using
app secret generate?i'm never sure in which context abra.sh commands run :P