Deployment fails due to missing secret #2

New Issue

2022-05-19T21:25:48Z

aadil commented

2022-05-19 21:25:48 +00:00

abra app deploy pocket.aadils.computer
WARN[0007] no versions detected, using latest commit    
WARN[0007] no published release discovered for wallabag 
+-----------------+----------+-------------+------------------------+----------+
|     SERVER      |  RECIPE  |   CONFIG    |         DOMAIN         | VERSION  |
+-----------------+----------+-------------+------------------------+----------+
| aadils.computer | wallabag | compose.yml | pocket.aadils.computer | 3da361aa |
+-----------------+----------+-------------+------------------------+----------+
? continue with deployment? Yes
INFO[0010] Creating network pocket_aadils_computer_internal 
FATA[0010] service app: secret not found: pocket_aadils_computer_db_password_v1

may be related to #1?

```sh abra app deploy pocket.aadils.computer WARN[0007] no versions detected, using latest commit WARN[0007] no published release discovered for wallabag +-----------------+----------+-------------+------------------------+----------+ | SERVER | RECIPE | CONFIG | DOMAIN | VERSION | +-----------------+----------+-------------+------------------------+----------+ | aadils.computer | wallabag | compose.yml | pocket.aadils.computer | 3da361aa | +-----------------+----------+-------------+------------------------+----------+ ? continue with deployment? Yes INFO[0010] Creating network pocket_aadils_computer_internal FATA[0010] service app: secret not found: pocket_aadils_computer_db_password_v1 ``` may be related to #1?

decentral1se commented

2022-05-20 07:02:05 +00:00

Ah, I think #1 is something else but realllly looks like it is the cause 🙃 It is related tho (we'll come back to this). To start fixing this, you need to change the following (

		wallabag/.env.sample
		Lines 8 to 9 in 3da361aa2e
	
				DB_PASSWORD_VERSION=v1

				DB_ROOT_PASSWORD_VERSION=v1

):

DB_PASSWORD_VERSION=v1
DB_ROOT_PASSWORD_VERSION=v1

To:

SECRET_DB_PASSWORD_VERSION=v1
SECRET_DB_ROOT_PASSWORD_VERSION=v1

Because abra looks for SECRET_... env vars for versioning secrets.

Don't forget to abra app secret generate ...

If you're feeling generous you could fix this in upstream and push a fix to https://git.coopcloud.tech/coop-cloud/wallabag/src/branch/main/.env.sample to add the SECRET_... prefixes 🙏

Now, back to #1, you'll notice this comment in

		wallabag/compose.yml
		Lines 13 to 15 in 3da361aa2e
	
				      # FIXME: use Docker secrets, see

				      # https://github.com/wallabag/docker/issues/186

				      - SYMFONY__ENV__DATABASE_PASSWORD=$DB_PASSWORD

which is saying "you need to put DB_PASSWORD=...in your.envto setup the password for wallabag. This is bad because your password is in plain text in a.env` file but the upstream image doesn't support anything better right now.

Let me know if anything is unclear!

Ah, I think #1 is something else but realllly looks like it is the cause 🙃 It is related tho (we'll come back to this). To start fixing this, you need to change the following (https://git.coopcloud.tech/coop-cloud/wallabag/src/commit/3da361aa2e828636deaa32aeafec1b1598be959a/.env.sample#L8-L9): ``` DB_PASSWORD_VERSION=v1 DB_ROOT_PASSWORD_VERSION=v1 ``` To: ``` SECRET_DB_PASSWORD_VERSION=v1 SECRET_DB_ROOT_PASSWORD_VERSION=v1 ``` Because `abra` looks for `SECRET_...` env vars for versioning secrets. Don't forget to `abra app secret generate ...` If you're feeling generous you could fix this in upstream and push a fix to https://git.coopcloud.tech/coop-cloud/wallabag/src/branch/main/.env.sample to add the `SECRET_...` prefixes 🙏 Now, back to #1, you'll notice this comment in https://git.coopcloud.tech/coop-cloud/wallabag/src/commit/3da361aa2e828636deaa32aeafec1b1598be959a/compose.yml#L13-L15 which is saying "you need to put DB_PASSWORD=...` in your `.env` to setup the password for wallabag. This is bad because your password is in plain text in a `.env` file but the upstream image doesn't support anything better right now. Let me know if anything is unclear!

aadil referenced this issue from a commit

2022-06-14 10:16:44 +00:00

Add "SECRET_" prefix to DB env vars

aadil closed this issue

2022-06-14 10:16:44 +00:00

aadil reopened this issue

2022-06-14 10:23:29 +00:00

aadil commented

2022-06-14 10:24:42 +00:00