glyph

glyph commented on pull request PeachCloud/peach-workspace#15

2021-11-05 09:52:16 +00:00

This is going to panic and crash the server if is_dns_updater_online returns an error. We should rather match on the Result and return an appropriate JSON Value if there's an error.

glyph commented on pull request PeachCloud/peach-workspace#15

2021-11-05 09:52:16 +00:00

Upgrade peach-web to use rocket 0.5

Was this commented-out line left in by mistake?

glyph commented on pull request PeachCloud/peach-workspace#15

2021-11-05 09:52:16 +00:00

Upgrade peach-web to use rocket 0.5

We can remove handlerbars here, since we're only using the tera templating engine.

glyph suggested changes for PeachCloud/peach-workspace#15

2021-11-05 09:52:16 +00:00

Upgrade peach-web to use rocket 0.5

Looks good overall; nice work! I've left some specific comments in the review for things which need to be address.

glyph pushed to sbot_object at PeachCloud/go-sbotcli-rs

2021-11-05 09:01:59 +00:00

f4a74143e5 error module doc comment

glyph created pull request PeachCloud/go-sbotcli-rs#2

2021-11-04 15:03:19 +00:00

Refactor to use an object-oriented pattern for Sbot

glyph pushed to sbot_object at PeachCloud/go-sbotcli-rs

2021-11-04 14:58:35 +00:00

c2cff416d0 update code example

42a43189fc add no_home_dir error

c91506f0c9 add dirs dependency

1c7a3ec39c refactor to use Sbot object

Compare 4 commits »

glyph created branch sbot_object in PeachCloud/go-sbotcli-rs

2021-11-04 14:58:34 +00:00

glyph commented on issue PeachCloud/peach-workspace#14

2021-11-04 12:24:45 +00:00

Reason for use of RawStr in peach-web?

Ah yes, that seems to be the case. I see in FromForm provided implementations that &str is…

glyph commented on issue PeachCloud/go-sbotcli-rs#1

2021-11-04 12:19:39 +00:00

Allow setting sbotcli path using environment variable

PR to go-sbot to allow setting the working directory using a CLI flag (or env var)

+1 to this idea.

could also consider to do an object-oriented pattern

Good call! I had totally…

glyph commented on issue PeachCloud/peach-workspace#14

2021-11-04 12:11:51 +00:00

Reason for use of RawStr in peach-web?

@notplants

Hmm...that's a good question. I can't recall exactly why &RawStr is used for the ssid (I think there are three functions with that parameter pattern). If I had to guess, I'd say I…

glyph opened issue PeachCloud/go-sbotcli-rs#1

2021-11-03 14:01:56 +00:00

Allow setting sbotcli path using environment variable

glyph deleted branch initial_commit from PeachCloud/go-sbotcli-rs

2021-11-03 13:58:09 +00:00

glyph created branch main in PeachCloud/go-sbotcli-rs

2021-11-03 13:56:37 +00:00

glyph pushed to main at PeachCloud/go-sbotcli-rs

2021-11-03 13:56:37 +00:00

glyph pushed to initial_commit at PeachCloud/go-sbotcli-rs

2021-11-03 13:54:38 +00:00

97fc6cd3ff docs, errors and basic api

glyph created branch initial_commit in PeachCloud/go-sbotcli-rs

2021-11-03 13:54:37 +00:00

glyph created repository PeachCloud/go-sbotcli-rs

2021-11-03 13:53:57 +00:00

glyph approved PeachCloud/peach-workspace#12

2021-11-03 09:57:58 +00:00

Refactor routes into functional groupings

Looking good. I just made 3 commits to carry this a bit further forward:

glyph pushed to routes-refactor at PeachCloud/peach-workspace

2021-11-03 09:53:03 +00:00

090415d875 update main lockfile

b70e1c9c08 remove crate-level lockfiles

5df88b81ce documentation tidy-up

Compare 3 commits »