golgi-ssb/golgi
3
6
Fork 0
Code Issues 11 Pull Requests 1 Projects 1 Releases Wiki Activity

Getting votes on a particular post? #44

New Issue
Open
opened 2022-06-07 08:48:17 +00:00 by notplants · 9 comments
notplants commented 2022-06-07 08:48:17 +00:00
Owner
Copy Link
Copy Source

@erin asked about how to get votes for a post for their client (https://matrix.to/#/!SrcUDxvxhmyHlrHzgd:matrix.org/$jlkhaDPcOdrs3aPMWcCcghwgqWVcQy3FJS_Yzpwq0yo?via=matrix.org&via=chat.is-cute.ml)

I'm going to look into go-oasis to see if they handled this

@erin asked about how to get votes for a post for their client (https://matrix.to/#/!SrcUDxvxhmyHlrHzgd:matrix.org/$jlkhaDPcOdrs3aPMWcCcghwgqWVcQy3FJS_Yzpwq0yo?via=matrix.org&via=chat.is-cute.ml) I'm going to look into go-oasis to see if they handled this
👍 1
glyph commented 2022-06-09 07:28:59 +00:00
Owner
Copy Link
Copy Source

I'm intrigued to hear how / if go-oasis did this.

I'm intrigued to hear how / if go-oasis did this.
notplants commented 2022-06-09 15:14:55 +00:00
Author
Owner
Copy Link
Copy Source

I posted what I found in the #golgi matrix channel 

ok I've confirmed that in goasis (a fork of oasis that cryptix made which uses go-sbot as a backend) they use ssb.backlinks to get votes for a post
https://git.sr.ht/~cryptix/ssb-oasis/tree/master/item/src/models.js#L398

however, I'm not sure yet what backlinks is exactly, whether its filtering built in javascript that we need to remake in rust, or if there go-sbot calls that can help with that

I think it could be a good question to ask the planetary devs about as well

I posted what I found in the #golgi[ matrix channel ](https://matrix.to/#/!SrcUDxvxhmyHlrHzgd:matrix.org/$_oLPeNtc-KZS2g9kxAZZc8JdTarCXr4gearN6iBi8TI?via=matrix.org&via=chat.is-cute.ml) ``` ok I've confirmed that in goasis (a fork of oasis that cryptix made which uses go-sbot as a backend) they use ssb.backlinks to get votes for a post https://git.sr.ht/~cryptix/ssb-oasis/tree/master/item/src/models.js#L398 however, I'm not sure yet what backlinks is exactly, whether its filtering built in javascript that we need to remake in rust, or if there go-sbot calls that can help with that ``` I think it could be a good question to ask the planetary devs about as well
👀 1
glyph commented 2022-06-13 08:03:35 +00:00
Owner
Copy Link
Copy Source

@notplants

Nice detective work. I think that ssb-backlinks creates a database index of all messages which mention / reference another message. This includes votes, since a vote message mentions the message being voted on. It's then relatively fast to query these messages because they've already been indexed (with the index having been stored in the flume database).

+1 very interested to hear how the Planetary devs are doing this.

@notplants Nice detective work. I _think_ that ssb-backlinks creates a database index of all messages which mention / reference another message. This includes votes, since a vote message mentions the message being voted on. It's then relatively fast to query these messages because they've already been indexed (with the index having been stored in the flume database). +1 very interested to hear how the Planetary devs are doing this.
decentral1se commented 2022-11-17 18:10:21 +00:00
Contributor
Copy Link
Copy Source

afaiu Planetary folks are just taking the entire append-only log and piling it into a sqlite database and then the front-end is using that to put together queries and such.

I've opened up https://github.com/ssbc/go-ssb/issues/200 to try to track down how to get only votes on a post. tangles.thread gets replies. We're missing something, hopefully I'll manage to figure it out.

afaiu Planetary folks are just taking the entire append-only log and piling it into a sqlite database and then the front-end is using that to put together queries and such. I've opened up https://github.com/ssbc/go-ssb/issues/200 to try to track down how to get only votes on a post. `tangles.thread` gets replies. We're missing something, hopefully I'll manage to figure it out.
👍 1
glyph commented 2022-11-18 07:25:10 +00:00
Owner
Copy Link
Copy Source

I currently have tangles.thread working on dev branches of kuska + golgi. I'm making sure all the optional args work as expected and then I'll get that all merged.

My workaround idea for getting votes on a post would be:

  1. Check the root field in the message (to get the key of the root msg of the thread)
  2. Call tangles.thread with the root msg key (returns a stream of messages)
  3. Filter posts of type vote which reference the post of interest
  4. Tally votes made by each author to determine vote state (even or odd)

If an easier way comes along, awesome!

I currently have `tangles.thread` working on dev branches of `kuska` + `golgi`. I'm making sure all the optional args work as expected and then I'll get that all merged. My workaround idea for getting votes on a post would be: 1. Check the `root` field in the message (to get the key of the root msg of the thread) 2. Call `tangles.thread` with the root msg key (returns a stream of messages) 3. Filter posts of type `vote` which reference the post of interest 4. Tally votes made by each author to determine vote state (even or odd) If an easier way comes along, awesome!
🎉 1
decentral1se commented 2022-11-18 13:08:05 +00:00
Contributor
Copy Link
Copy Source
  1. Filter posts of type vote which reference the post of interest

From my testing, I see that no type=vote posts come back in the out of sbotcli replies (uses tangles.threads internally)? Lemme know if you see it tho, I might be missing it in the blob-of-JSON-return 🙃

Would be great to solve this as I need this functionality too.

> 3. Filter posts of type vote which reference the post of interest From my testing, I see that no `type=vote` posts come back in the out of `sbotcli replies` (uses `tangles.threads` internally)? Lemme know if you see it tho, I might be missing it in the blob-of-JSON-return 🙃 Would be great to solve this as I need this functionality too.
glyph commented 2022-11-18 13:21:50 +00:00
Owner
Copy Link
Copy Source

Hmm I am seeing votes in some cases but not others (and not all the votes).

Here's an example:

sbotcli replies "%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256" | grep '"type":"vote"'

Output:

{"previous":null,"author":"@DIoOBMaI1f0mJg+5tUzZ7vgzCeeHh8+zGta4pOjc+k0=.ed25519","sequence":1987,"timestamp":1668483452000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256","branch":["%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256"]}}
{"previous":null,"author":"@DIoOBMaI1f0mJg+5tUzZ7vgzCeeHh8+zGta4pOjc+k0=.ed25519","sequence":1990,"timestamp":1668645471000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256","branch":["%Jm7Bx6PrtDZPFXSsQKr1p7Rrm7HeWCP7mOslKAUh+UY=.sha256","%LLB1UxYAUM1d79uOrV/79NmlOSISR/crRZPG0VCCHQw=.sha256"]}}

Only two...should be lots more. Not sure if it's just a case of the other vote messages not having replicated yet?

Hmm I am seeing votes in some cases but not others (and not all the votes). Here's an example: ```shell sbotcli replies "%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256" | grep '"type":"vote"' ``` Output: ```json {"previous":null,"author":"@DIoOBMaI1f0mJg+5tUzZ7vgzCeeHh8+zGta4pOjc+k0=.ed25519","sequence":1987,"timestamp":1668483452000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256","branch":["%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256"]}} {"previous":null,"author":"@DIoOBMaI1f0mJg+5tUzZ7vgzCeeHh8+zGta4pOjc+k0=.ed25519","sequence":1990,"timestamp":1668645471000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%vY53ethgEG1tNsKqmLm6isNSbsu+jwMf/UNGMfUiLm0=.sha256","branch":["%Jm7Bx6PrtDZPFXSsQKr1p7Rrm7HeWCP7mOslKAUh+UY=.sha256","%LLB1UxYAUM1d79uOrV/79NmlOSISR/crRZPG0VCCHQw=.sha256"]}} ``` Only two...should be lots more. Not sure if it's just a case of the other vote messages not having replicated yet?
👀 1
glyph commented 2022-11-18 13:51:35 +00:00
Owner
Copy Link
Copy Source

Here's another one that yields a vote, but in general I'm seeing far fewer than I would expect.

sbotcli replies "%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256" | grep '"type":"vote"'

Output:

{"previous":null,"author":"@yUrNCh6XowOLtszmSlBCC0AziDdm8m4X//bcvkz/4Yg=.ed25519","sequence":137,"timestamp":1651879877000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256","branch":["%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256"]}}
Here's another one that yields a vote, but in general I'm seeing far fewer than I would expect. ```shell sbotcli replies "%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256" | grep '"type":"vote"' ``` Output: ```json {"previous":null,"author":"@yUrNCh6XowOLtszmSlBCC0AziDdm8m4X//bcvkz/4Yg=.ed25519","sequence":137,"timestamp":1651879877000,"hash":"","signature":"","content":{"type":"vote","text":"","root":"%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256","branch":["%Pnas64BJ60qbHF34BvsHiXYvMRj7CyKq8nsOlDCsWqA=.sha256"]}} ```
👀 1
decentral1se commented 2022-12-29 14:05:44 +00:00
Contributor
Copy Link
Copy Source

Right, I think https://github.com/ssbc/go-ssb/issues/251 is the cause for the lack of vote responses. TLDR; go-sbot is not correctly indexing all the messages. Working on a fix.

Right, I think https://github.com/ssbc/go-ssb/issues/251 is the cause for the lack of vote responses. TLDR; `go-sbot` is not correctly indexing all the messages. Working on a fix.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cblgh glyph (glyph) notplants
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#44