golgi-ssb/golgi
3
6
Fork 0
Code Issues 11 Pull Requests 1 Projects 1 Releases Wiki Activity

Return error when keystore read fails (don't panic) #46

New Issue
Closed
opened 2022-06-14 08:22:27 +00:00 by glyph · 1 comment
glyph commented 2022-06-14 08:22:27 +00:00
Owner
Copy Link
Copy Source

Behaviour:

Internal Server Error when navigating to the Scuttlebutt status page.

Steps to reproduce:

Run PeachPub on a computer without go-sbot installed, login to the web interface and click on the Status icon.

Error message:

thread '<unnamed>' panicked at 'couldn't read local secret: SyncIo(Custom { kind: NotFound, error: VerboseError { source: Os { code: 2, kind: NotFound, message: "No such file or directory" }, message: "could not open /home/cordyceps/.ssb-go/secret" } })', /home/cordyceps/.cargo/git/checkouts/golgi-bf299908ffde79a1/0aa616d/src/sbot.rs:75:18

Error source:

golgi/src/sbot.rs Line 72 in 0aa616d92b
.expect("couldn't read local secret"),

Suggested fix:

Return a GolgiError using the ? operator, rather than using expect. Handle the error in PeachPub and show an appropriate message to the user.

**Behaviour**: Internal Server Error when navigating to the Scuttlebutt status page. **Steps to reproduce**: Run PeachPub on a computer without go-sbot installed, login to the web interface and click on the Status icon. **Error message**: `thread '<unnamed>' panicked at 'couldn't read local secret: SyncIo(Custom { kind: NotFound, error: VerboseError { source: Os { code: 2, kind: NotFound, message: "No such file or directory" }, message: "could not open `/home/cordyceps/.ssb-go/secret`" } })', /home/cordyceps/.cargo/git/checkouts/golgi-bf299908ffde79a1/0aa616d/src/sbot.rs:75:18` **Error source**: https://git.coopcloud.tech/golgi-ssb/golgi/src/commit/0aa616d92b005b38359aa34bf448f3f1f47e8e6a/src/sbot.rs#L72 **Suggested fix**: Return a `GolgiError` using the `?` operator, rather than using `expect`. Handle the error in PeachPub and show an appropriate message to the user.
glyph added the bugenhancement labels 2022-06-14 08:22:27 +00:00
glyph commented 2022-07-18 07:09:14 +00:00
Author
Owner
Copy Link
Copy Source

Addressed in #51

Addressed in https://git.coopcloud.tech/golgi-ssb/golgi/pulls/51
glyph closed this issue 2022-07-18 07:09:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels bug enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cblgh glyph (glyph) notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#46