Expose options for create_history_stream RPC #55

New Issue

glyph · 2022-08-08T13:26:09Z

glyph commented

2022-08-08 13:26:09 +00:00

We don't currently offer the ability to pass optional arguments when calling create_history_stream. This means that we can't define seq ("only give me messages with sequence number > x") or limit ("only give me x messages"), among other arguments. I'd like to add args (or similar) as a second (optional) parameter to the function. kuska already has a type we can use:

kuska_ssb::api::dto::CreateHistoryStreamIn

https://github.com/Kuska-ssb/ssb/blob/master/src/api/dto/history_stream.rs

We don't currently offer the ability to pass optional arguments when calling `create_history_stream`. This means that we can't define `seq` ("only give me messages with sequence number > x") or `limit` ("only give me x messages"), among other arguments. I'd like to add `args` (or similar) as a second (optional) parameter to the function. kuska already has a type we can use: ```rust kuska_ssb::api::dto::CreateHistoryStreamIn ``` https://github.com/Kuska-ssb/ssb/blob/master/src/api/dto/history_stream.rs

glyph added the

enhancement

label 2022-08-08 13:26:09 +00:00

glyph self-assigned this 2022-08-08 13:26:09 +00:00

glyph referenced this issue

2022-08-09 07:36:09 +00:00

Pass complete args struct to create_history_stream #56

glyph commented

2022-09-20 07:56:34 +00:00

Addressed by #56.

Addressed by https://git.coopcloud.tech/golgi-ssb/golgi/pulls/56.

glyph closed this issue