refactor: move strings.Join to DeployOverview

cli/app/deploy.go

@@ -215,9 +215,9 @@ checkout as-is. Recipe commit hashes are also supported as values for
 			toDeployVersion,
 			"",
 			deployWarnMessages,
-			strings.Join(secretInfo, "\n"),
+			secretInfo,
-			strings.Join(configInfo, "\n"),
+			configInfo,
-			strings.Join(imageInfo, "\n"),
+			imageInfo,
 		); err != nil {
 			log.Fatal(err)
 		}

cli/app/rollback.go

@@ -210,9 +210,9 @@ beforehand. See "abra app backup" for more.`),
 			chosenDowngrade,
 			"",
 			downgradeWarnMessages,
-			strings.Join(secretInfo, "\n"),
+			secretInfo,
-			strings.Join(configInfo, "\n"),
+			configInfo,
-			strings.Join(imageInfo, "\n"),
+			imageInfo,
 		); err != nil {
 			log.Fatal(err)
 		}

cli/app/undeploy.go

@@ -71,9 +71,9 @@ Passing "--prune/-p" does not remove those volumes.`),
 			config.NO_DOMAIN_DEFAULT,
 			"",
 			nil,
-			"",
+			nil,
-			"",
+			nil,
-			"",
+			nil,
 		); err != nil {
 			log.Fatal(err)
 		}

cli/app/upgrade.go

@@ -247,9 +247,9 @@ beforehand. See "abra app backup" for more.`),
 			chosenUpgrade,
 			upgradeReleaseNotes,
 			upgradeWarnMessages,
-			strings.Join(secretInfo, "\n"),
+			secretInfo,
-			strings.Join(configInfo, "\n"),
+			configInfo,
-			strings.Join(imageInfo, "\n"),
+			imageInfo,
 		); err != nil {
 			log.Fatal(err)
 		}

cli/internal/deploy.go

@@ -50,9 +50,9 @@ func DeployOverview(
 	toDeployVersion string,
 	releaseNotes string,
 	warnMessages []string,
-	secrets string,
+	secrets []string,
-	configs string,
+	configs []string,
-	images string,
+	images []string,
 ) error {
 	deployConfig := "compose.yml"
 	if composeFiles, ok := app.Env["COMPOSE_FILE"]; ok {
@@ -84,13 +84,13 @@ func DeployOverview(
 		{i18n.G("ENV VERSION"), formatter.BoldDirtyDefault(envVersion)},
 		{i18n.G("NEW DEPLOYMENT"), formatter.BoldDirtyDefault(toDeployVersion)},
 		{"", ""},
-		{i18n.G("IMAGES"), images},
+		{i18n.G("IMAGES"), strings.Join(images, "\n")},
 	}
 
 	if len(secrets) > 0 {
 		secretsRows := [][]string{
 			{"", ""},
-			{i18n.G("SECRETS"), secrets},
+			{i18n.G("SECRETS"), strings.Join(secrets, "\n")},
 		}
 		rows = append(rows, secretsRows...)
 	}
@@ -98,7 +98,7 @@ func DeployOverview(
 	if len(configs) > 0 {
 		configsRows := [][]string{
 			{"", ""},
-			{i18n.G("CONFIGS"), configs},
+			{i18n.G("CONFIGS"), strings.Join(configs, "\n")},
 		}
 		rows = append(rows, configsRows...)
 	}