fmt

.drone.yml

@@ -29,7 +29,7 @@ steps:
       event: tag
 
   - name: release
-    image: goreleaser/goreleaser:v1.24.0
+    image: goreleaser/goreleaser:v1.18.2
     environment:
       GITEA_TOKEN:
         from_secret: goreleaser_gitea_token

.goreleaser.yml

@@ -29,8 +29,6 @@ builds:
     ldflags:
       - "-X 'main.Commit={{ .Commit }}'"
       - "-X 'main.Version={{ .Version }}'"
-      - "-s"
-      - "-w"
 
   - id: kadabra
     binary: kadabra
@@ -52,8 +50,12 @@ builds:
     ldflags:
       - "-X 'main.Commit={{ .Commit }}'"
       - "-X 'main.Version={{ .Version }}'"
-      - "-s"
+
-      - "-w"
+archives:
+  - replacements:
+      386: i386
+      amd64: x86_64
+    format: binary
 
 checksum:
   name_template: "checksums.txt"

AUTHORS.md

@@ -7,7 +7,6 @@
 - cassowary
 - codegod100
 - decentral1se
-- fauno
 - frando
 - kawaiipunk
 - knoflook

Dockerfile

@@ -1,29 +1,23 @@
-# Build image
 FROM golang:1.21-alpine AS build
 
 ENV GOPRIVATE coopcloud.tech
 
 RUN apk add --no-cache \
+  ca-certificates \
   gcc \
   git \
   make \
   musl-dev
 
+RUN update-ca-certificates
+
 COPY . /app
 
 WORKDIR /app
 
 RUN CGO_ENABLED=0 make build
 
-# Release image ("slim")
+FROM scratch
-FROM alpine:3.19.1
-
-RUN apk add --no-cache \
-  ca-certificates \
-  git \
-  openssh
-
-RUN update-ca-certificates
 
 COPY --from=build /app/abra /abra
 

Makefile

@@ -53,6 +53,3 @@ test:
 
 loc:
 	@find . -name "*.go" | xargs wc -l
-
-deps:
-	@go get -t -u ./...

cli/app/app.go

@@ -1,7 +1,7 @@
 package app
 
 import (
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var AppCommand = cli.Command{
@@ -10,28 +10,28 @@ var AppCommand = cli.Command{
 	Usage:       "Manage apps",
 	ArgsUsage:   "<domain>",
 	Description: "Functionality for managing the life cycle of your apps",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		appBackupCommand,
+		&appBackupCommand,
-		appCheckCommand,
+		&appCheckCommand,
-		appCmdCommand,
+		&appCmdCommand,
-		appConfigCommand,
+		&appConfigCommand,
-		appCpCommand,
+		&appCpCommand,
-		appDeployCommand,
+		&appDeployCommand,
-		appErrorsCommand,
+		&appErrorsCommand,
-		appListCommand,
+		&appListCommand,
-		appLogsCommand,
+		&appLogsCommand,
-		appNewCommand,
+		&appNewCommand,
-		appPsCommand,
+		&appPsCommand,
-		appRemoveCommand,
+		&appRemoveCommand,
-		appRestartCommand,
+		&appRestartCommand,
-		appRestoreCommand,
+		&appRestoreCommand,
-		appRollbackCommand,
+		&appRollbackCommand,
-		appRunCommand,
+		&appRunCommand,
-		appSecretCommand,
+		&appSecretCommand,
-		appServicesCommand,
+		&appServicesCommand,
-		appUndeployCommand,
+		&appUndeployCommand,
-		appUpgradeCommand,
+		&appUpgradeCommand,
-		appVersionCommand,
+		&appVersionCommand,
-		appVolumeCommand,
+		&appVolumeCommand,
 	},
 }

cli/app/backup.go

@@ -8,7 +8,7 @@ import (
 	"coopcloud.tech/abra/pkg/client"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var snapshot string
@@ -287,10 +287,10 @@ var appBackupCommand = cli.Command{
 	Aliases:   []string{"b"},
 	Usage:     "Manage app backups",
 	ArgsUsage: "<domain>",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		appBackupListCommand,
+		&appBackupListCommand,
-		appBackupSnapshotsCommand,
+		&appBackupSnapshotsCommand,
-		appBackupDownloadCommand,
+		&appBackupDownloadCommand,
-		appBackupCreateCommand,
+		&appBackupCreateCommand,
 	},
 }

cli/app/check.go

@@ -8,7 +8,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appCheckCommand = cli.Command{

cli/app/cmd.go

@@ -17,7 +17,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appCmdCommand = cli.Command{
@@ -45,10 +45,10 @@ Example:
 		internal.ChaosFlag,
 	},
 	Before:      internal.SubCommandBefore,
-	Subcommands: []cli.Command{appCmdListCommand},
+	Subcommands: []*cli.Command{&appCmdListCommand},
 	BashComplete: func(ctx *cli.Context) {
 		args := ctx.Args()
-		switch len(args) {
+		switch args.Len() {
 		case 0:
 			autocomplete.AppNameComplete(ctx)
 		case 1:
@@ -84,7 +84,7 @@ Example:
 			internal.ShowSubcommandHelpAndError(c, errors.New("cannot use --local & --user together"))
 		}
 
-		hasCmdArgs, parsedCmdArgs := parseCmdArgs(c.Args(), internal.LocalCmd)
+		hasCmdArgs, parsedCmdArgs := parseCmdArgs(c.Args().Slice())
 
 		abraSh := path.Join(config.RECIPES_DIR, app.Recipe, "abra.sh")
 		if _, err := os.Stat(abraSh); err != nil {
@@ -95,7 +95,7 @@ Example:
 		}
 
 		if internal.LocalCmd {
-			if !(len(c.Args()) >= 2) {
+			if !(c.Args().Len() >= 2) {
 				internal.ShowSubcommandHelpAndError(c, errors.New("missing arguments"))
 			}
 
@@ -131,7 +131,7 @@ Example:
 				logrus.Fatal(err)
 			}
 		} else {
-			if !(len(c.Args()) >= 3) {
+			if !(c.Args().Len() >= 3) {
 				internal.ShowSubcommandHelpAndError(c, errors.New("missing arguments"))
 			}
 
@@ -180,24 +180,17 @@ Example:
 	},
 }
 
-func parseCmdArgs(args []string, isLocal bool) (bool, string) {
+// Parse the command arguments from the cli args.
-	var (
+// Arguments should look like this:
-		parsedCmdArgs string
+//
-		hasCmdArgs    bool
+//	DOMAIN COMMAND -- ARGUMENT1 ARGUMENT2 ...
-	)
+func parseCmdArgs(args []string) (bool, string) {
-
+	if len(args) < 4 {
-	if isLocal {
+		return false, ""
-		if len(args) > 2 {
-			return true, fmt.Sprintf("%s ", strings.Join(args[2:], " "))
 	}
-	} else {
+
-		if len(args) > 3 {
 	return true, fmt.Sprintf("%s ", strings.Join(args[3:], " "))
 }
-	}
-
-	return hasCmdArgs, parsedCmdArgs
-}
 
 func cmdNameComplete(appName string) {
 	app, err := app.Get(appName)

cli/app/cmd_test.go

@@ -20,7 +20,7 @@ func TestParseCmdArgs(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		ok, parsed := parseCmdArgs(test.input, false)
+		ok, parsed := parseCmdArgs(test.input)
 		if ok != test.shouldParse {
 			t.Fatalf("[%s] should not parse", strings.Join(test.input, " "))
 		}

cli/app/config.go

@@ -10,7 +10,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appConfigCommand = cli.Command{

cli/app/cp.go

@@ -22,7 +22,7 @@ import (
 	"github.com/docker/docker/errdefs"
 	"github.com/docker/docker/pkg/archive"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appCpCommand = cli.Command{

cli/app/deploy.go

@@ -17,7 +17,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appDeployCommand = cli.Command{
@@ -97,19 +97,6 @@ recipes.
 			logrus.Fatal(err)
 		}
 
-		// NOTE(d1): check out specific version before dealing with secrets. This
-		// is because we need to deal with GetComposeFiles under the hood and these
-		// files change from version to version which therefore affects which
-		// secrets might be generated
-		version := deployedVersion
-		if specificVersion != "" {
-			version = specificVersion
-			logrus.Debugf("choosing %s as version to deploy", version)
-			if err := recipe.EnsureVersion(app.Recipe, version); err != nil {
-				logrus.Fatal(err)
-			}
-		}
-
 		secStats, err := secret.PollSecretsStatus(cl, app)
 		if err != nil {
 			logrus.Fatal(err)
@@ -129,6 +116,15 @@ recipes.
 			}
 		}
 
+		version := deployedVersion
+		if specificVersion != "" {
+			version = specificVersion
+			logrus.Debugf("choosing %s as version to deploy", version)
+			if err := recipe.EnsureVersion(app.Recipe, version); err != nil {
+				logrus.Fatal(err)
+			}
+		}
+
 		if !internal.Chaos && specificVersion == "" {
 			catl, err := recipe.ReadRecipeCatalogue(internal.Offline)
 			if err != nil {

cli/app/errors.go

@@ -13,11 +13,11 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/recipe"
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
-	containerTypes "github.com/docker/docker/api/types/container"
+	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/filters"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appErrorsCommand = cli.Command{
@@ -97,7 +97,7 @@ func checkErrors(c *cli.Context, cl *dockerClient.Client, app config.App) error
 		filters := filters.NewArgs()
 		filters.Add("name", fmt.Sprintf("^%s_%s", app.StackName(), service.Name))
 
-		containers, err := cl.ContainerList(context.Background(), containerTypes.ListOptions{Filters: filters})
+		containers, err := cl.ContainerList(context.Background(), types.ContainerListOptions{Filters: filters})
 		if err != nil {
 			return err
 		}

cli/app/list.go

@@ -13,19 +13,21 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/tagcmp"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var status bool
 var statusFlag = &cli.BoolFlag{
-	Name:        "status, S",
+	Name:        "status",
+	Aliases:     []string{"S"},
 	Usage:       "Show app deployment status",
 	Destination: &status,
 }
 
 var recipeFilter string
 var recipeFlag = &cli.StringFlag{
-	Name:        "recipe, r",
+	Name:        "recipe",
+	Aliases:     []string{"r"},
 	Value:       "",
 	Usage:       "Show apps of a specific recipe",
 	Destination: &recipeFilter,
@@ -33,7 +35,8 @@ var recipeFlag = &cli.StringFlag{
 
 var listAppServer string
 var listAppServerFlag = &cli.StringFlag{
-	Name:        "server, s",
+	Name:        "server",
+	Aliases:     []string{"s"},
 	Value:       "",
 	Usage:       "Show apps of a specific server",
 	Destination: &listAppServer,

cli/app/logs.go

@@ -15,12 +15,11 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/docker/docker/api/types"
-	containerTypes "github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/api/types/swarm"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appLogsCommand = cli.Command{
@@ -111,7 +110,7 @@ func tailLogs(cl *dockerClient.Client, app config.App, serviceNames []string) er
 		// collected in parallel.
 		wg.Add(1)
 		go func(serviceID string) {
-			logs, err := cl.ServiceLogs(context.Background(), serviceID, containerTypes.LogsOptions{
+			logs, err := cl.ServiceLogs(context.Background(), serviceID, types.ContainerLogsOptions{
 				ShowStderr: true,
 				ShowStdout: !internal.StdErrOnly,
 				Since:      internal.SinceLogs,

cli/app/new.go

@@ -10,12 +10,13 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/jsontable"
+	"coopcloud.tech/abra/pkg/recipe"
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/abra/pkg/secret"
 	"github.com/AlecAivazis/survey/v2"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appNewDescription = `
@@ -57,7 +58,7 @@ var appNewCommand = cli.Command{
 	ArgsUsage: "[<recipe>] [<version>]",
 	BashComplete: func(ctx *cli.Context) {
 		args := ctx.Args()
-		switch len(args) {
+		switch args.Len() {
 		case 0:
 			autocomplete.RecipeNameComplete(ctx)
 		case 1:
@@ -77,29 +78,9 @@ var appNewCommand = cli.Command{
 				}
 			}
 			if c.Args().Get(1) == "" {
-				var version string
-
-				recipeVersions, err := recipePkg.GetRecipeVersions(recipe.Name, internal.Offline)
-				if err != nil {
-					logrus.Fatal(err)
-				}
-
-				// NOTE(d1): determine whether recipe versions exist or not and check
-				// out the latest version or current HEAD
-				if len(recipeVersions) > 0 {
-					latest := recipeVersions[len(recipeVersions)-1]
-					for tag := range latest {
-						version = tag
-					}
-
-					if err := recipePkg.EnsureVersion(recipe.Name, version); err != nil {
-						logrus.Fatal(err)
-					}
-				} else {
 				if err := recipePkg.EnsureLatest(recipe.Name); err != nil {
 					logrus.Fatal(err)
 				}
-				}
 			} else {
 				if err := recipePkg.EnsureVersion(recipe.Name, c.Args().Get(1)); err != nil {
 					logrus.Fatal(err)
@@ -202,12 +183,6 @@ type AppSecrets map[string]string
 
 // createSecrets creates all secrets for a new app.
 func createSecrets(cl *dockerClient.Client, secretsConfig map[string]secret.Secret, sanitisedAppName string) (AppSecrets, error) {
-	// NOTE(d1): trim to match app.StackName() implementation
-	if len(sanitisedAppName) > config.MAX_SANITISED_APP_NAME_LENGTH {
-		logrus.Debugf("trimming %s to %s to avoid runtime limits", sanitisedAppName, sanitisedAppName[:config.MAX_SANITISED_APP_NAME_LENGTH])
-		sanitisedAppName = sanitisedAppName[:config.MAX_SANITISED_APP_NAME_LENGTH]
-	}
-
 	secrets, err := secret.GenerateSecrets(cl, secretsConfig, internal.NewAppServer)
 	if err != nil {
 		return nil, err
@@ -231,7 +206,7 @@ func createSecrets(cl *dockerClient.Client, secretsConfig map[string]secret.Secr
 }
 
 // ensureDomainFlag checks if the domain flag was used. if not, asks the user for it/
-func ensureDomainFlag(recipe recipePkg.Recipe, server string) error {
+func ensureDomainFlag(recipe recipe.Recipe, server string) error {
 	if internal.Domain == "" && !internal.NoInput {
 		prompt := &survey.Input{
 			Message: "Specify app domain",

cli/app/ps.go

@@ -2,8 +2,7 @@ package app
 
 import (
 	"context"
-	"encoding/json"
+	"strings"
-	"fmt"
 	"time"
 
 	"coopcloud.tech/abra/cli/internal"
@@ -11,16 +10,14 @@ import (
 	"coopcloud.tech/abra/pkg/client"
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/formatter"
-	"coopcloud.tech/abra/pkg/recipe"
+	"coopcloud.tech/abra/pkg/service"
-	abraService "coopcloud.tech/abra/pkg/service"
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/buger/goterm"
 	dockerFormatter "github.com/docker/cli/cli/command/formatter"
-	containerTypes "github.com/docker/docker/api/types/container"
+	"github.com/docker/docker/api/types"
-	"github.com/docker/docker/api/types/filters"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appPsCommand = cli.Command{
@@ -30,7 +27,6 @@ var appPsCommand = cli.Command{
 	ArgsUsage:   "<domain>",
 	Description: "Show a more detailed status output of a specific deployed app",
 	Flags: []cli.Flag{
-		internal.MachineReadableFlag,
 		internal.WatchFlag,
 		internal.DebugFlag,
 	},
@@ -44,7 +40,7 @@ var appPsCommand = cli.Command{
 			logrus.Fatal(err)
 		}
 
-		isDeployed, deployedVersion, err := stack.IsDeployed(context.Background(), cl, app.StackName())
+		isDeployed, _, err := stack.IsDeployed(context.Background(), cl, app.StackName())
 		if err != nil {
 			logrus.Fatal(err)
 		}
@@ -53,15 +49,6 @@ var appPsCommand = cli.Command{
 			logrus.Fatalf("%s is not deployed?", app.Name)
 		}
 
-		statuses, err := config.GetAppStatuses([]config.App{app}, true)
-		if statusMeta, ok := statuses[app.StackName()]; ok {
-			if _, exists := statusMeta["chaos"]; !exists {
-				if err := recipe.EnsureVersion(app.Recipe, deployedVersion); err != nil {
-					logrus.Fatal(err)
-				}
-			}
-		}
-
 		if !internal.Watch {
 			showPSOutput(c, app, cl)
 			return nil
@@ -79,77 +66,36 @@ var appPsCommand = cli.Command{
 
 // showPSOutput renders ps output.
 func showPSOutput(c *cli.Context, app config.App, cl *dockerClient.Client) {
-	composeFiles, err := config.GetComposeFiles(app.Recipe, app.Env)
+	filters, err := app.Filters(true, true)
 	if err != nil {
 		logrus.Fatal(err)
-		return
 	}
 
-	deployOpts := stack.Deploy{
+	containers, err := cl.ContainerList(context.Background(), types.ContainerListOptions{Filters: filters})
-		Composefiles: composeFiles,
-		Namespace:    app.StackName(),
-		Prune:        false,
-		ResolveImage: stack.ResolveImageAlways,
-	}
-	compose, err := config.GetAppComposeConfig(app.Name, deployOpts, app.Env)
 	if err != nil {
 		logrus.Fatal(err)
-		return
 	}
 
-	var tablerows [][]string
-	allContainerStats := make(map[string]map[string]string)
-	for _, service := range compose.Services {
-		filters := filters.NewArgs()
-		filters.Add("name", fmt.Sprintf("^%s_%s", app.StackName(), service.Name))
-
-		containers, err := cl.ContainerList(context.Background(), containerTypes.ListOptions{Filters: filters})
-		if err != nil {
-			logrus.Fatal(err)
-			return
-		}
-
-		var containerStats map[string]string
-
-		if len(containers) == 0 {
-			containerStats = map[string]string{
-				"service name": service.Name,
-				"image":        "unknown",
-				"created":      "unknown",
-				"status":       "unknown",
-				"state":        "unknown",
-				"ports":        "unknown",
-			}
-		} else {
-			container := containers[0]
-			containerStats = map[string]string{
-				"service name": abraService.ContainerToServiceName(container.Names, app.StackName()),
-				"image":        formatter.RemoveSha(container.Image),
-				"created":      formatter.HumanDuration(container.Created),
-				"status":       container.Status,
-				"state":        container.State,
-				"ports":        dockerFormatter.DisplayablePorts(container.Ports),
-			}
-		}
-		allContainerStats[containerStats["service name"]] = containerStats
-
-		var tablerow []string = []string{containerStats["service name"], containerStats["image"], containerStats["created"], containerStats["status"], containerStats["state"], containerStats["ports"]}
-		tablerows = append(tablerows, tablerow)
-	}
-	if internal.MachineReadable {
-		jsonstring, err := json.Marshal(allContainerStats)
-		if err != nil {
-			logrus.Fatal(err)
-		} else {
-			fmt.Println(string(jsonstring))
-		}
-		return
-	} else {
 	tableCol := []string{"service name", "image", "created", "status", "state", "ports"}
 	table := formatter.CreateTable(tableCol)
-		for _, row := range tablerows {
+
-			table.Append(row)
+	for _, container := range containers {
+		var containerNames []string
+		for _, containerName := range container.Names {
+			trimmed := strings.TrimPrefix(containerName, "/")
+			containerNames = append(containerNames, trimmed)
 		}
+
+		tableRow := []string{
+			service.ContainerToServiceName(container.Names, app.StackName()),
+			formatter.RemoveSha(container.Image),
+			formatter.HumanDuration(container.Created),
+			container.Status,
+			container.State,
+			dockerFormatter.DisplayablePorts(container.Ports),
+		}
+		table.Append(tableRow)
+	}
+
 	table.Render()
 }
-}

cli/app/remove.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"time"
 
 	"coopcloud.tech/abra/cli/internal"
 	"coopcloud.tech/abra/pkg/autocomplete"
@@ -12,8 +13,9 @@ import (
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/docker/docker/api/types"
+	"github.com/docker/docker/api/types/volume"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appRemoveCommand = cli.Command{
@@ -110,19 +112,28 @@ flag.
 			logrus.Fatal(err)
 		}
 
-		volumeList, err := client.GetVolumes(cl, context.Background(), app.Server, fs)
+		volumeListOptions := volume.ListOptions{fs}
+		volumeListOKBody, err := cl.VolumeList(context.Background(), volumeListOptions)
+		volumeList := volumeListOKBody.Volumes
 		if err != nil {
 			logrus.Fatal(err)
 		}
-		volumeNames := client.GetVolumeNames(volumeList)
 
-		if len(volumeNames) > 0 {
+		var vols []string
-			err := client.RemoveVolumes(cl, context.Background(), volumeNames, internal.Force, 5)
+		for _, vol := range volumeList {
+			vols = append(vols, vol.Name)
+		}
+
+		if len(vols) > 0 {
+			for _, vol := range vols {
+				err = retryFunc(5, func() error {
+					return cl.VolumeRemove(context.Background(), vol, internal.Force) // last argument is for force removing
+				})
 				if err != nil {
 					log.Fatalf("removing volumes failed: %s", err)
 				}
-
+				logrus.Info(fmt.Sprintf("volume %s removed", vol))
-			logrus.Infof("%d volumes removed successfully", len(volumeNames))
+			}
 		} else {
 			logrus.Info("no volumes to remove")
 		}
@@ -136,3 +147,21 @@ flag.
 		return nil
 	},
 }
+
+// retryFunc retries the given function for the given retries. After the nth
+// retry it waits (n + 1)^2 seconds before the next retry (starting with n=0).
+// It returns an error if the function still failed after the last retry.
+func retryFunc(retries int, fn func() error) error {
+	for i := 0; i < retries; i++ {
+		err := fn()
+		if err == nil {
+			return nil
+		}
+		if i+1 < retries {
+			sleep := time.Duration(i+1) * time.Duration(i+1)
+			logrus.Infof("%s: waiting %d seconds before next retry", err, sleep)
+			time.Sleep(sleep * time.Second)
+		}
+	}
+	return fmt.Errorf("%d retries failed", retries)
+}

cli/app/remove_test.go

@@ -1,4 +1,4 @@
-package client
+package app
 
 import (
 	"fmt"

cli/app/restart.go

@@ -11,7 +11,7 @@ import (
 	upstream "coopcloud.tech/abra/pkg/upstream/service"
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appRestartCommand = cli.Command{

cli/app/restore.go

@@ -8,7 +8,7 @@ import (
 	"coopcloud.tech/abra/pkg/client"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var targetPath string

cli/app/rollback.go

@@ -15,7 +15,7 @@ import (
 	"coopcloud.tech/abra/pkg/client"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appRollbackCommand = cli.Command{

cli/app/run.go

@@ -14,7 +14,7 @@ import (
 	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var user string
@@ -45,11 +45,11 @@ var appRunCommand = cli.Command{
 	Action: func(c *cli.Context) error {
 		app := internal.ValidateApp(c)
 
-		if len(c.Args()) < 2 {
+		if c.Args().Len() < 2 {
 			internal.ShowSubcommandHelpAndError(c, errors.New("no <service> provided?"))
 		}
 
-		if len(c.Args()) < 3 {
+		if c.Args().Len() < 3 {
 			internal.ShowSubcommandHelpAndError(c, errors.New("no <args> provided?"))
 		}
 
@@ -68,7 +68,7 @@ var appRunCommand = cli.Command{
 			logrus.Fatal(err)
 		}
 
-		cmd := c.Args()[2:]
+		cmd := c.Args().Slice()[2:]
 		execCreateOpts := types.ExecConfig{
 			AttachStderr: true,
 			AttachStdin:  true,

cli/app/secret.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"os"
 	"strconv"
-	"strings"
 
 	"coopcloud.tech/abra/cli/internal"
 	"coopcloud.tech/abra/pkg/autocomplete"
@@ -18,7 +17,7 @@ import (
 	"github.com/docker/docker/api/types"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var (
@@ -77,7 +76,7 @@ var appSecretGenerateCommand = cli.Command{
 			}
 		}
 
-		if len(c.Args()) == 1 && !allSecrets {
+		if c.Args().Len() == 1 && !allSecrets {
 			err := errors.New("missing arguments <secret>/<version> or '--all'")
 			internal.ShowSubcommandHelpAndError(c, err)
 		}
@@ -157,8 +156,6 @@ var appSecretInsertCommand = cli.Command{
 	Flags: []cli.Flag{
 		internal.DebugFlag,
 		internal.PassFlag,
-		internal.FileFlag,
-		internal.TrimFlag,
 	},
 	Before:       internal.SubCommandBefore,
 	ArgsUsage:    "<domain> <secret-name> <version> <data>",
@@ -178,7 +175,7 @@ Example:
 	Action: func(c *cli.Context) error {
 		app := internal.ValidateApp(c)
 
-		if len(c.Args()) != 4 {
+		if c.Args().Len() != 4 {
 			internal.ShowSubcommandHelpAndError(c, errors.New("missing arguments?"))
 		}
 
@@ -191,18 +188,6 @@ Example:
 		version := c.Args().Get(2)
 		data := c.Args().Get(3)
 
-		if internal.File {
-			raw, err := os.ReadFile(data)
-			if err != nil {
-				logrus.Fatalf("reading secret from file: %s", err)
-			}
-			data = string(raw)
-		}
-
-		if internal.Trim {
-			data = strings.TrimSpace(data)
-		}
-
 		secretName := fmt.Sprintf("%s_%s_%s", app.StackName(), name, version)
 		if err := client.StoreSecret(cl, secretName, data, app.Server); err != nil {
 			logrus.Fatal(err)
@@ -434,10 +419,10 @@ var appSecretCommand = cli.Command{
 	Aliases:   []string{"s"},
 	Usage:     "Manage app secrets",
 	ArgsUsage: "<domain>",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		appSecretGenerateCommand,
+		&appSecretGenerateCommand,
-		appSecretInsertCommand,
+		&appSecretInsertCommand,
-		appSecretRmCommand,
+		&appSecretRmCommand,
-		appSecretLsCommand,
+		&appSecretLsCommand,
 	},
 }

cli/app/services.go

@@ -11,9 +11,9 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/service"
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
-	containerTypes "github.com/docker/docker/api/types/container"
+	"github.com/docker/docker/api/types"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appServicesCommand = cli.Command{
@@ -48,7 +48,7 @@ var appServicesCommand = cli.Command{
 			logrus.Fatal(err)
 		}
 
-		containers, err := cl.ContainerList(context.Background(), containerTypes.ListOptions{Filters: filters})
+		containers, err := cl.ContainerList(context.Background(), types.ContainerListOptions{Filters: filters})
 		if err != nil {
 			logrus.Fatal(err)
 		}

cli/app/undeploy.go

@@ -14,7 +14,7 @@ import (
 	"github.com/docker/docker/api/types/filters"
 	dockerClient "github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var prune bool

cli/app/upgrade.go

@@ -15,7 +15,7 @@ import (
 	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appUpgradeCommand = cli.Command{
@@ -31,7 +31,6 @@ var appUpgradeCommand = cli.Command{
 		internal.NoDomainChecksFlag,
 		internal.DontWaitConvergeFlag,
 		internal.OfflineFlag,
-		internal.ReleaseNotesFlag,
 	},
 	Before: internal.SubCommandBefore,
 	Description: `
@@ -194,17 +193,17 @@ recipes.
 		// check out the tag and then they'll appear to be missing. this covers
 		// when we obviously will forget to write release notes before publishing
 		var releaseNotes string
-		if chosenUpgrade != "" {
-			parsedChosenUpgrade, err := tagcmp.Parse(chosenUpgrade)
-			if err != nil {
-				logrus.Fatal(err)
-			}
 		for _, version := range versions {
 			parsedVersion, err := tagcmp.Parse(version)
 			if err != nil {
 				logrus.Fatal(err)
 			}
-				if parsedVersion.IsGreaterThan(parsedDeployedVersion) && parsedVersion.IsLessThan(parsedChosenUpgrade) {
+			parsedChosenUpgrade, err := tagcmp.Parse(chosenUpgrade)
+			if err != nil {
+				logrus.Fatal(err)
+			}
+
+			if !(parsedVersion.Equals(parsedDeployedVersion)) && parsedVersion.IsLessThan(parsedChosenUpgrade) {
 				note, err := internal.GetReleaseNotes(app.Recipe, version)
 				if err != nil {
 					return err
@@ -214,7 +213,6 @@ recipes.
 				}
 			}
 		}
-		}
 
 		if !internal.Chaos {
 			if err := recipePkg.EnsureVersion(app.Recipe, chosenUpgrade); err != nil {
@@ -271,12 +269,6 @@ recipes.
 			}
 		}
 
-		if internal.ReleaseNotes {
-			fmt.Println()
-			fmt.Print(releaseNotes)
-			return nil
-		}
-
 		if err := internal.NewVersionOverview(app, deployedVersion, chosenUpgrade, releaseNotes); err != nil {
 			logrus.Fatal(err)
 		}

cli/app/version.go

@@ -10,10 +10,10 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/abra/pkg/upstream/stack"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 	"github.com/olekukonko/tablewriter"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 func sortServiceByName(versions [][]string) func(i, j int) bool {

cli/app/volume.go

@@ -2,7 +2,6 @@ package app
 
 import (
 	"context"
-	"log"
 
 	"coopcloud.tech/abra/cli/internal"
 	"coopcloud.tech/abra/pkg/autocomplete"
@@ -11,7 +10,7 @@ import (
 	"coopcloud.tech/abra/pkg/upstream/stack"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var appVolumeListCommand = cli.Command{
@@ -132,12 +131,12 @@ Passing "--force/-f" will select all volumes for removal. Be careful.
 		}
 
 		if len(volumesToRemove) > 0 {
-			err := client.RemoveVolumes(cl, context.Background(), volumesToRemove, internal.Force, 5)
+			err = client.RemoveVolumes(cl, context.Background(), app.Server, volumesToRemove, internal.Force)
 			if err != nil {
-				log.Fatalf("removing volumes failed: %s", err)
+				logrus.Fatal(err)
 			}
 
-			logrus.Infof("%d volumes removed successfully", len(volumesToRemove))
+			logrus.Info("volumes removed successfully")
 		} else {
 			logrus.Info("no volumes removed")
 		}
@@ -151,8 +150,8 @@ var appVolumeCommand = cli.Command{
 	Aliases:   []string{"vl"},
 	Usage:     "Manage app volumes",
 	ArgsUsage: "<domain>",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		appVolumeListCommand,
+		&appVolumeListCommand,
-		appVolumeRemoveCommand,
+		&appVolumeRemoveCommand,
 	},
 }

cli/catalogue/catalogue.go

@@ -15,7 +15,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/go-git/go-git/v5"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var catalogueGenerateCommand = cli.Command{
@@ -217,7 +217,7 @@ var CatalogueCommand = cli.Command{
 	Aliases:     []string{"c"},
 	ArgsUsage:   "<recipe>",
 	Description: "This command helps recipe packagers interact with the recipe catalogue",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		catalogueGenerateCommand,
+		&catalogueGenerateCommand,
 	},
 }

cli/cli.go

@@ -18,7 +18,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/web"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // AutoCompleteCommand helps people set up auto-complete in their shells
@@ -153,13 +153,13 @@ func newAbraApp(version, commit string) *cli.App {
                          |_|
 `,
 		Version: fmt.Sprintf("%s-%s", version, commit[:7]),
-		Commands: []cli.Command{
+		Commands: []*cli.Command{
-			app.AppCommand,
+			&app.AppCommand,
-			server.ServerCommand,
+			&server.ServerCommand,
-			recipe.RecipeCommand,
+			&recipe.RecipeCommand,
-			catalogue.CatalogueCommand,
+			&catalogue.CatalogueCommand,
-			UpgradeCommand,
+			&UpgradeCommand,
-			AutoCompleteCommand,
+			&AutoCompleteCommand,
 		},
 		BashComplete: autocomplete.SubcommandComplete,
 	}

cli/internal/cli.go

@@ -5,7 +5,7 @@ import (
 
 	logrusStack "github.com/Gurpartap/logrus-stack"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // Secrets stores the variable from SecretsFlag
@@ -13,7 +13,8 @@ var Secrets bool
 
 // SecretsFlag turns on/off automatically generating secrets
 var SecretsFlag = &cli.BoolFlag{
-	Name:        "secrets, S",
+	Name:        "secrets",
+	Aliases:     []string{"S"},
 	Usage:       "Automatically generate secrets",
 	Destination: &Secrets,
 }
@@ -23,7 +24,8 @@ var Pass bool
 
 // PassFlag turns on/off storing generated secrets in pass
 var PassFlag = &cli.BoolFlag{
-	Name:        "pass, p",
+	Name:        "pass",
+	Aliases:     []string{"p"},
 	Usage:       "Store the generated secrets in a local pass store",
 	Destination: &Pass,
 }
@@ -33,31 +35,19 @@ var PassRemove bool
 
 // PassRemoveFlag turns on/off removing generated secrets from pass
 var PassRemoveFlag = &cli.BoolFlag{
-	Name:        "pass, p",
+	Name:        "pass",
+	Aliases:     []string{"p"},
 	Usage:       "Remove generated secrets from a local pass store",
 	Destination: &PassRemove,
 }
 
-var File bool
-var FileFlag = &cli.BoolFlag{
-	Name:        "file, f",
-	Usage:       "Treat input as a file",
-	Destination: &File,
-}
-
-var Trim bool
-var TrimFlag = &cli.BoolFlag{
-	Name:        "trim, t",
-	Usage:       "Trim input",
-	Destination: &Trim,
-}
-
 // Force force functionality without asking.
 var Force bool
 
 // ForceFlag turns on/off force functionality.
 var ForceFlag = &cli.BoolFlag{
-	Name:        "force, f",
+	Name:        "force",
+	Aliases:     []string{"f"},
 	Usage:       "Perform action without further prompt. Use with care!",
 	Destination: &Force,
 }
@@ -67,7 +57,8 @@ var Chaos bool
 
 // ChaosFlag turns on/off chaos functionality.
 var ChaosFlag = &cli.BoolFlag{
-	Name:        "chaos, C",
+	Name:        "chaos",
+	Aliases:     []string{"C"},
 	Usage:       "Proceed with uncommitted recipes changes. Use with care!",
 	Destination: &Chaos,
 }
@@ -77,24 +68,29 @@ var Tty bool
 
 // TtyFlag turns on/off tty mode.
 var TtyFlag = &cli.BoolFlag{
-	Name:        "tty, T",
+	Name:        "tty",
+	Aliases:     []string{"T"},
 	Usage:       "Disables TTY mode to run this command from a script.",
 	Destination: &Tty,
 }
 
-var NoInput bool
+var (
-var NoInputFlag = &cli.BoolFlag{
+	NoInput     bool
-	Name:        "no-input, n",
+	NoInputFlag = &cli.BoolFlag{
+		Name:        "no-input",
+		Aliases:     []string{"n"},
 		Usage:       "Toggle non-interactive mode",
 		Destination: &NoInput,
 	}
+)
 
 // Debug stores the variable from DebugFlag.
 var Debug bool
 
 // DebugFlag turns on/off verbose logging down to the DEBUG level.
 var DebugFlag = &cli.BoolFlag{
-	Name:        "debug, d",
+	Name:        "debug",
+	Aliases:     []string{"d"},
 	Destination: &Debug,
 	Usage:       "Show DEBUG messages",
 }
@@ -104,27 +100,19 @@ var Offline bool
 
 // DebugFlag turns on/off offline mode.
 var OfflineFlag = &cli.BoolFlag{
-	Name:        "offline, o",
+	Name:        "offline",
+	Aliases:     []string{"o"},
 	Destination: &Offline,
 	Usage:       "Prefer offline & filesystem access when possible",
 }
 
-// ReleaseNotes stores the variable from ReleaseNotesFlag.
-var ReleaseNotes bool
-
-// ReleaseNotesFlag turns on/off printing only release notes when upgrading.
-var ReleaseNotesFlag = &cli.BoolFlag{
-	Name:        "releasenotes, r",
-	Destination: &ReleaseNotes,
-	Usage:       "Only show release notes",
-}
-
 // MachineReadable stores the variable from MachineReadableFlag
 var MachineReadable bool
 
 // MachineReadableFlag turns on/off machine readable output where supported
 var MachineReadableFlag = &cli.BoolFlag{
-	Name:        "machine, m",
+	Name:        "machine",
+	Aliases:     []string{"m"},
 	Destination: &MachineReadable,
 	Usage:       "Output in a machine-readable format (where supported)",
 }
@@ -134,133 +122,185 @@ var RC bool
 
 // RCFlag chooses the latest release candidate for install
 var RCFlag = &cli.BoolFlag{
-	Name:        "rc, r",
+	Name:        "rc",
+	Aliases:     []string{"c"},
 	Destination: &RC,
 	Usage:       "Install the latest release candidate",
 }
 
-var Major bool
+var (
-var MajorFlag = &cli.BoolFlag{
+	Major     bool
-	Name:        "major, x",
+	MajorFlag = &cli.BoolFlag{
+		Name:        "major",
+		Aliases:     []string{"x"},
 		Usage:       "Increase the major part of the version",
 		Destination: &Major,
 	}
+)
 
-var Minor bool
+var (
-var MinorFlag = &cli.BoolFlag{
+	Minor     bool
-	Name:        "minor, y",
+	MinorFlag = &cli.BoolFlag{
+		Name:        "minor",
+		Aliases:     []string{"y"},
 		Usage:       "Increase the minor part of the version",
 		Destination: &Minor,
 	}
+)
 
-var Patch bool
+var (
-var PatchFlag = &cli.BoolFlag{
+	Patch     bool
-	Name:        "patch, z",
+	PatchFlag = &cli.BoolFlag{
+		Name:        "patch",
+		Aliases:     []string{"z"},
 		Usage:       "Increase the patch part of the version",
 		Destination: &Patch,
 	}
+)
 
-var Dry bool
+var (
-var DryFlag = &cli.BoolFlag{
+	Dry     bool
-	Name:        "dry-run, r",
+	DryFlag = &cli.BoolFlag{
+		Name:        "dry-run",
+		Aliases:     []string{"r"},
 		Usage:       "Only reports changes that would be made",
 		Destination: &Dry,
 	}
+)
 
-var Publish bool
+var (
-var PublishFlag = &cli.BoolFlag{
+	Publish     bool
-	Name:        "publish, p",
+	PublishFlag = &cli.BoolFlag{
+		Name:        "publish",
+		Aliases:     []string{"p"},
 		Usage:       "Publish changes to git.coopcloud.tech",
 		Destination: &Publish,
 	}
+)
 
-var Domain string
+var (
-var DomainFlag = &cli.StringFlag{
+	Domain     string
-	Name:        "domain, D",
+	DomainFlag = &cli.StringFlag{
+		Name:        "domain",
+		Aliases:     []string{"D"},
 		Value:       "",
 		Usage:       "Choose a domain name",
 		Destination: &Domain,
 	}
+)
 
-var NewAppServer string
+var (
-var NewAppServerFlag = &cli.StringFlag{
+	NewAppServer     string
-	Name:        "server, s",
+	NewAppServerFlag = &cli.StringFlag{
+		Name:        "server",
+		Aliases:     []string{"s"},
 		Value:       "",
 		Usage:       "Show apps of a specific server",
 		Destination: &NewAppServer,
 	}
+)
 
-var NoDomainChecks bool
+var (
-var NoDomainChecksFlag = &cli.BoolFlag{
+	NoDomainChecks     bool
-	Name:        "no-domain-checks, D",
+	NoDomainChecksFlag = &cli.BoolFlag{
+		Name:        "no-domain-checks",
+		Aliases:     []string{"D"},
 		Usage:       "Disable app domain sanity checks",
 		Destination: &NoDomainChecks,
 	}
+)
 
-var StdErrOnly bool
+var (
-var StdErrOnlyFlag = &cli.BoolFlag{
+	StdErrOnly     bool
-	Name:        "stderr, s",
+	StdErrOnlyFlag = &cli.BoolFlag{
+		Name:        "stderr",
+		Aliases:     []string{"s"},
 		Usage:       "Only tail stderr",
 		Destination: &StdErrOnly,
 	}
+)
 
-var SinceLogs string
+var (
-var SinceLogsFlag = &cli.StringFlag{
+	SinceLogs     string
-	Name:        "since, S",
+	SinceLogsFlag = &cli.StringFlag{
+		Name:        "since",
+		Aliases:     []string{"S"},
 		Value:       "",
 		Usage:       "tail logs since YYYY-MM-DDTHH:MM:SSZ",
 		Destination: &SinceLogs,
 	}
+)
 
-var DontWaitConverge bool
+var (
-var DontWaitConvergeFlag = &cli.BoolFlag{
+	DontWaitConverge     bool
-	Name:        "no-converge-checks, c",
+	DontWaitConvergeFlag = &cli.BoolFlag{
+		Name:        "no-converge-checks",
+		Aliases:     []string{"c"},
 		Usage:       "Don't wait for converge logic checks",
 		Destination: &DontWaitConverge,
 	}
+)
 
-var Watch bool
+var (
-var WatchFlag = &cli.BoolFlag{
+	Watch     bool
-	Name:        "watch, w",
+	WatchFlag = &cli.BoolFlag{
+		Name:        "watch",
+		Aliases:     []string{"w"},
 		Usage:       "Watch status by polling repeatedly",
 		Destination: &Watch,
 	}
+)
 
-var OnlyErrors bool
+var (
-var OnlyErrorFlag = &cli.BoolFlag{
+	OnlyErrors    bool
-	Name:        "errors, e",
+	OnlyErrorFlag = &cli.BoolFlag{
+		Name:        "errors",
+		Aliases:     []string{"e"},
 		Usage:       "Only show errors",
 		Destination: &OnlyErrors,
 	}
+)
 
-var SkipUpdates bool
+var (
-var SkipUpdatesFlag = &cli.BoolFlag{
+	SkipUpdates     bool
-	Name:        "skip-updates, s",
+	SkipUpdatesFlag = &cli.BoolFlag{
+		Name:        "skip-updates",
+		Aliases:     []string{"s"},
 		Usage:       "Skip updating recipe repositories",
 		Destination: &SkipUpdates,
 	}
+)
 
-var AllTags bool
+var (
-var AllTagsFlag = &cli.BoolFlag{
+	AllTags     bool
-	Name:        "all-tags, a",
+	AllTagsFlag = &cli.BoolFlag{
+		Name:        "all-tags",
+		Aliases:     []string{"a"},
 		Usage:       "List all tags, not just upgrades",
 		Destination: &AllTags,
 	}
+)
 
-var LocalCmd bool
+var (
-var LocalCmdFlag = &cli.BoolFlag{
+	LocalCmd     bool
-	Name:        "local, l",
+	LocalCmdFlag = &cli.BoolFlag{
+		Name:        "local",
+		Aliases:     []string{"l"},
 		Usage:       "Run command locally",
 		Destination: &LocalCmd,
 	}
+)
 
-var RemoteUser string
+var (
-var RemoteUserFlag = &cli.StringFlag{
+	RemoteUser     string
-	Name:        "user, u",
+	RemoteUserFlag = &cli.StringFlag{
+		Name:        "user",
+		Aliases:     []string{"u"},
 		Value:       "",
 		Usage:       "User to run command within a service context",
 		Destination: &RemoteUser,
 	}
+)
 
 // SubCommandBefore wires up pre-action machinery (e.g. --debug handling).
 func SubCommandBefore(c *cli.Context) error {

cli/internal/errors.go

@@ -4,7 +4,7 @@ import (
 	"os"
 
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // ShowSubcommandHelpAndError exits the program on error, logs the error to the

cli/internal/recipe.go

@@ -6,7 +6,7 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/AlecAivazis/survey/v2"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 	"github.com/sirupsen/logrus"
 )
 

cli/internal/validate.go

@@ -9,7 +9,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // ValidateRecipe ensures the recipe arg is valid.
@@ -120,9 +120,9 @@ func ValidateDomain(c *cli.Context) string {
 
 // ValidateSubCmdFlags ensures flag order conforms to correct order
 func ValidateSubCmdFlags(c *cli.Context) bool {
-	for argIdx, arg := range c.Args() {
+	for argIdx, arg := range c.Args().Slice() {
 		if !strings.HasPrefix(arg, "--") {
-			for _, flag := range c.Args()[argIdx:] {
+			for _, flag := range c.Args().Slice()[argIdx:] {
 				if strings.HasPrefix(flag, "--") {
 					return false
 				}

cli/recipe/diff.go

@@ -8,7 +8,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	gitPkg "coopcloud.tech/abra/pkg/git"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeDiffCommand = cli.Command{

cli/recipe/fetch.go

@@ -6,7 +6,7 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeFetchCommand = cli.Command{

cli/recipe/lint.go

@@ -9,7 +9,7 @@ import (
 	"coopcloud.tech/abra/pkg/lint"
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeLintCommand = cli.Command{

cli/recipe/list.go

@@ -10,7 +10,7 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var pattern string

cli/recipe/new.go

@@ -13,7 +13,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/git"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // recipeMetadata is the recipe metadata for the README.md

cli/recipe/recipe.go

@@ -1,7 +1,7 @@
 package recipe
 
 import (
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // RecipeCommand defines all recipe related sub-commands.
@@ -21,16 +21,16 @@ sure the recipe is in good working order and the config upgraded in a timely
 manner. Abra supports convenient automation for recipe maintainenace, see the
 "abra recipe upgrade", "abra recipe sync" and "abra recipe release" commands.
 `,
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		recipeFetchCommand,
+		&recipeFetchCommand,
-		recipeLintCommand,
+		&recipeLintCommand,
-		recipeListCommand,
+		&recipeListCommand,
-		recipeNewCommand,
+		&recipeNewCommand,
-		recipeReleaseCommand,
+		&recipeReleaseCommand,
-		recipeSyncCommand,
+		&recipeSyncCommand,
-		recipeUpgradeCommand,
+		&recipeUpgradeCommand,
-		recipeVersionCommand,
+		&recipeVersionCommand,
-		recipeResetCommand,
+		&recipeResetCommand,
-		recipeDiffCommand,
+		&recipeDiffCommand,
 	},
 }

cli/recipe/release.go

@@ -17,10 +17,10 @@ import (
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 	"github.com/go-git/go-git/v5"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeReleaseCommand = cli.Command{

cli/recipe/reset.go

@@ -8,7 +8,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"github.com/go-git/go-git/v5"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeResetCommand = cli.Command{

cli/recipe/sync.go

@@ -14,7 +14,7 @@ import (
 	"github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var recipeSyncCommand = cli.Command{

cli/recipe/upgrade.go

@@ -18,9 +18,9 @@ import (
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 type imgPin struct {

cli/recipe/version.go

@@ -10,7 +10,7 @@ import (
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"github.com/olekukonko/tablewriter"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 func sortServiceByName(versions [][]string) func(i, j int) bool {
@@ -54,9 +54,8 @@ var recipeVersionCommand = cli.Command{
 			logrus.Fatalf("%s has no catalogue published versions?", recipe.Name)
 		}
 
-		tableCols := []string{"version", "service", "image", "tag"}
-		aggregated_table := formatter.CreateTable(tableCols)
 		for i := len(recipeMeta.Versions) - 1; i >= 0; i-- {
+			tableCols := []string{"version", "service", "image", "tag"}
 			table := formatter.CreateTable(tableCols)
 			for version, meta := range recipeMeta.Versions[i] {
 				var versions [][]string
@@ -68,10 +67,11 @@ var recipeVersionCommand = cli.Command{
 
 				for _, version := range versions {
 					table.Append(version)
-					aggregated_table.Append(version)
 				}
 
-				if !internal.MachineReadable {
+				if internal.MachineReadable {
+					table.JSONRender()
+				} else {
 					table.SetAutoMergeCellsByColumnIndex([]int{0})
 					table.SetAlignment(tablewriter.ALIGN_LEFT)
 					table.Render()
@@ -79,9 +79,6 @@ var recipeVersionCommand = cli.Command{
 				}
 			}
 		}
-		if internal.MachineReadable {
-			aggregated_table.JSONRender()
-		}
 
 		return nil
 	},

cli/server/add.go

@@ -13,12 +13,13 @@ import (
 	"coopcloud.tech/abra/pkg/server"
 	sshPkg "coopcloud.tech/abra/pkg/ssh"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var local bool
 var localFlag = &cli.BoolFlag{
-	Name:        "local, l",
+	Name:        "local",
+	Aliases:     []string{"l"},
 	Usage:       "Use local server",
 	Destination: &local,
 }
@@ -53,7 +54,7 @@ func cleanUp(domainName string) {
 // Docker manages SSH connection details. These are stored to disk in
 // ~/.docker. Abra can manage this completely for the user, so it's an
 // implementation detail.
-func newContext(c *cli.Context, domainName string) error {
+func newContext(c *cli.Context, domainName, username, port string) error {
 	store := contextPkg.NewDefaultDockerContextStore()
 	contexts, err := store.Store.List()
 	if err != nil {
@@ -67,9 +68,9 @@ func newContext(c *cli.Context, domainName string) error {
 		}
 	}
 
-	logrus.Debugf("creating context with domain %s", domainName)
+	logrus.Debugf("creating context with domain %s, username %s and port %s", domainName, username, port)
 
-	if err := client.CreateContext(domainName); err != nil {
+	if err := client.CreateContext(domainName, username, port); err != nil {
 		return err
 	}
 
@@ -122,7 +123,7 @@ developer machine.
 	Before:    internal.SubCommandBefore,
 	ArgsUsage: "<domain>",
 	Action: func(c *cli.Context) error {
-		if len(c.Args()) > 0 && local || !internal.ValidateSubCmdFlags(c) {
+		if c.Args().Len() > 0 && local || !internal.ValidateSubCmdFlags(c) {
 			err := errors.New("cannot use <domain> and --local together")
 			internal.ShowSubcommandHelpAndError(c, err)
 		}
@@ -158,7 +159,12 @@ developer machine.
 			logrus.Fatal(err)
 		}
 
-		if err := newContext(c, domainName); err != nil {
+		hostConfig, err := sshPkg.GetHostConfig(domainName)
+		if err != nil {
+			logrus.Fatal(err)
+		}
+
+		if err := newContext(c, domainName, hostConfig.User, hostConfig.Port); err != nil {
 			logrus.Fatal(err)
 		}
 

cli/server/list.go

@@ -9,7 +9,7 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"github.com/docker/cli/cli/connhelper/ssh"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var problemsFilter bool

cli/server/prune.go

@@ -9,7 +9,7 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var allFilter bool

cli/server/remove.go

@@ -9,7 +9,7 @@ import (
 	"coopcloud.tech/abra/pkg/client"
 	"coopcloud.tech/abra/pkg/config"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 var serverRemoveCommand = cli.Command{

cli/server/server.go

@@ -1,7 +1,7 @@
 package server
 
 import (
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // ServerCommand defines the `abra server` command and its subcommands
@@ -9,10 +9,10 @@ var ServerCommand = cli.Command{
 	Name:    "server",
 	Aliases: []string{"s"},
 	Usage:   "Manage servers",
-	Subcommands: []cli.Command{
+	Subcommands: []*cli.Command{
-		serverAddCommand,
+		&serverAddCommand,
-		serverListCommand,
+		&serverListCommand,
-		serverRemoveCommand,
+		&serverRemoveCommand,
-		serverPruneCommand,
+		&serverPruneCommand,
 	},
 }

cli/updater/updater.go

@@ -21,24 +21,28 @@ import (
 	dockerclient "github.com/docker/docker/client"
 
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 const SERVER = "localhost"
 
-var majorUpdate bool
+var (
-var majorFlag = &cli.BoolFlag{
+	majorUpdate bool
-	Name:        "major, m",
+	majorFlag   = &cli.BoolFlag{
+		Name:        "major",
+		Aliases:     []string{"m"},
 		Usage:       "Also check for major updates",
 		Destination: &majorUpdate,
 	}
 
-var updateAll bool
+	updateAll bool
-var allFlag = &cli.BoolFlag{
+	allFlag   = &cli.BoolFlag{
-	Name:        "all, a",
+		Name:        "all",
+		Aliases:     []string{"a"},
 		Usage:       "Update all deployed apps",
 		Destination: &updateAll,
 	}
+)
 
 // Notify checks for available upgrades
 var Notify = cli.Command{
@@ -271,7 +275,8 @@ func getDeployedVersion(cl *dockerclient.Client, stackName string, recipeName st
 // than the deployed version. It only includes major upgrades if the "--major"
 // flag is set.
 func getAvailableUpgrades(cl *dockerclient.Client, stackName string, recipeName string,
-	deployedVersion string) ([]string, error) {
+	deployedVersion string,
+) ([]string, error) {
 	catl, err := recipe.ReadRecipeCatalogue(internal.Offline)
 	if err != nil {
 		return nil, err
@@ -429,7 +434,8 @@ func tryUpgrade(cl *dockerclient.Client, stackName, recipeName string) error {
 
 // upgrade performs all necessary steps to upgrade an app.
 func upgrade(cl *dockerclient.Client, stackName, recipeName,
-	upgradeVersion string) error {
+	upgradeVersion string,
+) error {
 	env, err := getEnv(cl, stackName)
 	if err != nil {
 		return err
@@ -474,9 +480,9 @@ func newAbraApp(version, commit string) *cli.App {
                          |_|
 `,
 		Version: fmt.Sprintf("%s-%s", version, commit[:7]),
-		Commands: []cli.Command{
+		Commands: []*cli.Command{
-			Notify,
+			&Notify,
-			UpgradeApp,
+			&UpgradeApp,
 		},
 	}
 

go.mod

@@ -3,131 +3,120 @@ module coopcloud.tech/abra
 go 1.21
 
 require (
-	coopcloud.tech/tagcmp v0.0.0-20230809071031-eb3e7758d4eb
+	coopcloud.tech/tagcmp v0.0.0-20211103052201-885b22f77d52
 	git.coopcloud.tech/coop-cloud/godotenv v1.5.2-0.20231130100509-01bff8284355
 	github.com/AlecAivazis/survey/v2 v2.3.7
 	github.com/Gurpartap/logrus-stack v0.0.0-20170710170904-89c00d8a28f4
-	github.com/distribution/distribution v2.8.3+incompatible
+	github.com/docker/cli v24.0.7+incompatible
-	github.com/docker/cli v26.1.4+incompatible
+	github.com/docker/distribution v2.8.3+incompatible
-	github.com/docker/docker v26.1.4+incompatible
+	github.com/docker/docker v24.0.7+incompatible
 	github.com/docker/go-units v0.5.0
-	github.com/go-git/go-git/v5 v5.12.0
+	github.com/go-git/go-git/v5 v5.10.0
-	github.com/google/go-cmp v0.6.0
+	github.com/google/go-cmp v0.5.9
 	github.com/moby/sys/signal v0.7.0
 	github.com/moby/term v0.5.0
 	github.com/olekukonko/tablewriter v0.0.5
 	github.com/pkg/errors v0.9.1
-	github.com/schollz/progressbar/v3 v3.14.4
+	github.com/schollz/progressbar/v3 v3.14.1
 	github.com/sirupsen/logrus v1.9.3
 	gotest.tools/v3 v3.5.1
 )
 
 require (
 	dario.cat/mergo v1.0.0 // indirect
-	github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
+	github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
-	github.com/BurntSushi/toml v1.4.0 // indirect
+	github.com/BurntSushi/toml v1.3.2 // indirect
-	github.com/Microsoft/go-winio v0.6.2 // indirect
+	github.com/Microsoft/go-winio v0.6.1 // indirect
-	github.com/ProtonMail/go-crypto v1.0.0 // indirect
+	github.com/Microsoft/hcsshim v0.9.2 // indirect
+	github.com/ProtonMail/go-crypto v0.0.0-20230828082145-3c4c8a2d2371 // indirect
+	github.com/acomagu/bufpipe v1.0.4 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
+	github.com/cespare/xxhash/v2 v2.2.0 // indirect
-	github.com/cespare/xxhash/v2 v2.3.0 // indirect
+	github.com/cloudflare/circl v1.3.3 // indirect
-	github.com/cloudflare/circl v1.3.9 // indirect
+	github.com/cpuguy83/go-md2man/v2 v2.0.3 // indirect
-	github.com/containerd/log v0.1.0 // indirect
+	github.com/cyphar/filepath-securejoin v0.2.4 // indirect
-	github.com/cpuguy83/go-md2man/v2 v2.0.4 // indirect
-	github.com/cyphar/filepath-securejoin v0.2.5 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/distribution/reference v0.6.0 // indirect
+	github.com/distribution/reference v0.5.0 // indirect
-	github.com/docker/distribution v2.7.1+incompatible // indirect
 	github.com/docker/go v1.5.1-1.0.20160303222718-d30aec9fd63c // indirect
-	github.com/docker/go-connections v0.5.0 // indirect
+	github.com/docker/go-connections v0.4.0 // indirect
 	github.com/docker/go-metrics v0.0.1 // indirect
 	github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
 	github.com/emirpasic/gods v1.18.1 // indirect
-	github.com/felixge/httpsnoop v1.0.4 // indirect
 	github.com/ghodss/yaml v1.0.0 // indirect
 	github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
 	github.com/go-git/go-billy/v5 v5.5.0 // indirect
-	github.com/go-logr/logr v1.4.2 // indirect
-	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
-	github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 // indirect
+	github.com/golang/protobuf v1.5.3 // indirect
 	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
-	github.com/inconshreveable/mousetrap v1.1.0 // indirect
+	github.com/imdario/mergo v0.3.12 // indirect
+	github.com/inconshreveable/mousetrap v1.0.0 // indirect
 	github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
 	github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
 	github.com/kevinburke/ssh_config v1.2.0 // indirect
-	github.com/klauspost/compress v1.17.9 // indirect
+	github.com/klauspost/compress v1.14.2 // indirect
-	github.com/mattn/go-colorable v0.1.13 // indirect
+	github.com/mattn/go-colorable v0.1.12 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
-	github.com/mattn/go-runewidth v0.0.15 // indirect
+	github.com/mattn/go-runewidth v0.0.14 // indirect
-	github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d // indirect
+	github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect
-	github.com/miekg/pkcs11 v1.1.1 // indirect
+	github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
+	github.com/miekg/pkcs11 v1.0.3 // indirect
 	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db // indirect
-	github.com/mitchellh/mapstructure v1.5.0 // indirect
+	github.com/mitchellh/mapstructure v1.4.3 // indirect
-	github.com/moby/docker-image-spec v1.3.1 // indirect
-	github.com/moby/sys/user v0.1.0 // indirect
 	github.com/morikuni/aec v1.0.0 // indirect
 	github.com/opencontainers/go-digest v1.0.0 // indirect
-	github.com/opencontainers/runc v1.1.13 // indirect
+	github.com/opencontainers/runc v1.1.0 // indirect
 	github.com/pjbgf/sha1cd v0.3.0 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/prometheus/client_model v0.6.1 // indirect
+	github.com/prometheus/client_model v0.3.0 // indirect
-	github.com/prometheus/common v0.54.0 // indirect
+	github.com/prometheus/common v0.42.0 // indirect
-	github.com/prometheus/procfs v0.15.1 // indirect
+	github.com/prometheus/procfs v0.10.1 // indirect
-	github.com/rivo/uniseg v0.4.7 // indirect
+	github.com/rivo/uniseg v0.4.4 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
-	github.com/skeema/knownhosts v1.2.2 // indirect
+	github.com/skeema/knownhosts v1.2.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
+	github.com/urfave/cli/v2 v2.27.1 // indirect
 	github.com/xanzy/ssh-agent v0.3.3 // indirect
 	github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect
 	github.com/xeipuuv/gojsonschema v1.2.0 // indirect
-	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.52.0 // indirect
+	github.com/xrash/smetrics v0.0.0-20231213231151-1d8dd44e695e // indirect
-	go.opentelemetry.io/otel v1.27.0 // indirect
+	golang.org/x/crypto v0.14.0 // indirect
-	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.27.0 // indirect
+	golang.org/x/mod v0.12.0 // indirect
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.27.0 // indirect
+	golang.org/x/net v0.17.0 // indirect
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0 // indirect
+	golang.org/x/sync v0.3.0 // indirect
-	go.opentelemetry.io/otel/metric v1.27.0 // indirect
+	golang.org/x/term v0.14.0 // indirect
-	go.opentelemetry.io/otel/sdk v1.27.0 // indirect
+	golang.org/x/text v0.13.0 // indirect
-	go.opentelemetry.io/otel/sdk/metric v1.27.0 // indirect
+	golang.org/x/time v0.0.0-20200630173020-3af7569d3a1e // indirect
-	go.opentelemetry.io/otel/trace v1.27.0 // indirect
+	golang.org/x/tools v0.13.0 // indirect
-	go.opentelemetry.io/proto/otlp v1.3.1 // indirect
+	google.golang.org/protobuf v1.30.0 // indirect
-	golang.org/x/crypto v0.24.0 // indirect
-	golang.org/x/net v0.26.0 // indirect
-	golang.org/x/sync v0.7.0 // indirect
-	golang.org/x/term v0.21.0 // indirect
-	golang.org/x/text v0.16.0 // indirect
-	golang.org/x/time v0.5.0 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20240617180043-68d350f18fd4 // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20240617180043-68d350f18fd4 // indirect
-	google.golang.org/grpc v1.64.0 // indirect
-	google.golang.org/protobuf v1.34.2 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
 require (
+	github.com/AdaLogics/go-fuzz-headers v0.0.0-20230106234847-43070de90fa1 // indirect
 	github.com/buger/goterm v1.0.4
-	github.com/containerd/containerd v1.7.18 // indirect
+	github.com/containerd/containerd v1.5.9 // indirect
 	github.com/containers/image v3.0.2+incompatible
 	github.com/containers/storage v1.38.2 // indirect
 	github.com/decentral1se/passgen v1.0.1
-	github.com/docker/docker-credential-helpers v0.8.2 // indirect
+	github.com/docker/docker-credential-helpers v0.6.4 // indirect
 	github.com/facebookgo/stack v0.0.0-20160209184415-751773369052 // indirect
-	github.com/fvbommel/sortorder v1.1.0 // indirect
+	github.com/fvbommel/sortorder v1.0.2 // indirect
 	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
-	github.com/gorilla/mux v1.8.1 // indirect
+	github.com/gorilla/mux v1.8.0 // indirect
-	github.com/hashicorp/go-retryablehttp v0.7.7
+	github.com/hashicorp/go-retryablehttp v0.7.5
-	github.com/moby/patternmatcher v0.6.0 // indirect
+	github.com/klauspost/pgzip v1.2.6
+	github.com/moby/patternmatcher v0.5.0 // indirect
 	github.com/moby/sys/sequential v0.5.0 // indirect
-	github.com/opencontainers/image-spec v1.1.0 // indirect
+	github.com/opencontainers/image-spec v1.0.3-0.20211202193544-a5463b7f9c84 // indirect
-	github.com/prometheus/client_golang v1.19.1 // indirect
+	github.com/prometheus/client_golang v1.16.0 // indirect
-	github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
+	github.com/sergi/go-diff v1.2.0 // indirect
-	github.com/spf13/cobra v1.8.1 // indirect
+	github.com/spf13/cobra v1.3.0 // indirect
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.8.4
 	github.com/theupdateframework/notary v0.7.0 // indirect
-	github.com/urfave/cli v1.22.15
+	github.com/urfave/cli v1.22.9
-	github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect
+	github.com/xeipuuv/gojsonpointer v0.0.0-20190809123943-df4f5c81cb3b // indirect
-	golang.org/x/sys v0.21.0
+	golang.org/x/sys v0.14.0
 )

pkg/autocomplete/autocomplete.go

@@ -6,7 +6,7 @@ import (
 	"coopcloud.tech/abra/pkg/config"
 	"coopcloud.tech/abra/pkg/recipe"
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v2"
 )
 
 // AppNameComplete copletes app names.

pkg/client/context.go

@@ -14,16 +14,19 @@ import (
 
 type Context = contextStore.Metadata
 
-// CreateContext creates a new Docker context.
+func CreateContext(contextName string, user string, port string) error {
-func CreateContext(contextName string) error {
+	host := contextName
-	host := fmt.Sprintf("ssh://%s", contextName)
+	if user != "" {
-
+		host = fmt.Sprintf("%s@%s", user, host)
+	}
+	if port != "" {
+		host = fmt.Sprintf("%s:%s", host, port)
+	}
+	host = fmt.Sprintf("ssh://%s", host)
 	if err := createContext(contextName, host); err != nil {
 		return err
 	}
-
 	logrus.Debugf("created the %s context", contextName)
-
 	return nil
 }
 

pkg/client/registry.go

@@ -6,7 +6,7 @@ import (
 
 	"github.com/containers/image/docker"
 	"github.com/containers/image/types"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 )
 
 // GetRegistryTags retrieves all tags of an image from a container registry.

pkg/client/volumes.go

@@ -2,17 +2,15 @@ package client
 
 import (
 	"context"
-	"fmt"
-	"time"
 
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/api/types/volume"
 	"github.com/docker/docker/client"
-	"github.com/sirupsen/logrus"
 )
 
 func GetVolumes(cl *client.Client, ctx context.Context, server string, fs filters.Args) ([]*volume.Volume, error) {
-	volumeListOKBody, err := cl.VolumeList(ctx, volume.ListOptions{Filters: fs})
+	volumeListOptions := volume.ListOptions{fs}
+	volumeListOKBody, err := cl.VolumeList(ctx, volumeListOptions)
 	volumeList := volumeListOKBody.Volumes
 	if err != nil {
 		return volumeList, err
@@ -31,32 +29,13 @@ func GetVolumeNames(volumes []*volume.Volume) []string {
 	return volumeNames
 }
 
-func RemoveVolumes(cl *client.Client, ctx context.Context, volumeNames []string, force bool, retries int) error {
+func RemoveVolumes(cl *client.Client, ctx context.Context, server string, volumeNames []string, force bool) error {
 	for _, volName := range volumeNames {
-		err := retryFunc(5, func() error {
+		err := cl.VolumeRemove(ctx, volName, force)
-			return cl.VolumeRemove(context.Background(), volName, force)
-		})
 		if err != nil {
-			return fmt.Errorf("volume %s: %s", volName, err)
+			return err
 		}
 	}
-	return nil
-}
 
-// retryFunc retries the given function for the given retries. After the nth
-// retry it waits (n + 1)^2 seconds before the next retry (starting with n=0).
-// It returns an error if the function still failed after the last retry.
-func retryFunc(retries int, fn func() error) error {
-	for i := 0; i < retries; i++ {
-		err := fn()
-		if err == nil {
 	return nil
 }
-		if i+1 < retries {
-			sleep := time.Duration(i+1) * time.Duration(i+1)
-			logrus.Infof("%s: waiting %d seconds before next retry", err, sleep)
-			time.Sleep(sleep * time.Second)
-		}
-	}
-	return fmt.Errorf("%d retries failed", retries)
-}

pkg/compose/compose.go

@@ -11,8 +11,8 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"coopcloud.tech/abra/pkg/upstream/stack"
 	loader "coopcloud.tech/abra/pkg/upstream/stack"
-	"github.com/distribution/reference"
 	composetypes "github.com/docker/cli/cli/compose/types"
+	"github.com/docker/distribution/reference"
 	"github.com/sirupsen/logrus"
 )
 

pkg/config/app.go

@@ -69,9 +69,9 @@ func (a App) StackName() string {
 func StackName(appName string) string {
 	stackName := SanitiseAppName(appName)
 
-	if len(stackName) > MAX_SANITISED_APP_NAME_LENGTH {
+	if len(stackName) > 45 {
-		logrus.Debugf("trimming %s to %s to avoid runtime limits", stackName, stackName[:MAX_SANITISED_APP_NAME_LENGTH])
+		logrus.Debugf("trimming %s to %s to avoid runtime limits", stackName, stackName[:45])
-		stackName = stackName[:MAX_SANITISED_APP_NAME_LENGTH]
+		stackName = stackName[:45]
 	}
 
 	return stackName

pkg/config/env.go

@@ -36,9 +36,6 @@ var REPOS_BASE_URL = "https://git.coopcloud.tech/coop-cloud"
 var CATALOGUE_JSON_REPO_NAME = "recipes-catalogue-json"
 var SSH_URL_TEMPLATE = "ssh://git@git.coopcloud.tech:2222/coop-cloud/%s.git"
 
-const MAX_SANITISED_APP_NAME_LENGTH = 45
-const MAX_DOCKER_SECRET_LENGTH = 64
-
 var BackupbotLabel = "coop-cloud.backupbot.enabled"
 
 // envVarModifiers is a list of env var modifier strings. These are added to

pkg/container/container.go

@@ -8,7 +8,6 @@ import (
 	"coopcloud.tech/abra/pkg/formatter"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/docker/docker/api/types"
-	containerTypes "github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/client"
 	"github.com/sirupsen/logrus"
@@ -18,7 +17,7 @@ import (
 // count of containers does not match 1, then a prompt is presented to let the
 // user choose. A count of 0 is handled gracefully.
 func GetContainer(c context.Context, cl *client.Client, filters filters.Args, noInput bool) (types.Container, error) {
-	containerOpts := containerTypes.ListOptions{Filters: filters}
+	containerOpts := types.ContainerListOptions{Filters: filters}
 	containers, err := cl.ContainerList(c, containerOpts)
 	if err != nil {
 		return types.Container{}, err

pkg/lint/recipe.go

@@ -10,7 +10,7 @@ import (
 	"coopcloud.tech/abra/pkg/recipe"
 	recipePkg "coopcloud.tech/abra/pkg/recipe"
 	"coopcloud.tech/tagcmp"
-	"github.com/distribution/reference"
+	"github.com/docker/distribution/reference"
 	"github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/sirupsen/logrus"
@@ -115,13 +115,6 @@ var LintRules = map[string][]LintRule{
 			HowToResolve: "upload your recipe to git.coopcloud.tech/coop-cloud/...",
 			Function:     LintHasRecipeRepo,
 		},
-		{
-			Ref:          "R015",
-			Level:        "warn",
-			Description:  "long secret names",
-			HowToResolve: "reduce length of secret names to 12 chars",
-			Function:     LintSecretLengths,
-		},
 	},
 	"error": {
 		{
@@ -408,16 +401,6 @@ func LintHasRecipeRepo(recipe recipe.Recipe) (bool, error) {
 	return true, nil
 }
 
-func LintSecretLengths(recipe recipe.Recipe) (bool, error) {
-	for name := range recipe.Config.Secrets {
-		if len(name) > 12 {
-			return false, fmt.Errorf("secret %s is longer than 12 characters", name)
-		}
-	}
-
-	return true, nil
-}
-
 func LintValidTags(recipe recipe.Recipe) (bool, error) {
 	recipeDir := path.Join(config.RECIPES_DIR, recipe.Name)
 

pkg/recipe/recipe.go

@@ -22,8 +22,8 @@ import (
 	loader "coopcloud.tech/abra/pkg/upstream/stack"
 	"coopcloud.tech/abra/pkg/web"
 	"coopcloud.tech/tagcmp"
-	"github.com/distribution/reference"
 	composetypes "github.com/docker/cli/cli/compose/types"
+	"github.com/docker/distribution/reference"
 	"github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/sirupsen/logrus"
@@ -945,7 +945,6 @@ func GetRecipeVersions(recipeName string, offline bool) (RecipeVersions, error)
 	if err != nil {
 		return versions, err
 	}
-
 	sortRecipeVersions(versions)
 
 	logrus.Debugf("collected %s for %s", versions, recipeName)

pkg/secret/secret.go

@@ -89,7 +89,7 @@ func ReadSecretsConfig(appEnvPath string, composeFiles []string, stackName strin
 	appEnv["STACK_NAME"] = stackName
 
 	opts := stack.Deploy{Composefiles: composeFiles}
-	composeConfig, err := loader.LoadComposefile(opts, appEnv)
+	config, err := loader.LoadComposefile(opts, appEnv)
 	if err != nil {
 		return nil, err
 	}
@@ -100,7 +100,7 @@ func ReadSecretsConfig(appEnvPath string, composeFiles []string, stackName strin
 	}
 
 	var enabledSecrets []string
-	for _, service := range composeConfig.Services {
+	for _, service := range config.Services {
 		for _, secret := range service.Secrets {
 			enabledSecrets = append(enabledSecrets, secret.Source)
 		}
@@ -112,7 +112,7 @@ func ReadSecretsConfig(appEnvPath string, composeFiles []string, stackName strin
 	}
 
 	secretValues := map[string]Secret{}
-	for secretId, secretConfig := range composeConfig.Secrets {
+	for secretId, secretConfig := range config.Secrets {
 		if string(secretConfig.Name[len(secretConfig.Name)-1]) == "_" {
 			return nil, fmt.Errorf("missing version for secret? (%s)", secretId)
 		}
@@ -126,10 +126,6 @@ func ReadSecretsConfig(appEnvPath string, composeFiles []string, stackName strin
 		secretVersion := secretConfig.Name[lastIdx+1:]
 		value := Secret{Version: secretVersion, RemoteName: secretConfig.Name}
 
-		if len(value.RemoteName) > config.MAX_DOCKER_SECRET_LENGTH {
-			return nil, fmt.Errorf("secret %s is > %d chars when combined with %s", secretId, config.MAX_DOCKER_SECRET_LENGTH, stackName)
-		}
-
 		// Check if the length modifier is set for this secret.
 		for envName, modifierValues := range appModifiers {
 			// configWithoutEnv contains the raw name as defined in the compose.yaml

pkg/secret/secret_test.go

@@ -28,12 +28,3 @@ func TestReadSecretsConfig(t *testing.T) {
 	assert.Equal(t, "v2", secretsFromConfig["test_pass_three"].Version)
 	assert.Equal(t, 0, secretsFromConfig["test_pass_three"].Length)
 }
-
-func TestReadSecretsConfigWithLongDomain(t *testing.T) {
-	composeFiles := []string{"./testdir/compose.yaml"}
-	_, err := ReadSecretsConfig("./testdir/.env.sample", composeFiles, "should_break_on_forty_eight_char_stack_nameeeeee")
-	if err == nil {
-		t.Fatal("expected failure, stack name is too long")
-	}
-	assert.Contains(t, err.Error(), "is > 64 chars")
-}

pkg/ssh/ssh.go

@@ -2,14 +2,73 @@ package ssh
 
 import (
 	"fmt"
+	"os/exec"
 	"strings"
+
+	"github.com/sirupsen/logrus"
 )
 
+// HostConfig is a SSH host config.
+type HostConfig struct {
+	Host         string
+	IdentityFile string
+	Port         string
+	User         string
+}
+
+// String presents a human friendly output for the HostConfig.
+func (h HostConfig) String() string {
+	return fmt.Sprintf(
+		"{host: %s, username: %s, port: %s, identityfile: %s}",
+		h.Host,
+		h.User,
+		h.Port,
+		h.IdentityFile,
+	)
+}
+
+// GetHostConfig retrieves a ~/.ssh/config config for a host using /usr/bin/ssh
+// directly. We therefore maintain consistent interop with this standard
+// tooling. This is useful because SSH confuses a lot of people and having to
+// learn how two tools (`ssh` and `abra`) handle SSH connection details instead
+// of one (just `ssh`) is Not Cool. Here's to less bug reports on this topic!
+func GetHostConfig(hostname string) (HostConfig, error) {
+	var hostConfig HostConfig
+
+	out, err := exec.Command("ssh", "-G", hostname).Output()
+	if err != nil {
+		return hostConfig, err
+	}
+
+	for _, line := range strings.Split(string(out), "\n") {
+		entries := strings.Split(line, " ")
+		for idx, entry := range entries {
+			if entry == "hostname" {
+				hostConfig.Host = entries[idx+1]
+			}
+			if entry == "user" {
+				hostConfig.User = entries[idx+1]
+			}
+			if entry == "port" {
+				hostConfig.Port = entries[idx+1]
+			}
+			if entry == "identityfile" {
+				if hostConfig.IdentityFile == "" {
+					hostConfig.IdentityFile = entries[idx+1]
+				}
+			}
+		}
+	}
+
+	logrus.Debugf("retrieved ssh config for %s: %s", hostname, hostConfig.String())
+
+	return hostConfig, nil
+}
+
 // Fatal is a error output wrapper which aims to make SSH failures easier to
 // parse through re-wording.
 func Fatal(hostname string, err error) error {
 	out := err.Error()
-
 	if strings.Contains(out, "Host key verification failed.") {
 		return fmt.Errorf("SSH host key verification failed for %s", hostname)
 	} else if strings.Contains(out, "Could not resolve hostname") {
@@ -20,7 +79,7 @@ func Fatal(hostname string, err error) error {
 		return fmt.Errorf("ssh auth: permission denied for %s", hostname)
 	} else if strings.Contains(out, "Network is unreachable") {
 		return fmt.Errorf("unable to connect to %s, network is unreachable?", hostname)
-	}
+	} else {
-
 		return err
 	}
+}

pkg/upstream/commandconn/connection.go

@@ -16,12 +16,12 @@ import (
 // GetConnectionHelper returns Docker-specific connection helper for the given URL.
 // GetConnectionHelper returns nil without error when no helper is registered for the scheme.
 //
-// ssh://<host> URL requires Docker 18.09 or later on the remote host.
+// ssh://<user>@<host> URL requires Docker 18.09 or later on the remote host.
 func GetConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error) {
-	return getConnectionHelper(daemonURL)
+	return getConnectionHelper(daemonURL, []string{"-o ConnectTimeout=60"})
 }
 
-func getConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error) {
+func getConnectionHelper(daemonURL string, sshFlags []string) (*connhelper.ConnectionHelper, error) {
 	url, err := url.Parse(daemonURL)
 	if err != nil {
 		return nil, err
@@ -35,7 +35,7 @@ func getConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error)
 
 		return &connhelper.ConnectionHelper{
 			Dialer: func(ctx context.Context, network, addr string) (net.Conn, error) {
-				return New(ctx, "ssh", ctxConnDetails.Args("docker", "system", "dial-stdio")...)
+				return New(ctx, "ssh", append(sshFlags, ctxConnDetails.Args("docker", "system", "dial-stdio")...)...)
 			},
 			Host: "http://docker.example.com",
 		}, nil
@@ -45,7 +45,6 @@ func getConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error)
 	return nil, err
 }
 
-// NewConnectionHelper creates new connection helper for a remote docker daemon.
 func NewConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error) {
 	helper, err := GetConnectionHelper(daemonURL)
 	if err != nil {
@@ -74,7 +73,6 @@ func getDockerEndpoint(host string) (docker.Endpoint, error) {
 	return ep, nil
 }
 
-// GetDockerEndpointMetadataAndTLS retrieves the docker endpoint and TLS info for a remote host.
 func GetDockerEndpointMetadataAndTLS(host string) (docker.EndpointMeta, *dCliContextStore.EndpointTLSData, error) {
 	ep, err := getDockerEndpoint(host)
 	if err != nil {

pkg/upstream/container/tty.go

@@ -9,7 +9,7 @@ import (
 	"time"
 
 	"github.com/docker/cli/cli/command"
-	"github.com/docker/docker/api/types/container"
+	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/client"
 	apiclient "github.com/docker/docker/client"
 	"github.com/moby/sys/signal"
@@ -22,7 +22,7 @@ func resizeTtyTo(ctx context.Context, client client.ContainerAPIClient, id strin
 		return nil
 	}
 
-	options := container.ResizeOptions{
+	options := types.ResizeOptions{
 		Height: height,
 		Width:  width,
 	}

pkg/upstream/stack/stack.go

@@ -233,7 +233,7 @@ func validateExternalNetworks(ctx context.Context, client dockerClient.NetworkAP
 		network, err := client.NetworkInspect(ctx, networkName, types.NetworkInspectOptions{})
 		switch {
 		case dockerClient.IsErrNotFound(err):
-			return errors.Errorf("network %q is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed, which you can do by running this on the server: docker network create -d overlay proxy", networkName)
+			return errors.Errorf("network %q is declared as external, but could not be found. You need to create a swarm-scoped network before the stack is deployed", networkName)
 		case err != nil:
 			return err
 		case network.Scope != "swarm":

scripts/installer/installer

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-ABRA_VERSION="0.9.0-beta"
+ABRA_VERSION="0.8.1-beta"
 ABRA_RELEASE_URL="https://git.coopcloud.tech/api/v1/repos/coop-cloud/abra/releases/tags/$ABRA_VERSION"
 RC_VERSION="0.8.0-rc1-beta"
 RC_VERSION_URL="https://git.coopcloud.tech/api/v1/repos/coop-cloud/abra/releases/tags/$RC_VERSION"
@@ -45,9 +45,7 @@ function install_abra_release {
   fi
 
   ARCH=$(uname -m)
-  if [[ $ARCH =~ "x86_64" ]]; then
+  if [[ $ARCH =~ "aarch64" ]]; then
-      ARCH="amd64"
-  elif [[ $ARCH =~ "aarch64" ]]; then
       ARCH="arm64"
   elif [[ $ARCH =~ "armv5l" ]]; then
       ARCH="armv5"
@@ -57,7 +55,7 @@ function install_abra_release {
       ARCH="armv7"
   fi
   PLATFORM=$(uname -s | tr '[:upper:]' '[:lower:]')_$ARCH
-  FILENAME="abra_"$ABRA_VERSION"_"$PLATFORM".tar.gz"
+  FILENAME="abra_"$ABRA_VERSION"_"$PLATFORM""
   sed_command_rel='s/.*"assets":\[\{[^]]*"name":"'$FILENAME'"[^}]*"browser_download_url":"([^"]*)".*\].*/\1/p'
   sed_command_checksums='s/.*"assets":\[\{[^\]*"name":"checksums.txt"[^}]*"browser_download_url":"([^"]*)".*\].*/\1/p'
 
@@ -67,7 +65,7 @@ function install_abra_release {
 
   checksums=$(wget -q -O- $checksums_url)
   checksum=$(echo "$checksums" | grep "$FILENAME" - | sed -En 's/([0-9a-f]{64})\s+'"$FILENAME"'.*/\1/p')
-  abra_download="/tmp/abra-download.tar.gz"
+  abra_download="/tmp/abra-download"
 
   echo "downloading $ABRA_VERSION $PLATFORM binary release for abra..."
 
@@ -79,10 +77,7 @@ function install_abra_release {
       exit 1
   fi
   echo "$(tput setaf 2)check successful!$(tput sgr0)"
-  cd /tmp/
+  mv "$abra_download" "$HOME/.local/bin/abra"
-  tar xf abra-download.tar.gz
-  mv abra "$HOME/.local/bin/abra"
-  tar tf abra-download.tar.gz | xargs rm -f
   chmod +x "$HOME/.local/bin/abra"
 
   x=$(echo $PATH | grep $HOME/.local/bin)

tests/integration/app_deploy.bats

@@ -1,7 +1,6 @@
 #!/usr/bin/env bash
 
 setup_file(){
-  load "$PWD/tests/integration/helpers/git"
   load "$PWD/tests/integration/helpers/common"
   _common_setup
   _add_server
@@ -363,7 +362,6 @@ teardown(){
   _reset_app
 }
 
-# bats test_tags=slow
 @test "recipe config comments not present in values" {
   run $ABRA app deploy "$TEST_APP_DOMAIN" --no-input
   assert_success
@@ -372,36 +370,3 @@ teardown(){
   assert_success
   refute_output --partial 'should be removed'
 }
-
-# bats test_tags=slow
-@test "deploy specific version with incompatible HEAD" {
-  run sed -i 's/COMPOSE_FILE="compose.yml"/COMPOSE_FILE="compose.yml:compose.extra_secret.yml"/g' \
-    "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
-  assert_success
-
-  run sed -i 's/#SECRET_EXTRA_PASS_VERSION=v1/SECRET_EXTRA_PASS_VERSION=v1/g' \
-    "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
-  assert_success
-
-  run $ABRA app secret generate "$TEST_APP_DOMAIN" --all
-  assert_success
-  assert_output --partial 'extra_pass'
-
-  run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE/compose.extra_secret.yml"
-  assert_not_exists "$ABRA_DIR/recipes/$TEST_RECIPE/compose.extra_secret.yml"
-
-  _git_commit
-
-  # NOTE(d1): 0.1.1+1.20.2 is a previous version which includes compose.extra_secret.yml
-  run $ABRA app deploy "$TEST_APP_DOMAIN" "0.1.1+1.20.2" --no-input --no-converge-checks
-  assert_success
-  refute_output --partial 'no such file or directory'
-
-  _undeploy_app
-  _reset_app
-
-  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
-  assert_success
-
-  _reset_recipe
-}

tests/integration/app_new.bats

@@ -13,7 +13,6 @@ teardown_file(){
 
 setup(){
   load "$PWD/tests/integration/helpers/common"
-  load "$PWD/tests/integration/helpers/git"
   _common_setup
   _fetch_recipe
 }
@@ -27,6 +26,14 @@ teardown(){
   run $ABRA app new --generate-bash-completion
   assert_success
   assert_output --partial "traefik"
+  assert_output --partial "abra-test-recipe"
+
+  # Note: this test needs to be updated when a new version of the test recipe is published.
+  run $ABRA app new abra-test-recipe --generate-bash-completion
+  assert_success
+  assert_output "0.1.0+1.20.0
+0.1.1+1.20.2
+0.2.0+1.21.0"
 }
 
 @test "create new app" {
@@ -37,9 +44,8 @@ teardown(){
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 
-  _get_head_hash
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" status
-  _get_current_hash
+  assert_output --partial "up to date"
-  assert_equal "$headHash" "$currentHash"
 }
 
 @test "create new app with version" {
@@ -50,9 +56,8 @@ teardown(){
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 
-  _get_tag_hash 0.1.1+1.20.2
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" log -1
-  _get_current_hash
+  assert_output --partial "453db7121c0a56a7a8f15378f18fe3bf21ccfdef"
-  assert_equal "$tagHash" "$currentHash"
 }
 
 @test "does not overwrite existing env files" {
@@ -112,14 +117,11 @@ teardown(){
 }
 
 @test "ensure recipe up to date if no --offline" {
-  _reset_recipe
-  _get_n_hash 3
-
   run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" reset --hard HEAD~3
   assert_success
 
-  _get_current_hash
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" status
-  assert_equal "$currentHash" "$nHash"
+  assert_output --regexp 'behind .* 3 commits'
 
   run $ABRA app new "$TEST_RECIPE" \
     --no-input \
@@ -128,22 +130,18 @@ teardown(){
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 
-  _get_head_hash
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" status
-  _get_current_hash
+  assert_output --partial "up to date"
-  assert_equal "$HEAD_HASH" "$CURRENT_HASH"
 
   _reset_recipe
 }
 
 @test "ensure recipe not up to date if --offline" {
-  _reset_recipe
-  _get_n_hash 3
-
   run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" reset --hard HEAD~3
   assert_success
 
-  _get_current_hash
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" status
-  assert_equal "$currentHash" "$nHash"
+  assert_output --regexp 'behind .* 3 commits'
 
   # NOTE(d1): need to use --chaos to force same commit
   run $ABRA app new "$TEST_RECIPE" \
@@ -155,13 +153,12 @@ teardown(){
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 
-  _get_current_hash
+  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" status
-  assert_equal "$currentHash" "$nHash"
+  assert_output --regexp 'behind .* 3 commits'
 
   _reset_recipe
 }
 
-# bats test_tags=slow
 @test "generate secrets" {
   run $ABRA app new "$TEST_RECIPE" \
     --no-input \

tests/integration/app_remove.bats

@@ -104,6 +104,9 @@ teardown(){
 
   _undeploy_app
 
+  # TODO: should wait as long as volume is no longer in use
+  sleep 10
+
   run $ABRA app volume rm "$TEST_APP_DOMAIN" --no-input
   assert_success
 

tests/integration/app_secret.bats

@@ -19,13 +19,6 @@ teardown_file(){
   _reset_recipe
 }
 
-teardown() {
-  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
-  _reset_app
-  _reset_recipe
-  _checkout_recipe
-}
-
 setup(){
   load "$PWD/tests/integration/helpers/common"
   _common_setup
@@ -84,6 +77,9 @@ setup(){
   assert_output --partial 'test_pass_one'
   assert_output --partial 'test_pass_two'
   refute_output --partial 'extra_pass'
+
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
+  assert_success
 }
 
 @test "generate: broken if missing version" {
@@ -95,6 +91,7 @@ setup(){
   assert_failure
   assert_output --partial 'missing version'
 
+  _reset_app
 }
 
 @test "generate: use version from app env" {
@@ -111,6 +108,11 @@ setup(){
   assert_success
   assert_output --partial 'v2'
   refute_output --partial 'v1'
+
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
+  assert_success
+
+  _reset_app
 }
 
 @test "generate: generate extra secret based on COMPOSE_FILE" {
@@ -129,6 +131,11 @@ setup(){
   run docker -c "$TEST_SERVER" secret ls
   assert_success
   assert_output --partial "$TEST_APP_DOMAIN_extra_pass_v1"
+
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
+  assert_success
+
+  _reset_app
 }
 
 @test "generate: bail if unstaged changes and no --chaos" {
@@ -155,6 +162,8 @@ setup(){
 
   run $ABRA app secret rm "$TEST_APP_DOMAIN" --all --chaos
   assert_success
+
+  _checkout_recipe
 }
 
 @test "generate: ensure secret name uses trimmed stack name" {
@@ -219,22 +228,9 @@ setup(){
   run $ABRA app secret ls "$TEST_APP_DOMAIN"
   assert_success
   assert_output --partial 'true'
-}
 
-@test "insert: create secret from file" {
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" test_pass_one
-  run $ABRA app secret ls "$TEST_APP_DOMAIN"
   assert_success
-  assert_output --partial 'false'
-
-  run bash -c "echo bar >> $ABRA_DIR/recipes/$TEST_RECIPE/foo"
-
-  run $ABRA app secret insert --file "$TEST_APP_DOMAIN" test_pass_one v1 "$ABRA_DIR/recipes/$TEST_RECIPE/foo"
-  assert_success
-  assert_output --partial 'successfully stored on server'
-
-  run $ABRA app secret ls "$TEST_APP_DOMAIN"
-  assert_success
-  assert_output --partial 'true'
 }
 
 @test "rm: validate arguments" {
@@ -318,6 +314,9 @@ setup(){
   run $ABRA app secret ls "$TEST_APP_DOMAIN"
   assert_success
   assert_output --partial 'true'
+
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
+  assert_success
 }
 
 @test "ls: show secrets as machine readable" {
@@ -331,6 +330,9 @@ setup(){
   run $ABRA app secret ls "$TEST_APP_DOMAIN" --machine
   assert_success
   assert_output --partial '"created-on-server":"true"'
+
+  run $ABRA app secret rm "$TEST_APP_DOMAIN" --all
+  assert_success
 }
 
 @test "ls: bail if unstaged changes and no --chaos" {

tests/integration/app_volume.bats

@@ -78,6 +78,9 @@ teardown(){
 
   _undeploy_app
 
+  # NOTE(d1): to let the stack come down before nuking volumes
+  sleep 10
+
   run $ABRA app volume rm "$TEST_APP_DOMAIN" --force
   assert_success
   assert_output --partial 'volumes removed successfully'
@@ -89,6 +92,9 @@ teardown(){
 
   _undeploy_app
 
+  # NOTE(d1): to let the stack come down before nuking volumes
+  sleep 10
+
   run $ABRA app volume rm "$TEST_APP_DOMAIN" --force
   assert_success
   assert_output --partial 'volumes removed successfully'

tests/integration/helpers/app.bash

@@ -1,17 +1,18 @@
 #!/usr/bin/env bash
 
 _new_app() {
-  run $ABRA app new "$TEST_RECIPE" \
+  run $ABRA app new \
     --no-input \
     --server "$TEST_SERVER" \
     --domain "$TEST_APP_DOMAIN" \
-    --secrets
+    --secrets \
+    "$TEST_RECIPE"
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 }
 
 _deploy_app() {
-  run $ABRA app deploy "$TEST_APP_DOMAIN" --no-input
+  run $ABRA app deploy --no-input "$TEST_APP_DOMAIN"
   assert_success
 
   run $ABRA app ls --server "$TEST_SERVER" --status
@@ -21,7 +22,7 @@ _deploy_app() {
 }
 
 _undeploy_app() {
-  run $ABRA app undeploy "$TEST_APP_DOMAIN" --no-input
+  run $ABRA app undeploy --no-input "$TEST_APP_DOMAIN"
   assert_success
 
   run $ABRA app ls --server "$TEST_SERVER" --status
@@ -34,10 +35,10 @@ _rm_app() {
   # NOTE(d1): not asserting outcomes on teardown here since some might fail
   # depending on what the test created. all commands run through anyway
   if [[ -f "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env" ]]; then
-    run $ABRA app undeploy "$TEST_APP_DOMAIN" --no-input
+    run $ABRA app undeploy --no-input "$TEST_APP_DOMAIN"
-    run $ABRA app secret remove "$TEST_APP_DOMAIN" --all --no-input
+    run $ABRA app secret remove --all --no-input "$TEST_APP_DOMAIN"
-    run $ABRA app volume remove "$TEST_APP_DOMAIN" --no-input
+    run $ABRA app volume remove --no-input "$TEST_APP_DOMAIN"
-    run $ABRA app remove "$TEST_APP_DOMAIN" --no-input
+    run $ABRA app remove --no-input "$TEST_APP_DOMAIN"
   fi
 }
 
@@ -46,10 +47,11 @@ _reset_app(){
   assert_success
   assert_not_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 
-  run $ABRA app new "$TEST_RECIPE" \
+  run $ABRA app new \
     --no-input \
     --server "$TEST_SERVER" \
-    --domain "$TEST_APP_DOMAIN"
+    --domain "$TEST_APP_DOMAIN" \
+    "$TEST_RECIPE"
   assert_success
   assert_exists "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
 }

tests/integration/helpers/git.bash

@@ -32,35 +32,6 @@ _reset_tags() {
 _set_git_author() {
   run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" config --local user.email test@example.com
   assert_success
-
   run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" config --local user.name test
   assert_success
 }
-
-_git_commit() {
-  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" add .
-  assert_success
-
-  run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" commit -m "test: helpers/git.bash: _git_commit"
-  assert_success
-}
-
-_get_tag_hash() {
-  tagHash=$(git -C "$ABRA_DIR/recipes/$TEST_RECIPE" rev-list -n 1 "$1")
-  assert_success
-}
-
-_get_head_hash() {
-  headHash=$(git -C "$ABRA_DIR/recipes/$TEST_RECIPE" show -s --format="%H" HEAD)
-  assert_success
-}
-
-_get_current_hash() {
-  currentHash=$(git -C "$ABRA_DIR/recipes/$TEST_RECIPE" show -s --format="%H")
-  assert_success
-}
-
-_get_n_hash() {
-  nHash=$(git -C "$ABRA_DIR/recipes/$TEST_RECIPE" show -s --format="%H" "HEAD~$1")
-  assert_success
-}