From 3398dcb26191fdde738187b2b4a45ef4672cd6fc Mon Sep 17 00:00:00 2001 From: Victor Vieux Date: Fri, 7 Mar 2014 02:20:59 +0000 Subject: [PATCH] improve alpha sort in mflag Docker-DCO-1.1-Signed-off-by: Victor Vieux (github: vieux) Upstream-commit: 3729ece2ea1c4aad286b7535a7c137045a9da107 Component: engine --- components/engine/pkg/mflag/flag.go | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/components/engine/pkg/mflag/flag.go b/components/engine/pkg/mflag/flag.go index 7125c030ed..8b3d61e816 100644 --- a/components/engine/pkg/mflag/flag.go +++ b/components/engine/pkg/mflag/flag.go @@ -286,9 +286,24 @@ type Flag struct { DefValue string // default value (as text); for usage message } +type flagSlice []string + +func (p flagSlice) Len() int { return len(p) } +func (p flagSlice) Less(i, j int) bool { + pi, pj := p[i], p[j] + if pi[0] == '-' { + pi = pi[1:] + } + if pj[0] == '-' { + pj = pj[1:] + } + return pi < pj +} +func (p flagSlice) Swap(i, j int) { p[i], p[j] = p[j], p[i] } + // sortFlags returns the flags as a slice in lexicographical sorted order. func sortFlags(flags map[string]*Flag) []*Flag { - var list sort.StringSlice + var list flagSlice for _, f := range flags { fName := strings.TrimPrefix(f.Names[0], "#") if len(f.Names) == 1 { @@ -307,7 +322,7 @@ func sortFlags(flags map[string]*Flag) []*Flag { list = append(list, fName) } } - list.Sort() + sort.Sort(list) result := make([]*Flag, len(list)) for i, name := range list { result[i] = flags[name]