From 42e275eaf60197bb207fd1f546b01567cf8d2841 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 28 Sep 2022 17:29:01 +0200 Subject: [PATCH] cli/context/store: TestTlsCreateUpdateGetRemove(): use correct ID This test was depending on the fact that contextDir's are a string, and for the test is was using the context _name_ as a pseudo-ID. This patch updates the test to be more explicit where ID's and where names are used. Signed-off-by: Sebastiaan van Stijn --- cli/context/store/tlsstore_test.go | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/cli/context/store/tlsstore_test.go b/cli/context/store/tlsstore_test.go index 80b5d0d5f2..ede8955d4e 100644 --- a/cli/context/store/tlsstore_test.go +++ b/cli/context/store/tlsstore_test.go @@ -8,26 +8,30 @@ import ( func TestTlsCreateUpdateGetRemove(t *testing.T) { testee := tlsStore{root: t.TempDir()} - _, err := testee.getData("test-ctx", "test-ep", "test-data") + + const contextName = "test-ctx" + contextID := contextdirOf(contextName) + + _, err := testee.getData(contextID, "test-ep", "test-data") assert.Equal(t, true, IsErrTLSDataDoesNotExist(err)) - err = testee.createOrUpdate("test-ctx", "test-ep", "test-data", []byte("data")) + err = testee.createOrUpdate(contextID, "test-ep", "test-data", []byte("data")) assert.NilError(t, err) - data, err := testee.getData("test-ctx", "test-ep", "test-data") + data, err := testee.getData(contextID, "test-ep", "test-data") assert.NilError(t, err) assert.Equal(t, string(data), "data") - err = testee.createOrUpdate("test-ctx", "test-ep", "test-data", []byte("data2")) + err = testee.createOrUpdate(contextID, "test-ep", "test-data", []byte("data2")) assert.NilError(t, err) - data, err = testee.getData("test-ctx", "test-ep", "test-data") + data, err = testee.getData(contextID, "test-ep", "test-data") assert.NilError(t, err) assert.Equal(t, string(data), "data2") - err = testee.remove("test-ctx", "test-ep", "test-data") + err = testee.remove(contextID, "test-ep", "test-data") assert.NilError(t, err) - err = testee.remove("test-ctx", "test-ep", "test-data") + err = testee.remove(contextID, "test-ep", "test-data") assert.NilError(t, err) - _, err = testee.getData("test-ctx", "test-ep", "test-data") + _, err = testee.getData(contextID, "test-ep", "test-data") assert.Equal(t, true, IsErrTLSDataDoesNotExist(err)) }