Change "COMPANY_NAME" to "PACKAGER_NAME"
The COMPANY_NAME currently sets the "CompanyName" field in the metadata of Windows binaries. Our intent of this field is this field to contain information about the company/party that produced the binary. Also from [FileVersionInfo.CompanyName][FileVersionInfo.CompanyName]: > Gets the name of the company that produced the file Based on the above, "PACKAGER_NAME" is a bit more generic, and clearer on intent, and we may at some point re-use this same information to propagate equivalent fields on other platforms (rpms, debs) [FileVersionInfo.CompanyName]: https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.fileversioninfo.companyname Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
@ -1,7 +1,7 @@
|
||||
#!/usr/bin/env sh
|
||||
set -eu
|
||||
|
||||
: "${COMPANY_NAME=}"
|
||||
: "${PACKAGER_NAME=}"
|
||||
|
||||
. ./scripts/build/.variables
|
||||
|
||||
@ -31,7 +31,7 @@ cat > ./cli/winresources/versioninfo.json <<EOL
|
||||
"StringFileInfo":
|
||||
{
|
||||
"Comments": "",
|
||||
"CompanyName": "${COMPANY_NAME}",
|
||||
"CompanyName": "${PACKAGER_NAME}",
|
||||
"FileDescription": "Docker Client",
|
||||
"FileVersion": "${VERSION}",
|
||||
"InternalName": "",
|
||||
|
||||
Reference in New Issue
Block a user