diff --git a/components/engine/Dockerfile.s390x b/components/engine/Dockerfile.s390x index 8784292296..7852a96f9a 100644 --- a/components/engine/Dockerfile.s390x +++ b/components/engine/Dockerfile.s390x @@ -161,7 +161,7 @@ RUN useradd --create-home --gid docker unprivilegeduser VOLUME /var/lib/docker WORKDIR /go/src/github.com/docker/docker -ENV DOCKER_BUILDTAGS apparmor selinux +ENV DOCKER_BUILDTAGS apparmor selinux seccomp # Let us use a .bashrc file RUN ln -sfv $PWD/.bashrc ~/.bashrc diff --git a/components/engine/integration-cli/docker_cli_run_unix_test.go b/components/engine/integration-cli/docker_cli_run_unix_test.go index d427791a0f..39c9e33f2f 100644 --- a/components/engine/integration-cli/docker_cli_run_unix_test.go +++ b/components/engine/integration-cli/docker_cli_run_unix_test.go @@ -1184,7 +1184,7 @@ func (s *DockerSuite) TestRunApparmorProcDirectory(c *check.C) { // make sure the default profile can be successfully parsed (using unshare as it is // something which we know is blocked in the default profile) func (s *DockerSuite) TestRunSeccompWithDefaultProfile(c *check.C) { - testRequires(c, SameHostDaemon, seccompEnabled, NotArm, NotPpc64le) + testRequires(c, SameHostDaemon, seccompEnabled, NotArm, NotPpc64le, NotS390X) out, _, err := dockerCmdWithError("run", "--security-opt", "seccomp=../profiles/seccomp/default.json", "debian:jessie", "unshare", "--map-root-user", "--user", "sh", "-c", "whoami") c.Assert(err, checker.NotNil, check.Commentf(out)) diff --git a/components/engine/integration-cli/requirements.go b/components/engine/integration-cli/requirements.go index 74c2679476..70275e9cd8 100644 --- a/components/engine/integration-cli/requirements.go +++ b/components/engine/integration-cli/requirements.go @@ -42,6 +42,10 @@ var ( func() bool { return os.Getenv("DOCKER_ENGINE_GOARCH") != "ppc64le" }, "Test requires a daemon not running on ppc64le", } + NotS390X = testRequirement{ + func() bool { return os.Getenv("DOCKER_ENGINE_GOARCH") != "s390x" }, + "Test requires a daemon not running on s390x", + } SameHostDaemon = testRequirement{ func() bool { return isLocalDaemon }, "Test requires docker daemon to run on the same machine as CLI", diff --git a/components/engine/profiles/seccomp/seccomp_default.go b/components/engine/profiles/seccomp/seccomp_default.go index a6e2c653be..87ae358ff5 100644 --- a/components/engine/profiles/seccomp/seccomp_default.go +++ b/components/engine/profiles/seccomp/seccomp_default.go @@ -29,6 +29,8 @@ func arches() []types.Arch { return []types.Arch{types.ArchMIPSEL, types.ArchMIPSEL64, types.ArchMIPSEL64N32} case "mipsel64n32": return []types.Arch{types.ArchMIPSEL, types.ArchMIPSEL64, types.ArchMIPSEL64N32} + case "s390x": + return []types.Arch{types.ArchS390, types.ArchS390X} default: return []types.Arch{} } @@ -1579,6 +1581,7 @@ func DefaultProfile(rs *specs.Spec) *types.Seccomp { }, } + var sysCloneFlagsIndex uint var arch string var native, err = libseccomp.GetNativeArch() if err == nil { @@ -1620,6 +1623,26 @@ func DefaultProfile(rs *specs.Spec) *types.Seccomp { Args: []*types.Arg{}, }, }...) + case "s390", "s390x": + syscalls = append(syscalls, []*types.Syscall{ + { + Name: "s390_pci_mmio_read", + Action: types.ActAllow, + Args: []*types.Arg{}, + }, + { + Name: "s390_pci_mmio_write", + Action: types.ActAllow, + Args: []*types.Arg{}, + }, + { + Name: "s390_runtime_instr", + Action: types.ActAllow, + Args: []*types.Arg{}, + }, + }...) + /* Flags parameter of the clone syscall is the 2nd on s390 */ + sysCloneFlagsIndex = 1 } capSysAdmin := false @@ -1841,7 +1864,7 @@ func DefaultProfile(rs *specs.Spec) *types.Seccomp { Action: types.ActAllow, Args: []*types.Arg{ { - Index: 0, + Index: sysCloneFlagsIndex, Value: syscall.CLONE_NEWNS | syscall.CLONE_NEWUTS | syscall.CLONE_NEWIPC | syscall.CLONE_NEWUSER | syscall.CLONE_NEWPID | syscall.CLONE_NEWNET, ValueTwo: 0, Op: types.OpMaskedEqual,