From 6e39a35c8f2d5b680437f69bba1d2cf84f9110fa Mon Sep 17 00:00:00 2001 From: Vivek Goyal Date: Wed, 11 Feb 2015 11:30:45 -0500 Subject: [PATCH] manifest: Close archive once done using it manifest code calls TarLayer() and gets archive. This archive needs to be closed once caller is done using it to release the resrouces held by archive. For the devicemapper graphdriver, archive keeps a device mounted (device which is backing the layer). If archive.Close() is not called, that device remains mounted and later deletion of device fails leading to various other issues. Signed-off-by: Vivek Goyal Upstream-commit: 41bfa87b6c27b3f0041906f99ae9d0d9531db898 Component: engine --- components/engine/graph/manifest.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/components/engine/graph/manifest.go b/components/engine/graph/manifest.go index f9869fcaf2..4b9f9a631b 100644 --- a/components/engine/graph/manifest.go +++ b/components/engine/graph/manifest.go @@ -73,6 +73,8 @@ func (s *TagStore) newManifest(localName, remoteName, tag string) ([]byte, error return nil, err } + defer archive.Close() + tarSum, err := tarsum.NewTarSum(archive, true, tarsum.Version1) if err != nil { return nil, err