From 79cbff3cd31548c8a1572b5d7b370add3885c753 Mon Sep 17 00:00:00 2001 From: "Iskander (Alex) Sharipov" Date: Tue, 11 Dec 2018 16:33:23 +0300 Subject: [PATCH] registry: use len(via)!=0 instead of via!=nil This avoids the corner case where `via` is not nil, but has a length of 0, so the updated code does not panic in that situation. Signed-off-by: Iskander Sharipov (cherry picked from commit a5c185b99404ea3fbab47ff9d7ba143392566bc1) Signed-off-by: Sebastiaan van Stijn Upstream-commit: 3482a3b14a6414977bd9860c513abf06dedd6bf7 Component: engine --- components/engine/registry/registry.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/engine/registry/registry.go b/components/engine/registry/registry.go index 7a84bbfb7e..6727b7dc32 100644 --- a/components/engine/registry/registry.go +++ b/components/engine/registry/registry.go @@ -145,7 +145,7 @@ func trustedLocation(req *http.Request) bool { // addRequiredHeadersToRedirectedRequests adds the necessary redirection headers // for redirected requests func addRequiredHeadersToRedirectedRequests(req *http.Request, via []*http.Request) error { - if via != nil && via[0] != nil { + if len(via) != 0 && via[0] != nil { if trustedLocation(req) && trustedLocation(via[0]) { req.Header = via[0].Header return nil