From 869bebb91c8571fc503ad57939728426aebe2066 Mon Sep 17 00:00:00 2001
From: Erik Hollensbe <github@hollensbe.org>
Date: Thu, 8 Jan 2015 17:00:00 -0800
Subject: [PATCH] Fix a panic where RUN [] would be supplied.

Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org> (github: erikh)
Upstream-commit: 39343b86182b4e997dc991645729ae130bd0f5f2
Component: engine
---
 components/engine/builder/internals.go        | 10 +++++++---
 .../integration-cli/docker_cli_build_test.go  | 19 +++++++++++++++++++
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/components/engine/builder/internals.go b/components/engine/builder/internals.go
index 2aa747f194..692f8f2094 100644
--- a/components/engine/builder/internals.go
+++ b/components/engine/builder/internals.go
@@ -532,9 +532,13 @@ func (b *Builder) create() (*daemon.Container, error) {
 	b.TmpContainers[c.ID] = struct{}{}
 	fmt.Fprintf(b.OutStream, " ---> Running in %s\n", utils.TruncateID(c.ID))
 
-	// override the entry point that may have been picked up from the base image
-	c.Path = config.Cmd[0]
-	c.Args = config.Cmd[1:]
+	if config.Cmd != nil {
+		// override the entry point that may have been picked up from the base image
+		c.Path = config.Cmd[0]
+		c.Args = config.Cmd[1:]
+	} else {
+		config.Cmd = []string{}
+	}
 
 	return c, nil
 }
diff --git a/components/engine/integration-cli/docker_cli_build_test.go b/components/engine/integration-cli/docker_cli_build_test.go
index 927ab07324..ffc7594d0e 100644
--- a/components/engine/integration-cli/docker_cli_build_test.go
+++ b/components/engine/integration-cli/docker_cli_build_test.go
@@ -22,6 +22,25 @@ import (
 	"github.com/docker/docker/pkg/archive"
 )
 
+func TestBuildJSONEmptyRun(t *testing.T) {
+	name := "testbuildjsonemptyrun"
+	defer deleteImages(name)
+
+	_, err := buildImage(
+		name,
+		`
+    FROM busybox
+    RUN []
+    `,
+		true)
+
+	if err != nil {
+		t.Fatal("error when dealing with a RUN statement with empty JSON array")
+	}
+
+	logDone("build - RUN with an empty array should not panic")
+}
+
 func TestBuildEmptyWhitespace(t *testing.T) {
 	name := "testbuildemptywhitespace"
 	defer deleteImages(name)