diff --git a/components/engine/api/server/server.go b/components/engine/api/server/server.go index 96f5bca6a6..906e3d8e38 100644 --- a/components/engine/api/server/server.go +++ b/components/engine/api/server/server.go @@ -679,7 +679,7 @@ func deleteContainers(eng *engine.Engine, version version.Version, w http.Respon if vars == nil { return fmt.Errorf("Missing parameter") } - job := eng.Job("delete", vars["name"]) + job := eng.Job("rm", vars["name"]) job.Setenv("forceRemove", r.Form.Get("force")) diff --git a/components/engine/api/server/server_unit_test.go b/components/engine/api/server/server_unit_test.go index 950fea51d4..519652f377 100644 --- a/components/engine/api/server/server_unit_test.go +++ b/components/engine/api/server/server_unit_test.go @@ -455,7 +455,7 @@ func TestDeleteContainers(t *testing.T) { eng := engine.New() name := "foo" var called bool - eng.Register("delete", func(job *engine.Job) engine.Status { + eng.Register("rm", func(job *engine.Job) engine.Status { called = true if len(job.Args) == 0 { t.Fatalf("Job arguments is empty") diff --git a/components/engine/daemon/daemon.go b/components/engine/daemon/daemon.go index 811cb3391e..968844e3d2 100644 --- a/components/engine/daemon/daemon.go +++ b/components/engine/daemon/daemon.go @@ -98,8 +98,6 @@ type Daemon struct { // Install installs daemon capabilities to eng. func (daemon *Daemon) Install(eng *engine.Engine) error { - // FIXME: rename "delete" to "rm" for consistency with the CLI command - // FIXME: rename ContainerDestroy to ContainerRm for consistency with the CLI command // FIXME: remove ImageDelete's dependency on Daemon, then move to graph/ for name, method := range map[string]engine.Handler{ "attach": daemon.ContainerAttach, @@ -110,7 +108,7 @@ func (daemon *Daemon) Install(eng *engine.Engine) error { "container_inspect": daemon.ContainerInspect, "containers": daemon.Containers, "create": daemon.ContainerCreate, - "delete": daemon.ContainerDestroy, + "rm": daemon.ContainerRm, "export": daemon.ContainerExport, "info": daemon.CmdInfo, "kill": daemon.ContainerKill, diff --git a/components/engine/daemon/delete.go b/components/engine/daemon/delete.go index 501aed3e38..8a8331300a 100644 --- a/components/engine/daemon/delete.go +++ b/components/engine/daemon/delete.go @@ -11,8 +11,7 @@ import ( "github.com/docker/docker/pkg/log" ) -// FIXME: rename to ContainerRemove for consistency with the CLI command. -func (daemon *Daemon) ContainerDestroy(job *engine.Job) engine.Status { +func (daemon *Daemon) ContainerRm(job *engine.Job) engine.Status { if len(job.Args) != 1 { return job.Errorf("Not enough arguments. Usage: %s CONTAINER\n", job.Name) } diff --git a/components/engine/integration/server_test.go b/components/engine/integration/server_test.go index 363236fd68..d3aed039f3 100644 --- a/components/engine/integration/server_test.go +++ b/components/engine/integration/server_test.go @@ -218,7 +218,7 @@ func TestCreateStartRestartStopStartKillRm(t *testing.T) { } // FIXME: this failed once with a race condition ("Unable to remove filesystem for xxx: directory not empty") - job = eng.Job("delete", id) + job = eng.Job("rm", id) job.SetenvBool("removeVolume", true) if err := job.Run(); err != nil { t.Fatal(err)