From c733ccf2f5ec1194ed450d44d31929f893306e68 Mon Sep 17 00:00:00 2001 From: Dieter Reuter Date: Sat, 6 Aug 2016 10:20:16 +0200 Subject: [PATCH] Cleanup manpage container in build process When running a `make manpages` the image `docker-manpage-dev` will be build and started to create the man pages. But the container will not be deleted afterwards. So I propose to start it with `docker run --rm ...`, otherwise we'll collect some trash. ``` $ docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES e3d9f721d862 docker-manpage-dev "man/generate.sh" 19 minutes ago Exited (0) 16 minutes ago berserk_jang 5738a23fb682 docker-manpage-dev "man/generate.sh" 9 hours ago Exited (0) 9 hours ago boring_bartik 15490b5e63f7 docker-manpage-dev "man/generate.sh" 10 hours ago Exited (0) 10 hours ago lonely_joliot ``` Signed-off-by: Dieter Reuter Upstream-commit: 12c10239bbff1def439193d4681464640446bfbb Component: engine --- components/engine/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/engine/Makefile b/components/engine/Makefile index 945d2829a9..006f691f09 100644 --- a/components/engine/Makefile +++ b/components/engine/Makefile @@ -136,7 +136,7 @@ validate: build ## validate DCO, Seccomp profile generation, gofmt,\n./pkg/ isol manpages: ## Generate man pages from go source and markdown docker build -t docker-manpage-dev -f "man/$(DOCKERFILE)" ./man - docker run \ + docker run --rm \ -v $(PWD):/go/src/github.com/docker/docker/ \ docker-manpage-dev