diff --git a/components/engine/hack/make/validate-lint b/components/engine/hack/make/validate-lint index 038b474b1c..df7f2b007e 100644 --- a/components/engine/hack/make/validate-lint +++ b/components/engine/hack/make/validate-lint @@ -8,7 +8,6 @@ unset IFS errors=() for f in "${files[@]}"; do - # we use "git show" here to validate that what's committed passes go vet failedLint=$(golint "$f") if [ "$failedLint" ]; then errors+=( "$failedLint" ) diff --git a/components/engine/hack/make/validate-test b/components/engine/hack/make/validate-test index d9d05f3bea..8dc86f11d7 100644 --- a/components/engine/hack/make/validate-test +++ b/components/engine/hack/make/validate-test @@ -15,7 +15,7 @@ for f in "${files[@]}"; do continue fi - # we use "git show" here to validate that what's committed is formatted + # we use "git show" here to validate that what's committed doesn't contain golang built-in testing if git show "$VALIDATE_HEAD:$f" | grep -q testing.T; then badFiles+=( "$f" ) fi diff --git a/components/engine/hack/make/validate-toml b/components/engine/hack/make/validate-toml index 18f26ee757..f6393c854d 100644 --- a/components/engine/hack/make/validate-toml +++ b/components/engine/hack/make/validate-toml @@ -8,7 +8,7 @@ unset IFS badFiles=() for f in "${files[@]}"; do - # we use "git show" here to validate that what's committed is formatted + # we use "git show" here to validate that what's committed has valid toml syntax if ! git show "$VALIDATE_HEAD:$f" | tomlv /proc/self/fd/0 ; then badFiles+=( "$f" ) fi diff --git a/components/engine/hack/make/validate-vet b/components/engine/hack/make/validate-vet index febe93e5c1..d543509a53 100644 --- a/components/engine/hack/make/validate-vet +++ b/components/engine/hack/make/validate-vet @@ -8,7 +8,6 @@ unset IFS errors=() for f in "${files[@]}"; do - # we use "git show" here to validate that what's committed passes go vet failedVet=$(go vet "$f") if [ "$failedVet" ]; then errors+=( "$failedVet" )