From ba683d8df3ff1a5f6e1ae559a234936e2d719bfe Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 1 Dec 2025 13:00:44 +0100 Subject: [PATCH] opts/swarmopts: use sub-tests Signed-off-by: Sebastiaan van Stijn --- opts/swarmopts/port_test.go | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/opts/swarmopts/port_test.go b/opts/swarmopts/port_test.go index 979f6802a..5c283f2b7 100644 --- a/opts/swarmopts/port_test.go +++ b/opts/swarmopts/port_test.go @@ -137,12 +137,14 @@ func TestPortOptValidSimpleSyntax(t *testing.T) { }, } for _, tc := range testCases { - var port PortOpt - assert.NilError(t, port.Set(tc.value)) - assert.Check(t, is.Len(port.Value(), len(tc.expected))) - for _, expectedPortConfig := range tc.expected { - assertContains(t, port.Value(), expectedPortConfig) - } + t.Run(tc.value, func(t *testing.T) { + var port PortOpt + assert.NilError(t, port.Set(tc.value)) + assert.Check(t, is.Len(port.Value(), len(tc.expected))) + for _, expectedPortConfig := range tc.expected { + assertContains(t, port.Value(), expectedPortConfig) + } + }) } } @@ -228,12 +230,14 @@ func TestPortOptValidComplexSyntax(t *testing.T) { }, } for _, tc := range testCases { - var port PortOpt - assert.NilError(t, port.Set(tc.value)) - assert.Check(t, is.Len(port.Value(), len(tc.expected))) - for _, expectedPortConfig := range tc.expected { - assertContains(t, port.Value(), expectedPortConfig) - } + t.Run(tc.value, func(t *testing.T) { + var port PortOpt + assert.NilError(t, port.Set(tc.value)) + assert.Check(t, is.Len(port.Value(), len(tc.expected))) + for _, expectedPortConfig := range tc.expected { + assertContains(t, port.Value(), expectedPortConfig) + } + }) } } @@ -319,8 +323,10 @@ func TestPortOptInvalidSimpleSyntax(t *testing.T) { }, } for _, tc := range testCases { - var port PortOpt - assert.Error(t, port.Set(tc.value), tc.expectedError) + t.Run(tc.value, func(t *testing.T) { + var port PortOpt + assert.Error(t, port.Set(tc.value), tc.expectedError) + }) } }