From c8014ec50901f2bef0079942a42065f0eb463123 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 9 Oct 2025 12:22:08 +0200 Subject: [PATCH] cli/command/network: TestNetworkCreateErrors: use sub-tests Signed-off-by: Sebastiaan van Stijn --- cli/command/network/create_test.go | 41 ++++++++++++++++++++++-------- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/cli/command/network/create_test.go b/cli/command/network/create_test.go index eb4bff468..650cec190 100644 --- a/cli/command/network/create_test.go +++ b/cli/command/network/create_test.go @@ -137,18 +137,37 @@ func TestNetworkCreateErrors(t *testing.T) { } for _, tc := range testCases { - cmd := newCreateCommand( - test.NewFakeCli(&fakeClient{ - networkCreateFunc: tc.networkCreateFunc, - }), - ) - cmd.SetArgs(tc.args) - for key, value := range tc.flags { - assert.NilError(t, cmd.Flags().Set(key, value)) + var args []string + for flag, val := range tc.flags { + args = append(args, flag+"="+val) } - cmd.SetOut(io.Discard) - cmd.SetErr(io.Discard) - assert.ErrorContains(t, cmd.Execute(), tc.expectedError) + if len(tc.args) > 0 { + args = append(args, tc.args...) + } + var name string + if len(args) == 0 { + name = "no args" + } else { + name = strings.Join(args, ",") + } + t.Run(name, func(t *testing.T) { + cmd := newCreateCommand( + test.NewFakeCli(&fakeClient{ + networkCreateFunc: tc.networkCreateFunc, + }), + ) + if len(tc.args) == 0 { + cmd.SetArgs([]string{}) + } else { + cmd.SetArgs(tc.args) + } + for key, value := range tc.flags { + assert.NilError(t, cmd.Flags().Set(key, value)) + } + cmd.SetOut(io.Discard) + cmd.SetErr(io.Discard) + assert.ErrorContains(t, cmd.Execute(), tc.expectedError) + }) } }