From cde9376903dc1e3c02fe9775d71e0eede8de8d5a Mon Sep 17 00:00:00 2001 From: fate-grand-order Date: Wed, 8 Feb 2017 11:22:21 +0800 Subject: [PATCH] Correct fmt.Fprintf and t.Fatalf Signed-off-by: Helen Xie Upstream-commit: 921002137aa877fc4730fefbd5d918adacb7adde Component: engine --- components/engine/api/server/profiler.go | 6 +++--- components/engine/api/server/server_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/engine/api/server/profiler.go b/components/engine/api/server/profiler.go index 8bf8384fdb..658184b1e6 100644 --- a/components/engine/api/server/profiler.go +++ b/components/engine/api/server/profiler.go @@ -29,13 +29,13 @@ func profilerSetup(mainRouter *mux.Router) { func expVars(w http.ResponseWriter, r *http.Request) { first := true w.Header().Set("Content-Type", "application/json; charset=utf-8") - fmt.Fprintf(w, "{\n") + fmt.Fprintln(w, "{") expvar.Do(func(kv expvar.KeyValue) { if !first { - fmt.Fprintf(w, ",\n") + fmt.Fprintln(w, ",") } first = false fmt.Fprintf(w, "%q: %s", kv.Key, kv.Value) }) - fmt.Fprintf(w, "\n}\n") + fmt.Fprintln(w, "\n}") } diff --git a/components/engine/api/server/server_test.go b/components/engine/api/server/server_test.go index 11831c148d..272dc81fb6 100644 --- a/components/engine/api/server/server_test.go +++ b/components/engine/api/server/server_test.go @@ -29,7 +29,7 @@ func TestMiddlewares(t *testing.T) { localHandler := func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error { if httputils.VersionFromContext(ctx) == "" { - t.Fatalf("Expected version, got empty string") + t.Fatal("Expected version, got empty string") } if sv := w.Header().Get("Server"); !strings.Contains(sv, "Docker/0.1omega2") {