From e8fbf35f7cd85d4a449c114e104f51ad44b669a7 Mon Sep 17 00:00:00 2001
From: Solomon Hykes <solomon@docker.com>
Date: Thu, 1 May 2014 18:39:46 -0700
Subject: [PATCH] Engine: empty job names are illegal, catchall or not

Docker-DCO-1.1-Signed-off-by: Solomon Hykes <solomon@docker.com> (github: shykes)
Upstream-commit: 3b73c26194836c1e2b737146a5b0c840226c65d2
Component: engine
---
 components/engine/engine/engine.go      |  3 ++-
 components/engine/engine/engine_test.go | 16 ++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/components/engine/engine/engine.go b/components/engine/engine/engine.go
index 6f80e54b7e..58b43eca04 100644
--- a/components/engine/engine/engine.go
+++ b/components/engine/engine/engine.go
@@ -122,7 +122,8 @@ func (eng *Engine) Job(name string, args ...string) *Job {
 	// Catchall is shadowed by specific Register.
 	if handler, exists := eng.handlers[name]; exists {
 		job.handler = handler
-	} else if eng.catchall != nil {
+	} else if eng.catchall != nil && name != "" {
+		// empty job names are illegal, catchall or not.
 		job.handler = eng.catchall
 	}
 	return job
diff --git a/components/engine/engine/engine_test.go b/components/engine/engine/engine_test.go
index 8023bd58f3..de7f74012e 100644
--- a/components/engine/engine/engine_test.go
+++ b/components/engine/engine/engine_test.go
@@ -133,3 +133,19 @@ func TestParseJob(t *testing.T) {
 		t.Fatalf("Job was not called")
 	}
 }
+
+func TestCatchallEmptyName(t *testing.T) {
+	eng := New()
+	var called bool
+	eng.RegisterCatchall(func(job *Job) Status {
+		called = true
+		return StatusOK
+	})
+	err := eng.Job("").Run()
+	if err == nil {
+		t.Fatalf("Engine.Job(\"\").Run() should return an error")
+	}
+	if called {
+		t.Fatalf("Engine.Job(\"\").Run() should return an error")
+	}
+}