p4u1/docker-cli
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,757 Commits 1 Branch 0 Tags
44d96e9120bb2b20249d0ea94d651fc07b73eb9a
Commit Graph

69 Commits

Author SHA1 Message Date
Simon Ferquel
8efa6a9567 Fix tests with missing mocks 
A recent change in moby/moby made tests with missing client mocks fail with panic.
This adds those missing mocks for the impacted tests.

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
 2018-11-08 11:37:49 +01:00
Vincent Demeester
69fdd2a4ad formatter package heavy refactoring 
- make it possible to extract the formatter implementation from the
  "common" code, that way, the formatter package stays small
- extract some formatter into their own packages

This is essentially moving the "formatter" implementation of each type
in their respective packages. The *main* reason to do that, is to be
able to depend on `cli/command/formatter` without depending of the
implementation detail of the formatter. As of now, depending on
`cli/command/formatter` means we depend on `docker/docker/api/types`,
`docker/licensing`, … — that should not be the case. `formatter`
should hold the common code (or helpers) to easily create formatter,
not all formatter implementations.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-10-23 17:05:44 +02:00
Lihua Tang
ca5e453180 Typo fix 
Signed-off-by: Lihua Tang <lhtang@alauda.io>
 2018-09-07 13:28:02 +08:00
mmacy
c11acddfb5 [WIP] fix trust inspect typo 'AdminstrativeKeys' 
Signed-off-by: mmacy <marsma@microsoft.com>
 2018-08-19 17:57:04 -07:00
Silvin
3a3e720f91 Merge pull request #1283 from adshmh/refactor-trust-revoke-tests 
refactor trust revoke command unit tests
 2018-08-10 11:03:58 +02:00
Vincent Demeester
560b0cd863 Merge pull request #1280 from adshmh/refactor-trust-inspect-tests 
refactor trust inspect command unit tests
 2018-08-10 10:37:53 +02:00
Arash Deshmeh
984d76b9dd refactored trust revoke command unit tests to use table-driven style 
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
 2018-08-09 15:58:54 -04:00
Arash Deshmeh
f8f0d72cf9 refactor trust inspect command unit tests to table-driven style 
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
 2018-08-08 13:50:00 -04:00
Arash Deshmeh
04bb3c770f use sortorder lib for sorting in trust package 
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
 2018-08-08 12:20:10 -04:00
Sebastiaan van Stijn
9847e96765 Update hints for linting 
- remove some hints that are no longer needed
- added a nolint: unparam for removeSingleSigner() (return bool is only used in tests)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-07-13 11:18:50 +02:00
Arash Deshmeh
71d650ee17 refactored cli/compose and cli/command/trust to use sort.Slice and removed custom types used for sorting 
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
 2018-07-08 15:08:17 -04:00
Sebastiaan van Stijn
8de0753869 Merge pull request #1112 from n4ss/fix-trust-signer-remove 
Fix docker trust signer removal
 2018-06-15 08:18:29 -07:00
Nassim 'Nass' Eddequiouaq
92c39dd0ab Fix removeSingleSigner description 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-06-09 08:14:34 -07:00
Vincent Demeester
2c4de4fb5e Update tests to use gotest.tools 👼 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-06-08 18:24:26 +02:00
Nassim 'Nass' Eddequiouaq
2b3361cc1a Move the successful removal print 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-06-08 09:21:36 -07:00
Nassim 'Nass' Eddequiouaq
5ebb7a65ab Fix tests and nit 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-06-06 07:25:25 -07:00
Nassim 'Nass' Eddequiouaq
448082f333 Fix docker trust signer removal 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-06-05 16:04:41 -07:00
Silvin Lubecki
54f8ca6660 Fixed gometalinter errors on test files 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-10 16:03:56 +02:00
Sebastiaan van Stijn
c0ffb9491c Merge pull request #924 from vdemeester/trust-suite-tests 
Add some content trust tests
 2018-03-19 11:24:00 +01:00
Vincent Demeester
8b00c5cfd8 Add more content trust tests 
Importing from moby's DockerTrustSuite tests.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-19 10:02:40 +01:00
Victor Vieux
176aa4865c Merge pull request #935 from n4ss/trust-out-of-experimental2 
Move Docker Trust out of experimental
 2018-03-13 16:59:50 -07:00
Nassim 'Nass' Eddequiouaq
ac35e851e8 Move Docker Trust out of experimental 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 13:29:14 -08:00
Nassim 'Nass' Eddequiouaq
8c3d0b93d6 Fix comment and misc code issues 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 20:46:37 +01:00
Nassim 'Nass' Eddequiouaq
c5554f811b Refactor trust view command into a --pretty flag on trust inspect 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 19:12:11 +01:00
Vincent Demeester
6e21829af4 Refactor content_trust cli/flags handling 
Remove the global variable used. Allows easier unit testing.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-08 15:00:43 -05:00
Vincent Demeester
0cf2e6353a Fixes some unit tests to be able to run them on windows 
Some of them are skipped for now (because the feature is not supported
or needs more work), some of them are fixed.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-07 18:18:13 +01:00
Daniel Nephin
e15b208e96 Convert assert.Check(t, is.Error()) to assert.Error 
git grep -l -P '^\s+assert\.Check\(t, is\.Error\(' | \
    xargs perl -pi -e 's/^(\s+assert\.)Check\(t, is\.Error\((.*)\)$/\1Error(t, \2/'

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-06 16:00:28 -05:00
Daniel Nephin
f21276575f manual clean of asserts 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-06 15:49:00 -05:00
Daniel Nephin
078cbc9c4b Convert assert.Check with 
git grep -l -P '^\s+assert\.Check\(t, ' | \
    xargs perl -pi -e 's/^(\s+assert)\.Check(\(t, (?!is).*(\.Execute\(|\.Set\(|\.Write\(|\.Close\(|\.Untar\(|\.WriteFile\(|Validate\().*\)$)/\1.NilError\2/'

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-06 15:43:53 -05:00
Daniel Nephin
baf65a5502 Convert to assert.NilError 
Using:

  git grep -l '^\s\+assert\.Check(t, err)$' | \
    xargs sed -i -e 's/^\(\s\+assert\)\.Check(t, err)$/\1.NilError(t, err)/'

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-06 15:27:34 -05:00
Daniel Nephin
681c921528 Remove testutil 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-06 14:38:35 -05:00
Daniel Nephin
5155cda716 Post migration fixes 
Fix tests that failed when using cmp.Compare()
internal/test/testutil/assert
InDelta
Fix DeepEqual with kube metav1.Time
Convert some ErrorContains to assert

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-05 19:41:17 -05:00
Daniel Nephin
39c2ca57c1 Automated migration 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-05 19:41:17 -05:00
Sebastiaan van Stijn
d845b4d36a golint: remove redundant ifs 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-01-13 13:16:34 +01:00
Vincent Demeester
84fe1a1b5b Add support for experimental Cli configuration 
Allow to mark some commands and flags experimental on cli (i.e. not
depending to the state of the daemon). This will allow more flexibility
on experimentation with the cli.

Marking `docker trust` as cli experimental as it is documented so.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2017-12-22 14:48:47 +01:00
Riyaz Faizullabhoy
a9428285f0 Use default inspect formatting, remove omitempty, update docs 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-11-29 10:52:35 -08:00
Riyaz Faizullabhoy
1eb87cc096 support multiple arguments to trust inspect 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-11-29 10:52:34 -08:00
Riyaz Faizullabhoy
cd38d39d0d add docker trust inspect command for JSON viewing 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-11-29 10:52:34 -08:00
Kyle Spiers
a570e9b355 sign test: fix imports 
Signed-off-by: Kyle Spiers <kyle@spiers.me>
 2017-11-10 11:34:04 -08:00
Daniel Nephin
ee0615dc97 Merge pull request #575 from eiais/local-flag 
trust sign: add --local flag
 2017-11-07 14:15:53 -05:00
Kyle Spiers
f5a50650d6 trust sign: add --local flag 
Signed-off-by: Kyle Spiers <kyle@spiers.me>
 2017-10-30 16:06:03 -07:00
Brian Goff
7ca234fe24 Merge pull request #652 from thaJeztah/move-notary 
Move notary to its new location
 2017-10-30 14:05:59 -04:00
Kyle Spiers
291fdcfdbe Remove extra quotes from docker trust sign 
Signed-off-by: Kyle Spiers <kyle@spiers.me>
 2017-10-30 10:31:21 -07:00
Sebastiaan van Stijn
6cd58063fa Move notary to its new location 
The https://github.com/docker/notary repository has moved to
https://github.com/theupdateframework/notary

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2017-10-30 17:21:41 +01:00
Riyaz Faizullabhoy
e189a21a25 review feedback: updating for windows, error paths 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:55:59 +01:00
Riyaz Faizullabhoy
079471ebeb update to stderr instead of stdout, update tests 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:55:59 +01:00
Riyaz Faizullabhoy
b4ef2ddb8b revendor notary for updated import/export packages, update with rebase 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:55:59 +01:00
Riyaz Faizullabhoy
2d8cc3cd80 refactoring and adding tests for EC key types 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:55:59 +01:00
Riyaz Faizullabhoy
532d223db4 trust: move signer and key commands down one level 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:53:54 +01:00
Kyle Spiers
4e797eaa04 docs: add docs for new trust subcommands 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
 2017-10-30 16:53:54 +01:00