p4u1/docker-cli
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,455 Commits 1 Branch 0 Tags
a0066a150be45ede09fb9fa2ac92952e2d52fe19
Commit Graph

27 Commits

Author SHA1 Message Date
Sebastiaan van Stijn
f10f29df8d Allow --detach and --quiet flags when using --rollback 
Commit 78c204ef79 added
(f9bd8ec8b268581f93095c5a80679f0a8ff498bf in the moby repo)
a validation to prevent `--rollback` from being used
in combination with other flags that update the
service spec.

This validation was not taking into account that
some flags only affect the CLI behavior, and
are okay to be used when rolling back.

This patch updates the validation, and adds
`--quiet` and `--detach` to the list of allowed
flags.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2017-06-01 16:31:07 +02:00
Sebastiaan van Stijn
eea4a38cd6 Merge pull request #77 from vdemeester/move-duration-opts 
Move duration opts into an opts package
 2017-05-18 11:15:30 +02:00
Abhinandan Prativadi
40341ae089 Adding network options to service create/update 
Changes added to accept network specific options in
docker service create/update

Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
 2017-05-17 21:07:48 -07:00
Nishant Totla
39d03bb2bd Adding a flag to allow disabling registry lookup 
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
 2017-05-17 17:55:11 -07:00
Nishant Totla
c61ea6f789 Service create/update set QueryRegistry appropriately 
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
 2017-05-17 17:39:35 -07:00
Drew Erny
ebc0eff478 Add support for details on service logs 
Adds CLI and client support for details on service logs. CLI component
of moby/moby#32996.

Signed-off-by: Drew Erny <drew.erny@docker.com>
 2017-05-16 16:53:58 -07:00
Aaron Lehmann
c17acee8cf Merge pull request #48 from cyli/root-rotation-cli 
Synchronous CLI command for root CA rotation
 2017-05-16 14:58:05 -07:00
Aaron Lehmann
51f698337d Avoid loop when discarding contents of progress pipe 
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2017-05-16 14:34:59 -07:00
Aaron Lehmann
ab6bc5dce6 service: Avoid underflow in logs padding calculation 
This command inserts a variable amount of padding in the log line:

    padding := strings.Repeat(" ", f.padding-getMaxLength(task.Slot))

If the service is scaled up, or the slot numbers are noncontiguous, the
subtraction can underflow, causing a crash.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2017-05-16 12:27:31 -07:00
Vincent Demeester
b5182ba17f Move duration opts into an opts package 
They have nothing to do with service and could be used on their own.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2017-05-16 17:49:40 +02:00
Vincent Demeester
d7f6563efc Update cli imports to using local package 
Also, rename a bunch of variable to not *shadow* the `opts` package
name.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2017-05-15 14:45:19 +02:00
Aaron Lehmann
db5620026d Add support for configs 
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2017-05-11 13:42:49 -07:00
Daniel Nephin
c31d25653f Add line length linter 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-08 15:57:56 -04:00
Daniel Nephin
37ccc00d0e Add interfacer linter 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-08 15:57:50 -04:00
Gaetan de Villele
295140edf2 cli: gofmt + goimports 
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
 2017-05-08 10:51:30 -07:00
Tibor Vass
57230a7212 rm client and vendor it instead 
Signed-off-by: Tibor Vass <tibor@docker.com>
 2017-05-08 10:33:56 -07:00
Daniel Nephin
779012af69 Refacator pkg/streamformatter 
StreamFormatter suffered was two distinct structs mixed into a single struct
without any overlap.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-03 18:49:14 -07:00
yupengzte
9ca78094b5 delete ineffectual assignment 
Signed-off-by: yupengzte <yu.peng36@zte.com.cn>
 2017-05-03 18:49:14 -07:00
Evan Hazlett
25809f8991 move service runtime filter to server 
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
 2017-05-03 18:44:11 -07:00
Dong Chen
a316b380e7 do not allow duration less than 1 ms in healthcheck parameters 
Signed-off-by: Dong Chen <dongluo.chen@docker.com>
 2017-05-03 17:46:40 -07:00
Daniel Nephin
b86533c479 Add ineffassign linter. 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-02 17:57:46 -04:00
Daniel Nephin
08af0f28c5 Add gocycle lint 
Whitelist some existing offenders, and use a high limit for now.
This limit should decrese over time.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-02 17:57:46 -04:00
Daniel Nephin
8f73a12f9b Add deadcode linter. 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-02 17:57:46 -04:00
Daniel Nephin
690ef8af79 Enable golint 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-05-02 17:57:46 -04:00
Gaetan de Villele
5aa70d68b3 remove service runtime filter from client 
it’s moving to the server.

Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
 2017-04-27 15:07:20 -07:00
Daniel Nephin
10641c2aae Update imports. 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2017-04-17 18:07:56 -04:00
Daniel Nephin
1630fc40f8 Import docker/docker/cli 
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
 2017-04-17 17:40:59 -04:00