Support for API versions < v1.44 was removed in the client in [moby@96b29f5] and [moby@7652f38], so we can remove fallback-code from the CLI as well, as it won't be able to use those versions. [moby@96b29f5]:96b29f5a1f[moby@7652f38]:7652f38c28Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
143 lines
4.5 KiB
Go
143 lines
4.5 KiB
Go
package stack
|
|
|
|
import (
|
|
"errors"
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/internal/test"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func fakeClientForRemoveStackTest() *fakeClient {
|
|
allServices := []string{
|
|
objectName("foo", "service1"),
|
|
objectName("foo", "service2"),
|
|
objectName("bar", "service1"),
|
|
objectName("bar", "service2"),
|
|
}
|
|
allNetworks := []string{
|
|
objectName("foo", "network1"),
|
|
objectName("bar", "network1"),
|
|
}
|
|
allSecrets := []string{
|
|
objectName("foo", "secret1"),
|
|
objectName("foo", "secret2"),
|
|
objectName("bar", "secret1"),
|
|
}
|
|
allConfigs := []string{
|
|
objectName("foo", "config1"),
|
|
objectName("foo", "config2"),
|
|
objectName("bar", "config1"),
|
|
}
|
|
return &fakeClient{
|
|
services: allServices,
|
|
networks: allNetworks,
|
|
secrets: allSecrets,
|
|
configs: allConfigs,
|
|
}
|
|
}
|
|
|
|
func TestRemoveWithEmptyName(t *testing.T) {
|
|
cmd := newRemoveCommand(test.NewFakeCli(&fakeClient{}))
|
|
cmd.SetArgs([]string{"good", "' '", "alsogood"})
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
|
|
assert.ErrorContains(t, cmd.Execute(), `invalid stack name: "' '"`)
|
|
}
|
|
|
|
func TestRemoveStackRemovesEverything(t *testing.T) {
|
|
apiClient := fakeClientForRemoveStackTest()
|
|
cmd := newRemoveCommand(test.NewFakeCli(apiClient))
|
|
cmd.SetArgs([]string{"foo", "bar"})
|
|
|
|
assert.NilError(t, cmd.Execute())
|
|
assert.Check(t, is.DeepEqual(buildObjectIDs(apiClient.services), apiClient.removedServices))
|
|
assert.Check(t, is.DeepEqual(buildObjectIDs(apiClient.networks), apiClient.removedNetworks))
|
|
assert.Check(t, is.DeepEqual(buildObjectIDs(apiClient.secrets), apiClient.removedSecrets))
|
|
assert.Check(t, is.DeepEqual(buildObjectIDs(apiClient.configs), apiClient.removedConfigs))
|
|
}
|
|
|
|
func TestRemoveStackSkipEmpty(t *testing.T) {
|
|
allServices := []string{objectName("bar", "service1"), objectName("bar", "service2")}
|
|
allServiceIDs := buildObjectIDs(allServices)
|
|
|
|
allNetworks := []string{objectName("bar", "network1")}
|
|
allNetworkIDs := buildObjectIDs(allNetworks)
|
|
|
|
allSecrets := []string{objectName("bar", "secret1")}
|
|
allSecretIDs := buildObjectIDs(allSecrets)
|
|
|
|
allConfigs := []string{objectName("bar", "config1")}
|
|
allConfigIDs := buildObjectIDs(allConfigs)
|
|
|
|
apiClient := &fakeClient{
|
|
services: allServices,
|
|
networks: allNetworks,
|
|
secrets: allSecrets,
|
|
configs: allConfigs,
|
|
}
|
|
fakeCli := test.NewFakeCli(apiClient)
|
|
cmd := newRemoveCommand(fakeCli)
|
|
cmd.SetArgs([]string{"foo", "bar"})
|
|
|
|
assert.NilError(t, cmd.Execute())
|
|
expectedList := []string{
|
|
"Removing service bar_service1",
|
|
"Removing service bar_service2",
|
|
"Removing secret bar_secret1",
|
|
"Removing config bar_config1",
|
|
"Removing network bar_network1\n",
|
|
}
|
|
assert.Check(t, is.Equal(strings.Join(expectedList, "\n"), fakeCli.OutBuffer().String()))
|
|
assert.Check(t, is.Contains(fakeCli.ErrBuffer().String(), "Nothing found in stack: foo\n"))
|
|
assert.Check(t, is.DeepEqual(allServiceIDs, apiClient.removedServices))
|
|
assert.Check(t, is.DeepEqual(allNetworkIDs, apiClient.removedNetworks))
|
|
assert.Check(t, is.DeepEqual(allSecretIDs, apiClient.removedSecrets))
|
|
assert.Check(t, is.DeepEqual(allConfigIDs, apiClient.removedConfigs))
|
|
}
|
|
|
|
func TestRemoveContinueAfterError(t *testing.T) {
|
|
allServices := []string{objectName("foo", "service1"), objectName("bar", "service1")}
|
|
allServiceIDs := buildObjectIDs(allServices)
|
|
|
|
allNetworks := []string{objectName("foo", "network1"), objectName("bar", "network1")}
|
|
allNetworkIDs := buildObjectIDs(allNetworks)
|
|
|
|
allSecrets := []string{objectName("foo", "secret1"), objectName("bar", "secret1")}
|
|
allSecretIDs := buildObjectIDs(allSecrets)
|
|
|
|
allConfigs := []string{objectName("foo", "config1"), objectName("bar", "config1")}
|
|
allConfigIDs := buildObjectIDs(allConfigs)
|
|
|
|
removedServices := []string{}
|
|
apiClient := &fakeClient{
|
|
services: allServices,
|
|
networks: allNetworks,
|
|
secrets: allSecrets,
|
|
configs: allConfigs,
|
|
|
|
serviceRemoveFunc: func(serviceID string) error {
|
|
removedServices = append(removedServices, serviceID)
|
|
|
|
if strings.Contains(serviceID, "foo") {
|
|
return errors.New("")
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
cmd := newRemoveCommand(test.NewFakeCli(apiClient))
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
cmd.SetArgs([]string{"foo", "bar"})
|
|
|
|
assert.Error(t, cmd.Execute(), "failed to remove some resources from stack: foo")
|
|
assert.Check(t, is.DeepEqual(allServiceIDs, removedServices))
|
|
assert.Check(t, is.DeepEqual(allNetworkIDs, apiClient.removedNetworks))
|
|
assert.Check(t, is.DeepEqual(allSecretIDs, apiClient.removedSecrets))
|
|
assert.Check(t, is.DeepEqual(allConfigIDs, apiClient.removedConfigs))
|
|
}
|