This replaces the visitAll recursive function with a test that verifies that the option is set for all commands and subcommands, so that it doesn't have to be modified at runtime. We currently still have to loop over all functions for the setValidateArgs call, but that can be looked at separately. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
56 lines
1.4 KiB
Go
56 lines
1.4 KiB
Go
package checkpoint
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/moby/moby/api/types/checkpoint"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
type createOptions struct {
|
|
container string
|
|
checkpoint string
|
|
checkpointDir string
|
|
leaveRunning bool
|
|
}
|
|
|
|
func newCreateCommand(dockerCLI command.Cli) *cobra.Command {
|
|
var opts createOptions
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "create [OPTIONS] CONTAINER CHECKPOINT",
|
|
Short: "Create a checkpoint from a running container",
|
|
Args: cli.ExactArgs(2),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
opts.container = args[0]
|
|
opts.checkpoint = args[1]
|
|
return runCreate(cmd.Context(), dockerCLI, opts)
|
|
},
|
|
ValidArgsFunction: cobra.NoFileCompletions,
|
|
DisableFlagsInUseLine: true,
|
|
}
|
|
|
|
flags := cmd.Flags()
|
|
flags.BoolVar(&opts.leaveRunning, "leave-running", false, "Leave the container running after checkpoint")
|
|
flags.StringVar(&opts.checkpointDir, "checkpoint-dir", "", "Use a custom checkpoint storage directory")
|
|
|
|
return cmd
|
|
}
|
|
|
|
func runCreate(ctx context.Context, dockerCLI command.Cli, opts createOptions) error {
|
|
err := dockerCLI.Client().CheckpointCreate(ctx, opts.container, checkpoint.CreateOptions{
|
|
CheckpointID: opts.checkpoint,
|
|
CheckpointDir: opts.checkpointDir,
|
|
Exit: !opts.leaveRunning,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, _ = fmt.Fprintln(dockerCLI.Out(), opts.checkpoint)
|
|
return nil
|
|
}
|