50963accec
This was a pattern inheritted from pkg/errors.Wrapf, which ignored nil errors for convenience. However, it is error-prone, as it is not obvious when returning a nil-error. All call-sites using `wrapAsPluginError` already do a check for nil errors, so remove this code to prevent hard to find bugs. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
28 lines
640 B
Go
28 lines
640 B
Go
package manager
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestPluginError(t *testing.T) {
|
|
err := newPluginError("new error")
|
|
assert.Check(t, is.Error(err, "new error"))
|
|
|
|
inner := errors.New("testing")
|
|
err = wrapAsPluginError(inner, "wrapping")
|
|
assert.Check(t, is.Error(err, "wrapping: testing"))
|
|
assert.Check(t, is.ErrorIs(err, inner))
|
|
|
|
actual, err := json.Marshal(err)
|
|
assert.Check(t, err)
|
|
assert.Check(t, is.Equal(`"wrapping: testing"`, string(actual)))
|
|
|
|
err = wrapAsPluginError(nil, "wrapping")
|
|
assert.Check(t, is.Error(err, "wrapping: %!w(<nil>)"))
|
|
}
|